You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Alessandro Polverini (JIRA)" <in...@incubator.apache.org> on 2005/01/17 18:32:21 UTC
[jira] Created: (MYFACES-82) Status not saved correctly for all kind of elements between tab pages switch
Status not saved correctly for all kind of elements between tab pages switch
----------------------------------------------------------------------------
Key: MYFACES-82
URL: http://issues.apache.org/jira/browse/MYFACES-82
Project: MyFaces
Type: Bug
Versions: 1.0.8 beta
Environment: Tomcat5, Sun JDK 1.5.0, Debian Sarge
Reporter: Alessandro Polverini
Attachments: tabbedPane.jsp
Hello,
thanks for creating MyFaces, I'm beginning to like it very much :)
I have a problem working on tabs with the x:panelTabbedPane : the status of some elements is not correctly saved and restored when switching tabs.
I report a snip of a mail from Sylvain Vieujot from the -user mailing list, I think it can be useful for who will try to solve the problem.
---------
[...]
But we still have an issues for UISelectItems.
If someone could look at line 140 of the HtmlCheckBoxRendererBase, and line 463 of the RendererUtils, it would be great, as I think they too are using the component's value, instead of checking for a submitted value first.
I can't work on this right now as I'll be away from my computer for a week, and I don't want to take the risk of breaking it before leaving.
An easy way to test test the problem is the same as for any component : Put the component in an tab panel, with at least 2 tabs. Change the component value, and then switch to another tab.
This should set the component's submitted value, but not change the backing bean value.
When you switch back to initial tab, you should have the changed value.
If the user changes have been lost, then the component's renderer has a bug. It always renders the backing bean value instead of looking first for a submitted value.
[...]
---------
I've modified the tabbedPane.jsp page from the example of the distribution to show the bad behaviohur. To check the problem:
- fill in the controls on tab1
- switch to tab3, fill the other controls
- switch back to tab1 and you'll notice that the date lost it's value
- switch back to tab3 and also the selectboxes and radiobuttons are reset
If I find a way to attach a file to this issue I'll upload the new tabbedPane.jsp, otherwise I'll attach it on a message on the mailing list.
Thanks,
Alex
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-82) Status not saved correctly for all kind of elements between tab pages switch
Posted by "Alessandro Polverini (JIRA)" <in...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-82?page=comments#action_59604 ]
Alessandro Polverini commented on MYFACES-82:
---------------------------------------------
Please note that correct behaviour of date components was there some releases ago (sorry don't remember when, it was a CVS build), and now popped up again, so I think there is a regression problem.
> Status not saved correctly for all kind of elements between tab pages switch
> ----------------------------------------------------------------------------
>
> Key: MYFACES-82
> URL: http://issues.apache.org/jira/browse/MYFACES-82
> Project: MyFaces
> Type: Bug
> Versions: 1.0.8 beta
> Environment: Tomcat5, Sun JDK 1.5.0, Debian Sarge
> Reporter: Alessandro Polverini
> Assignee: Sylvain Vieujot
> Fix For: Nightly Build
> Attachments: tabbedPane.jsp
>
> Hello,
> thanks for creating MyFaces, I'm beginning to like it very much :)
> I have a problem working on tabs with the x:panelTabbedPane : the status of some elements is not correctly saved and restored when switching tabs.
> I report a snip of a mail from Sylvain Vieujot from the -user mailing list, I think it can be useful for who will try to solve the problem.
> ---------
> [...]
> But we still have an issues for UISelectItems.
> If someone could look at line 140 of the HtmlCheckBoxRendererBase, and line 463 of the RendererUtils, it would be great, as I think they too are using the component's value, instead of checking for a submitted value first.
> I can't work on this right now as I'll be away from my computer for a week, and I don't want to take the risk of breaking it before leaving.
> An easy way to test test the problem is the same as for any component : Put the component in an tab panel, with at least 2 tabs. Change the component value, and then switch to another tab.
> This should set the component's submitted value, but not change the backing bean value.
> When you switch back to initial tab, you should have the changed value.
> If the user changes have been lost, then the component's renderer has a bug. It always renders the backing bean value instead of looking first for a submitted value.
> [...]
> ---------
> I've modified the tabbedPane.jsp page from the example of the distribution to show the bad behaviohur. To check the problem:
> - fill in the controls on tab1
> - switch to tab3, fill the other controls
> - switch back to tab1 and you'll notice that the date lost it's value
> - switch back to tab3 and also the selectboxes and radiobuttons are reset
> If I find a way to attach a file to this issue I'll upload the new tabbedPane.jsp, otherwise I'll attach it on a message on the mailing list.
> Thanks,
> Alex
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Updated: (MYFACES-82) Status not saved correctly for all kind of elements between tab pages switch
Posted by "Alessandro Polverini (JIRA)" <in...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-82?page=history ]
Alessandro Polverini updated MYFACES-82:
----------------------------------------
Attachment: tabbedPane.jsp
This is an "updated" tab example showing the problem.
Also, being a bit nicer I suggest putting it on the distribution.
> Status not saved correctly for all kind of elements between tab pages switch
> ----------------------------------------------------------------------------
>
> Key: MYFACES-82
> URL: http://issues.apache.org/jira/browse/MYFACES-82
> Project: MyFaces
> Type: Bug
> Versions: 1.0.8 beta
> Environment: Tomcat5, Sun JDK 1.5.0, Debian Sarge
> Reporter: Alessandro Polverini
> Attachments: tabbedPane.jsp
>
> Hello,
> thanks for creating MyFaces, I'm beginning to like it very much :)
> I have a problem working on tabs with the x:panelTabbedPane : the status of some elements is not correctly saved and restored when switching tabs.
> I report a snip of a mail from Sylvain Vieujot from the -user mailing list, I think it can be useful for who will try to solve the problem.
> ---------
> [...]
> But we still have an issues for UISelectItems.
> If someone could look at line 140 of the HtmlCheckBoxRendererBase, and line 463 of the RendererUtils, it would be great, as I think they too are using the component's value, instead of checking for a submitted value first.
> I can't work on this right now as I'll be away from my computer for a week, and I don't want to take the risk of breaking it before leaving.
> An easy way to test test the problem is the same as for any component : Put the component in an tab panel, with at least 2 tabs. Change the component value, and then switch to another tab.
> This should set the component's submitted value, but not change the backing bean value.
> When you switch back to initial tab, you should have the changed value.
> If the user changes have been lost, then the component's renderer has a bug. It always renders the backing bean value instead of looking first for a submitted value.
> [...]
> ---------
> I've modified the tabbedPane.jsp page from the example of the distribution to show the bad behaviohur. To check the problem:
> - fill in the controls on tab1
> - switch to tab3, fill the other controls
> - switch back to tab1 and you'll notice that the date lost it's value
> - switch back to tab3 and also the selectboxes and radiobuttons are reset
> If I find a way to attach a file to this issue I'll upload the new tabbedPane.jsp, otherwise I'll attach it on a message on the mailing list.
> Thanks,
> Alex
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-82) Status not saved correctly for all kind of elements between tab pages switch
Posted by "Alessandro Polverini (JIRA)" <in...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-82?page=comments#action_59600 ]
Alessandro Polverini commented on MYFACES-82:
---------------------------------------------
I verified the same problem for x:inputDate component.
I'm using standard web.xml with server side state saving.
> Status not saved correctly for all kind of elements between tab pages switch
> ----------------------------------------------------------------------------
>
> Key: MYFACES-82
> URL: http://issues.apache.org/jira/browse/MYFACES-82
> Project: MyFaces
> Type: Bug
> Versions: 1.0.8 beta
> Environment: Tomcat5, Sun JDK 1.5.0, Debian Sarge
> Reporter: Alessandro Polverini
> Assignee: Sylvain Vieujot
> Fix For: Nightly Build
> Attachments: tabbedPane.jsp
>
> Hello,
> thanks for creating MyFaces, I'm beginning to like it very much :)
> I have a problem working on tabs with the x:panelTabbedPane : the status of some elements is not correctly saved and restored when switching tabs.
> I report a snip of a mail from Sylvain Vieujot from the -user mailing list, I think it can be useful for who will try to solve the problem.
> ---------
> [...]
> But we still have an issues for UISelectItems.
> If someone could look at line 140 of the HtmlCheckBoxRendererBase, and line 463 of the RendererUtils, it would be great, as I think they too are using the component's value, instead of checking for a submitted value first.
> I can't work on this right now as I'll be away from my computer for a week, and I don't want to take the risk of breaking it before leaving.
> An easy way to test test the problem is the same as for any component : Put the component in an tab panel, with at least 2 tabs. Change the component value, and then switch to another tab.
> This should set the component's submitted value, but not change the backing bean value.
> When you switch back to initial tab, you should have the changed value.
> If the user changes have been lost, then the component's renderer has a bug. It always renders the backing bean value instead of looking first for a submitted value.
> [...]
> ---------
> I've modified the tabbedPane.jsp page from the example of the distribution to show the bad behaviohur. To check the problem:
> - fill in the controls on tab1
> - switch to tab3, fill the other controls
> - switch back to tab1 and you'll notice that the date lost it's value
> - switch back to tab3 and also the selectboxes and radiobuttons are reset
> If I find a way to attach a file to this issue I'll upload the new tabbedPane.jsp, otherwise I'll attach it on a message on the mailing list.
> Thanks,
> Alex
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Resolved: (MYFACES-82) Status not saved correctly for all kind of elements between tab pages switch
Posted by "Sylvain Vieujot (JIRA)" <in...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-82?page=history ]
Sylvain Vieujot resolved MYFACES-82:
------------------------------------
Assign To: Sylvain Vieujot
Resolution: Fixed
Fix Version: Nightly Build
> Status not saved correctly for all kind of elements between tab pages switch
> ----------------------------------------------------------------------------
>
> Key: MYFACES-82
> URL: http://issues.apache.org/jira/browse/MYFACES-82
> Project: MyFaces
> Type: Bug
> Versions: 1.0.8 beta
> Environment: Tomcat5, Sun JDK 1.5.0, Debian Sarge
> Reporter: Alessandro Polverini
> Assignee: Sylvain Vieujot
> Fix For: Nightly Build
> Attachments: tabbedPane.jsp
>
> Hello,
> thanks for creating MyFaces, I'm beginning to like it very much :)
> I have a problem working on tabs with the x:panelTabbedPane : the status of some elements is not correctly saved and restored when switching tabs.
> I report a snip of a mail from Sylvain Vieujot from the -user mailing list, I think it can be useful for who will try to solve the problem.
> ---------
> [...]
> But we still have an issues for UISelectItems.
> If someone could look at line 140 of the HtmlCheckBoxRendererBase, and line 463 of the RendererUtils, it would be great, as I think they too are using the component's value, instead of checking for a submitted value first.
> I can't work on this right now as I'll be away from my computer for a week, and I don't want to take the risk of breaking it before leaving.
> An easy way to test test the problem is the same as for any component : Put the component in an tab panel, with at least 2 tabs. Change the component value, and then switch to another tab.
> This should set the component's submitted value, but not change the backing bean value.
> When you switch back to initial tab, you should have the changed value.
> If the user changes have been lost, then the component's renderer has a bug. It always renders the backing bean value instead of looking first for a submitted value.
> [...]
> ---------
> I've modified the tabbedPane.jsp page from the example of the distribution to show the bad behaviohur. To check the problem:
> - fill in the controls on tab1
> - switch to tab3, fill the other controls
> - switch back to tab1 and you'll notice that the date lost it's value
> - switch back to tab3 and also the selectboxes and radiobuttons are reset
> If I find a way to attach a file to this issue I'll upload the new tabbedPane.jsp, otherwise I'll attach it on a message on the mailing list.
> Thanks,
> Alex
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-82) Status not saved correctly for all kind of elements between tab pages switch
Posted by "Alessandro Polverini (JIRA)" <in...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-82?page=comments#action_59327 ]
Alessandro Polverini commented on MYFACES-82:
---------------------------------------------
Hello,
I checked out CVS right now and tested the release, but I still find a problem using x:selectOneRadio inside a tab.
Here is an example of the components I use inside a tab and giving problems:
<x:selectOneRadio id="sor1" value="#{mybean.value}" layout="spread">
<f:selectItem itemValue="1" itemLabel="First choice" />
<f:selectItem itemValue="2" itemLabel="Second choice" />
</x:selectOneRadio>
<x:radio for="sor1" index="0" />
<x:radio for="sor1" index="1" />
> Status not saved correctly for all kind of elements between tab pages switch
> ----------------------------------------------------------------------------
>
> Key: MYFACES-82
> URL: http://issues.apache.org/jira/browse/MYFACES-82
> Project: MyFaces
> Type: Bug
> Versions: 1.0.8 beta
> Environment: Tomcat5, Sun JDK 1.5.0, Debian Sarge
> Reporter: Alessandro Polverini
> Assignee: Sylvain Vieujot
> Fix For: Nightly Build
> Attachments: tabbedPane.jsp
>
> Hello,
> thanks for creating MyFaces, I'm beginning to like it very much :)
> I have a problem working on tabs with the x:panelTabbedPane : the status of some elements is not correctly saved and restored when switching tabs.
> I report a snip of a mail from Sylvain Vieujot from the -user mailing list, I think it can be useful for who will try to solve the problem.
> ---------
> [...]
> But we still have an issues for UISelectItems.
> If someone could look at line 140 of the HtmlCheckBoxRendererBase, and line 463 of the RendererUtils, it would be great, as I think they too are using the component's value, instead of checking for a submitted value first.
> I can't work on this right now as I'll be away from my computer for a week, and I don't want to take the risk of breaking it before leaving.
> An easy way to test test the problem is the same as for any component : Put the component in an tab panel, with at least 2 tabs. Change the component value, and then switch to another tab.
> This should set the component's submitted value, but not change the backing bean value.
> When you switch back to initial tab, you should have the changed value.
> If the user changes have been lost, then the component's renderer has a bug. It always renders the backing bean value instead of looking first for a submitted value.
> [...]
> ---------
> I've modified the tabbedPane.jsp page from the example of the distribution to show the bad behaviohur. To check the problem:
> - fill in the controls on tab1
> - switch to tab3, fill the other controls
> - switch back to tab1 and you'll notice that the date lost it's value
> - switch back to tab3 and also the selectboxes and radiobuttons are reset
> If I find a way to attach a file to this issue I'll upload the new tabbedPane.jsp, otherwise I'll attach it on a message on the mailing list.
> Thanks,
> Alex
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira