You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2019/09/12 14:30:48 UTC
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull
request #3033: Optimize performance reduce unnecessary loops
terrymanu commented on a change in pull request #3033: Optimize performance reduce unnecessary loops
URL: https://github.com/apache/incubator-shardingsphere/pull/3033#discussion_r323772923
##########
File path: sharding-proxy/sharding-proxy-transport/sharding-proxy-transport-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/transport/mysql/packet/command/MySQLCommandPacketType.java
##########
@@ -29,245 +32,256 @@
@RequiredArgsConstructor
@Getter
public enum MySQLCommandPacketType implements CommandPacketType {
-
+
/**
* COM_SLEEP.
- *
+ *
* @see <a href="https://dev.mysql.com/doc/internals/en/com-sleep.html">COM_SLEEP</a>
*/
COM_SLEEP(0x00),
-
+
/**
* COM_QUIT.
- *
+ *
* @see <a href="https://dev.mysql.com/doc/internals/en/com-quit.html">COM_QUIT</a>
*/
COM_QUIT(0x01),
-
+
/**
* COM_INIT_DB.
- *
+ *
* @see <a href="https://dev.mysql.com/doc/internals/en/com-init-db.html">COM_INIT_DB</a>
*/
COM_INIT_DB(0x02),
-
+
/**
* COM_QUERY.
- *
+ *
* @see <a href="https://dev.mysql.com/doc/internals/en/com-sleep.html#packet-COM_QUERY">COM_QUERY</a>
*/
COM_QUERY(0x03),
-
+
/**
* COM_FIELD_LIST.
- *
+ *
* @see <a href="https://dev.mysql.com/doc/internals/en/com-sleep.html#packet-COM_FIELD_LIST">COM_FIELD_LIST</a>
*/
COM_FIELD_LIST(0x04),
-
+
/**
* COM_CREATE_DB.
- *
+ *
* @see <a href="https://dev.mysql.com/doc/internals/en/com-sleep.html#packet-COM_CREATE_DB">COM_CREATE_DB</a>
*/
COM_CREATE_DB(0x05),
-
+
/**
* COM_DROP_DB.
- *
+ *
* @see <a href="https://dev.mysql.com/doc/internals/en/com-create-db.html">COM_DROP_DB</a>
*/
COM_DROP_DB(0x06),
-
+
/**
* COM_REFRESH.
- *
+ *
* @see <a href="https://dev.mysql.com/doc/internals/en/com-refresh.html">COM_REFRESH</a>
*/
COM_REFRESH(0x07),
-
+
/**
* COM_SHUTDOWN.
- *
+ *
* @see <a href="https://dev.mysql.com/doc/internals/en/com-shutdown.html">COM_SHUTDOWN</a>
*/
COM_SHUTDOWN(0x08),
-
+
/**
* COM_STATISTICS.
- *
+ *
* @see <a href="https://dev.mysql.com/doc/internals/en/com-statistics.html#packet-COM_STATISTICS">COM_STATISTICS</a>
*/
COM_STATISTICS(0x09),
-
+
/**
* COM_PROCESS_INFO.
- *
+ *
* @see <a href="https://dev.mysql.com/doc/internals/en/com-process-info.html">COM_PROCESS_INFO</a>
*/
COM_PROCESS_INFO(0x0a),
-
+
/**
* COM_CONNECT.
- *
+ *
* @see <a href="https://dev.mysql.com/doc/internals/en/com-connect.html">COM_CONNECT</a>
*/
COM_CONNECT(0x0b),
-
+
/**
* COM_PROCESS_KILL.
- *
+ *
* @see <a href="https://dev.mysql.com/doc/internals/en/com-process-kill.html">COM_PROCESS_KILL</a>
*/
COM_PROCESS_KILL(0x0c),
-
+
/**
* COM_DEBUG.
- *
+ *
* @see <a href="https://dev.mysql.com/doc/internals/en/com-debug.html">COM_DEBUG</a>
*/
COM_DEBUG(0x0d),
-
+
/**
* COM_PING.
- *
+ *
* @see <a href="https://dev.mysql.com/doc/internals/en/com-ping.html">COM_PING</a>
*/
COM_PING(0x0e),
-
+
/**
* COM_TIME.
- *
+ *
* @see <a href="https://dev.mysql.com/doc/internals/en/com-time.html">COM_TIME</a>
*/
COM_TIME(0x0f),
-
+
/**
* COM_DELAYED_INSERT.
- *
+ *
* @see <a href="https://dev.mysql.com/doc/internals/en/com-time.html">COM_DELAYED_INSERT</a>
*/
COM_DELAYED_INSERT(0x10),
-
+
/**
* COM_CHANGE_USER.
- *
+ *
* @see <a href="https://dev.mysql.com/doc/internals/en/com-sleep.html#packet-COM_CHANGE_USER">COM_CHANGE_USER</a>
*/
COM_CHANGE_USER(0x11),
-
+
/**
* COM_BINLOG_DUMP.
- *
+ *
* @see <a href="https://dev.mysql.com/doc/internals/en/com-change-user.html">COM_BINLOG_DUMP</a>
*/
COM_BINLOG_DUMP(0x12),
-
+
/**
* COM_TABLE_DUMP.
- *
+ *
* @see <a href="https://dev.mysql.com/doc/internals/en/com-table-dump.html">COM_TABLE_DUMP</a>
*/
COM_TABLE_DUMP(0x13),
-
+
/**
* COM_CONNECT_OUT.
- *
+ *
* @see <a href="https://dev.mysql.com/doc/internals/en/com-connect-out.html">COM_CONNECT_OUT</a>
*/
COM_CONNECT_OUT(0x14),
-
+
/**
* COM_REGISTER_SLAVE.
- *
+ *
* @see <a href="https://dev.mysql.com/doc/internals/en/com-register-slave.html">COM_REGISTER_SLAVE</a>
*/
COM_REGISTER_SLAVE(0x15),
-
+
/**
* COM_STMT_PREPARE.
- *
+ *
* @see <a href="https://dev.mysql.com/doc/internals/en/com-stmt-prepare.html">COM_STMT_PREPARE</a>
*/
COM_STMT_PREPARE(0x16),
-
+
/**
* COM_STMT_EXECUTE.
- *
+ *
* @see <a href="https://dev.mysql.com/doc/internals/en/com-stmt-execute.html">COM_STMT_EXECUTE</a>
*/
COM_STMT_EXECUTE(0x17),
-
+
/**
* COM_STMT_SEND_LONG_DATA.
- *
+ *
* @see <a href="https://dev.mysql.com/doc/internals/en/com-stmt-send-long-data.html">COM_STMT_SEND_LONG_DATA</a>
*/
COM_STMT_SEND_LONG_DATA(0x18),
-
+
/**
* COM_STMT_CLOSE.
- *
+ *
* @see <a href="https://dev.mysql.com/doc/internals/en/com-stmt-close.html">COM_STMT_CLOSE</a>
*/
COM_STMT_CLOSE(0x19),
-
+
/**
* COM_STMT_RESET.
- *
+ *
* @see <a href="https://dev.mysql.com/doc/internals/en/com-stmt-reset.html">COM_STMT_RESET</a>
*/
COM_STMT_RESET(0x1a),
-
+
/**
* COM_SET_OPTION.
- *
+ *
* @see <a href="https://dev.mysql.com/doc/internals/en/com-set-option.html">COM_SET_OPTION</a>
*/
COM_SET_OPTION(0x1b),
-
+
/**
* COM_STMT_FETCH.
- *
+ *
* @see <a href="https://dev.mysql.com/doc/internals/en/com-stmt-fetch.html">COM_STMT_FETCH</a>
*/
COM_STMT_FETCH(0x1c),
-
+
/**
* COM_DAEMON.
- *
+ *
* @see <a href="https://dev.mysql.com/doc/internals/en/com-daemon.html">COM_DAEMON</a>
*/
COM_DAEMON(0x1d),
-
+
/**
* COM_BINLOG_DUMP_GTID.
- *
+ *
* @see <a href="https://dev.mysql.com/doc/internals/en/com-binlog-dump-gtid.html">COM_BINLOG_DUMP_GTID</a>
*/
COM_BINLOG_DUMP_GTID(0x1e),
-
+
/**
* COM_RESET_CONNECTION.
- *
+ *
* @see <a href="https://dev.mysql.com/doc/internals/en/com-reset-connection.html">COM_RESET_CONNECTION</a>
*/
COM_RESET_CONNECTION(0x1f);
-
+
+
+ /**
+ * Cache command type.
+ */
+ private static final Map<Integer, MySQLCommandPacketType> MYSQL_COMMAND_PACKET_TYPE_CACHE = new HashMap<Integer, MySQLCommandPacketType>() {
+ {
+ for (MySQLCommandPacketType each : MySQLCommandPacketType.values()) {
+ this.put(each.value, each);
+ }
+ }
+ };
+
private final int value;
-
+
/**
* Value of integer.
- *
+ *
* @param value integer value
* @return command packet type enum
*/
public static MySQLCommandPacketType valueOf(final int value) {
- for (MySQLCommandPacketType each : MySQLCommandPacketType.values()) {
- if (value == each.value) {
- return each;
- }
+ MySQLCommandPacketType mySQLCommandPacketType = MYSQL_COMMAND_PACKET_TYPE_CACHE.get(value);
Review comment:
The name of return value should be as `result`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services