You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Fredy Wijaya (Code Review)" <ge...@cloudera.org> on 2018/05/01 19:11:53 UTC
[Impala-ASF-CR] IMPALA-6802 (part 2): Clean up authorization tests
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10269
Change subject: IMPALA-6802 (part 2): Clean up authorization tests
......................................................................
IMPALA-6802 (part 2): Clean up authorization tests
The second part of this patch is to rewrite the following
authorization tests:
- insert
- truncate
- load
- use
Testing:
- Added new authorization tests
- Ran all front-end tests
Change-Id: Ica5bfd2f12bf0cc8ebe78464a523a7805366f67b
---
M fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java
1 file changed, 310 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/10269/1
--
To view, visit http://gerrit.cloudera.org:8080/10269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ica5bfd2f12bf0cc8ebe78464a523a7805366f67b
Gerrit-Change-Number: 10269
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
[Impala-ASF-CR] IMPALA-6802 (part 2): Clean up authorization tests
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10269 )
Change subject: IMPALA-6802 (part 2): Clean up authorization tests
......................................................................
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/10269/4/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java
File fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java:
http://gerrit.cloudera.org:8080/#/c/10269/4/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java@417
PS4, Line 417: // Insert with partition.
I think the priv req test covers this. This produces the same priv requests as L402
http://gerrit.cloudera.org:8080/#/c/10269/4/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java@487
PS4, Line 487: authorize("insert into functional.zipcode_incomes(id) select '123'")
Handle this with testPrivilegeRequests()
--
To view, visit http://gerrit.cloudera.org:8080/10269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica5bfd2f12bf0cc8ebe78464a523a7805366f67b
Gerrit-Change-Number: 10269
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <gi...@holleyism.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Comment-Date: Tue, 08 May 2018 22:58:57 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6802 (part 2): Clean up authorization tests
Posted by "Adam Holley (Code Review)" <ge...@cloudera.org>.
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10269 )
Change subject: IMPALA-6802 (part 2): Clean up authorization tests
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/10269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica5bfd2f12bf0cc8ebe78464a523a7805366f67b
Gerrit-Change-Number: 10269
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <gi...@holleyism.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 May 2018 15:35:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6802 (part 2): Clean up authorization tests
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/10269 )
Change subject: IMPALA-6802 (part 2): Clean up authorization tests
......................................................................
IMPALA-6802 (part 2): Clean up authorization tests
The second part of this patch is to rewrite the following
authorization tests:
- insert
- truncate
- load
- use
Testing:
- Added new authorization tests
- Ran all front-end tests
Cherry-picks: not for 2.x
Change-Id: Ica5bfd2f12bf0cc8ebe78464a523a7805366f67b
---
M fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java
1 file changed, 322 insertions(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/10269/3
--
To view, visit http://gerrit.cloudera.org:8080/10269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ica5bfd2f12bf0cc8ebe78464a523a7805366f67b
Gerrit-Change-Number: 10269
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <gi...@holleyism.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
[Impala-ASF-CR] IMPALA-6802 (part 2): Clean up authorization tests
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10269 )
Change subject: IMPALA-6802 (part 2): Clean up authorization tests
......................................................................
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/10269/3/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java
File fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java:
http://gerrit.cloudera.org:8080/#/c/10269/3/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java@563
PS3, Line 563:
: // Use a non-existent database.
: authorize("use nodb").error(accessError("nodb.*.*"));
> I think the additional levels are unnecessary for default, but if they are
Done
http://gerrit.cloudera.org:8080/#/c/10269/3/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java@573
PS3, Line 573: .ok(onServer(TPrivilegeLevel.INSERT))
: .ok(onDatabase("functional", TPrivilegeLevel.ALL))
: .ok(onDatabase("functional", TPrivilegeLevel.INSERT))
> Same as above.
Done
--
To view, visit http://gerrit.cloudera.org:8080/10269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica5bfd2f12bf0cc8ebe78464a523a7805366f67b
Gerrit-Change-Number: 10269
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <gi...@holleyism.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 May 2018 02:41:43 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6802 (part 2): Clean up authorization tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10269 )
Change subject: IMPALA-6802 (part 2): Clean up authorization tests
......................................................................
Patch Set 6:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2429/
--
To view, visit http://gerrit.cloudera.org:8080/10269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica5bfd2f12bf0cc8ebe78464a523a7805366f67b
Gerrit-Change-Number: 10269
Gerrit-PatchSet: 6
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <gi...@holleyism.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 May 2018 00:13:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6802 (part 2): Clean up authorization tests
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10269 )
Change subject: IMPALA-6802 (part 2): Clean up authorization tests
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica5bfd2f12bf0cc8ebe78464a523a7805366f67b
Gerrit-Change-Number: 10269
Gerrit-PatchSet: 6
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <gi...@holleyism.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 May 2018 00:12:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6802 (part 2): Clean up authorization tests
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/10269 )
Change subject: IMPALA-6802 (part 2): Clean up authorization tests
......................................................................
IMPALA-6802 (part 2): Clean up authorization tests
The second part of this patch is to rewrite the following
authorization tests:
- insert
- truncate
- load
- use
Testing:
- Added new authorization tests
- Ran all front-end tests
Cherry-picks: not for 2.x
Change-Id: Ica5bfd2f12bf0cc8ebe78464a523a7805366f67b
---
M fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java
1 file changed, 282 insertions(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/10269/6
--
To view, visit http://gerrit.cloudera.org:8080/10269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ica5bfd2f12bf0cc8ebe78464a523a7805366f67b
Gerrit-Change-Number: 10269
Gerrit-PatchSet: 6
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <gi...@holleyism.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
[Impala-ASF-CR] IMPALA-6802 (part 2): Clean up authorization tests
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10269 )
Change subject: IMPALA-6802 (part 2): Clean up authorization tests
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/10269/2/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java
File fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java:
http://gerrit.cloudera.org:8080/#/c/10269/2/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java@134
PS2, Line 134: expectedAuthorizab
> nit: per conversation, can we rename to expectedAuthorizables? or expectedP
Done
http://gerrit.cloudera.org:8080/#/c/10269/2/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java@549
PS2, Line 549: AuthzTest test = authorize(
> There should be .ok() tests for onDatabase, onTable, and onColumn.
Done
--
To view, visit http://gerrit.cloudera.org:8080/10269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica5bfd2f12bf0cc8ebe78464a523a7805366f67b
Gerrit-Change-Number: 10269
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <gi...@holleyism.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Comment-Date: Thu, 03 May 2018 21:44:43 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6802 (part 2): Clean up authorization tests
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10269 )
Change subject: IMPALA-6802 (part 2): Clean up authorization tests
......................................................................
Patch Set 6:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/10269/4/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java
File fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java:
http://gerrit.cloudera.org:8080/#/c/10269/4/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java@417
PS4, Line 417: .error(insertError("functional.zipcode_incomes"), onServer(allExcept(
> I think the priv req test covers this. This produces the same priv requests
Done
http://gerrit.cloudera.org:8080/#/c/10269/4/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java@487
PS4, Line 487: .ok(onTable("functional", "alltypes", TPrivilegeLevel.INSERT),
> Handle this with testPrivilegeRequests()
Done
--
To view, visit http://gerrit.cloudera.org:8080/10269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica5bfd2f12bf0cc8ebe78464a523a7805366f67b
Gerrit-Change-Number: 10269
Gerrit-PatchSet: 6
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <gi...@holleyism.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 May 2018 00:11:02 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6802 (part 2): Clean up authorization tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10269 )
Change subject: IMPALA-6802 (part 2): Clean up authorization tests
......................................................................
Patch Set 6: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/10269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica5bfd2f12bf0cc8ebe78464a523a7805366f67b
Gerrit-Change-Number: 10269
Gerrit-PatchSet: 6
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <gi...@holleyism.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 May 2018 03:50:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6802 (part 2): Clean up authorization tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10269 )
Change subject: IMPALA-6802 (part 2): Clean up authorization tests
......................................................................
IMPALA-6802 (part 2): Clean up authorization tests
The second part of this patch is to rewrite the following
authorization tests:
- insert
- truncate
- load
- use
Testing:
- Added new authorization tests
- Ran all front-end tests
Cherry-picks: not for 2.x
Change-Id: Ica5bfd2f12bf0cc8ebe78464a523a7805366f67b
Reviewed-on: http://gerrit.cloudera.org:8080/10269
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java
1 file changed, 282 insertions(+), 23 deletions(-)
Approvals:
Alex Behm: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/10269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ica5bfd2f12bf0cc8ebe78464a523a7805366f67b
Gerrit-Change-Number: 10269
Gerrit-PatchSet: 7
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <gi...@holleyism.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-6802 (part 2): Clean up authorization tests
Posted by "Adam Holley (Code Review)" <ge...@cloudera.org>.
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10269 )
Change subject: IMPALA-6802 (part 2): Clean up authorization tests
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/10269/3/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java
File fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java:
http://gerrit.cloudera.org:8080/#/c/10269/3/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java@563
PS3, Line 563: .ok(onDatabase("functional", privilege))
: .ok(onTable("functional", "alltypes", privilege))
: .ok(onColumn("functional", "alltypes", "id", privilege));
I think the additional levels are unnecessary for default, but if they are then the privileges should be on default not functional. Or is the thinking that the default privileges might not work if there are any other privilege granted?
http://gerrit.cloudera.org:8080/#/c/10269/3/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java@573
PS3, Line 573: .ok(onDatabase("functional", privilege))
: .ok(onTable("functional", "alltypes", privilege))
: .ok(onColumn("functional", "alltypes", "id", privilege));
Same as above.
--
To view, visit http://gerrit.cloudera.org:8080/10269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica5bfd2f12bf0cc8ebe78464a523a7805366f67b
Gerrit-Change-Number: 10269
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <gi...@holleyism.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 May 2018 01:12:55 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6802 (part 2): Clean up authorization tests
Posted by "Adam Holley (Code Review)" <ge...@cloudera.org>.
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10269 )
Change subject: IMPALA-6802 (part 2): Clean up authorization tests
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/10269/2/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java
File fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java:
http://gerrit.cloudera.org:8080/#/c/10269/2/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java@134
PS2, Line 134: expectedPrivileges
nit: per conversation, can we rename to expectedAuthorizables? or expectedPrivilegeRequestNames?
http://gerrit.cloudera.org:8080/#/c/10269/2/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java@549
PS2, Line 549: authorize("use functional")
There should be .ok() tests for onDatabase, onTable, and onColumn.
--
To view, visit http://gerrit.cloudera.org:8080/10269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica5bfd2f12bf0cc8ebe78464a523a7805366f67b
Gerrit-Change-Number: 10269
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <gi...@holleyism.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Comment-Date: Thu, 03 May 2018 21:30:59 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6802 (part 2): Clean up authorization tests
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/10269 )
Change subject: IMPALA-6802 (part 2): Clean up authorization tests
......................................................................
IMPALA-6802 (part 2): Clean up authorization tests
The second part of this patch is to rewrite the following
authorization tests:
- insert
- truncate
- load
- use
Testing:
- Added new authorization tests
- Ran all front-end tests
Cherry-picks: not for 2.x
Change-Id: Ica5bfd2f12bf0cc8ebe78464a523a7805366f67b
---
M fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java
1 file changed, 308 insertions(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/10269/4
--
To view, visit http://gerrit.cloudera.org:8080/10269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ica5bfd2f12bf0cc8ebe78464a523a7805366f67b
Gerrit-Change-Number: 10269
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <gi...@holleyism.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
[Impala-ASF-CR] IMPALA-6802 (part 2): Clean up authorization tests
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/10269 )
Change subject: IMPALA-6802 (part 2): Clean up authorization tests
......................................................................
IMPALA-6802 (part 2): Clean up authorization tests
The second part of this patch is to rewrite the following
authorization tests:
- insert
- truncate
- load
- use
Testing:
- Added new authorization tests
- Ran all front-end tests
Cherry-picks: not for 2.x
Change-Id: Ica5bfd2f12bf0cc8ebe78464a523a7805366f67b
---
M fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java
1 file changed, 310 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/10269/2
--
To view, visit http://gerrit.cloudera.org:8080/10269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ica5bfd2f12bf0cc8ebe78464a523a7805366f67b
Gerrit-Change-Number: 10269
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <gi...@holleyism.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>