You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by Yunze Xu <yz...@streamnative.io.INVALID> on 2022/09/06 02:57:36 UTC
[DISCUSS] Improvements on the release process
Hi all,
I'm working on 2.8.4 release recently. When I followed the release
process, I found many steps are outdated so that I turned to the
previous release managers for help frequently. Since the release
process is now in the codebase [1], I opened a PR for some
improvements on it. [2]
PTAL especially if you have been a release manager before.
[1] https://lists.apache.org/thread/mv1to079cznkxdldrpoq5518l2ozl5kr
[2] https://github.com/apache/pulsar/pull/17470
Thanks,
Yunze
Re: [DISCUSS] Improvements on the release process
Posted by Yunze Xu <yz...@streamnative.io.INVALID>.
Hi, Michael and Haiting,
Thanks for your suggestions, I’ve updated the PR, PTAL.
Thanks,
Yunze
> On Sep 8, 2022, at 14:41, Haiting Jiang <ji...@gmail.com> wrote:
>
> Good point, Michael.
>
> Compile errors happen quite often when cherry-picking commits, even
> though there is no conflict
> but compile still may fail due to some dependency PR missing, or when
> we try to resolve some
> simple conflicts.
>
> Thanks,
> Haiting
>
> On Thu, Sep 8, 2022 at 2:26 AM Michael Marshall <mm...@apache.org> wrote:
>>
>>> If the PR can be cherry-picked directly, we should also check the
>>> CI status of the branch after we push them directly.
>>
>> In order to catch basic compilation or checkstyle errors, I always run
>> the following before pushing a cherry picked commit to an upstream
>> branch:
>>
>> mvn -Pcore-modules,-main -T 1C clean install -DskipTests -Dspotbugs.skip=true
>>
>> Running the check on your machine can be especially helpful when CI is
>> backed up or when you want to apply many commits.
>>
>> Thanks,
>> Michael
>>
>> On Wed, Sep 7, 2022 at 6:35 AM Yunze Xu <yz...@streamnative.io.invalid> wrote:
>>>
>>> Good suggestion. I will update in the PR soon.
>>>
>>> Thanks,
>>> Yunze
>>>
>>>
>>>
>>>
>>>> On Sep 6, 2022, at 15:46, Haiting Jiang <ji...@gmail.com> wrote:
>>>>
>>>> There are a lot of work before current release process, maybe we should
>>>> also include these:
>>>>
>>>> 1. Start a discussion on the mail list about the release. We can provide a
>>>> template to include more clear info about opening PRs and PRs to be
>>>> cherry-picked to the released branch.
>>>>
>>>> 2. Handling all the opening PRs and PRs to be cherry-picked.
>>>>
>>>> 2.1 Revisit the PR if it should be ported to the released branch. The
>>>> release label may not be correct.
>>>>
>>>> 2.2 Cherry-pick merged PR to the released branch. If there are too many
>>>> conflicts, we can ask the PR author to open a new PR to the released
>>>> branch. If the PR can be cherry-picked directly, we should also check the
>>>> CI status of the branch after we push them directly.
>>>>
>>>> 2.3 It would be better if we have a clear time window that we should wait
>>>> until we postpone the PR to the next release.
>>>
Re: [DISCUSS] Improvements on the release process
Posted by Haiting Jiang <ji...@gmail.com>.
Good point, Michael.
Compile errors happen quite often when cherry-picking commits, even
though there is no conflict
but compile still may fail due to some dependency PR missing, or when
we try to resolve some
simple conflicts.
Thanks,
Haiting
On Thu, Sep 8, 2022 at 2:26 AM Michael Marshall <mm...@apache.org> wrote:
>
> > If the PR can be cherry-picked directly, we should also check the
> > CI status of the branch after we push them directly.
>
> In order to catch basic compilation or checkstyle errors, I always run
> the following before pushing a cherry picked commit to an upstream
> branch:
>
> mvn -Pcore-modules,-main -T 1C clean install -DskipTests -Dspotbugs.skip=true
>
> Running the check on your machine can be especially helpful when CI is
> backed up or when you want to apply many commits.
>
> Thanks,
> Michael
>
> On Wed, Sep 7, 2022 at 6:35 AM Yunze Xu <yz...@streamnative.io.invalid> wrote:
> >
> > Good suggestion. I will update in the PR soon.
> >
> > Thanks,
> > Yunze
> >
> >
> >
> >
> > > On Sep 6, 2022, at 15:46, Haiting Jiang <ji...@gmail.com> wrote:
> > >
> > > There are a lot of work before current release process, maybe we should
> > > also include these:
> > >
> > > 1. Start a discussion on the mail list about the release. We can provide a
> > > template to include more clear info about opening PRs and PRs to be
> > > cherry-picked to the released branch.
> > >
> > > 2. Handling all the opening PRs and PRs to be cherry-picked.
> > >
> > > 2.1 Revisit the PR if it should be ported to the released branch. The
> > > release label may not be correct.
> > >
> > > 2.2 Cherry-pick merged PR to the released branch. If there are too many
> > > conflicts, we can ask the PR author to open a new PR to the released
> > > branch. If the PR can be cherry-picked directly, we should also check the
> > > CI status of the branch after we push them directly.
> > >
> > > 2.3 It would be better if we have a clear time window that we should wait
> > > until we postpone the PR to the next release.
> >
Re: [DISCUSS] Improvements on the release process
Posted by Michael Marshall <mm...@apache.org>.
> If the PR can be cherry-picked directly, we should also check the
> CI status of the branch after we push them directly.
In order to catch basic compilation or checkstyle errors, I always run
the following before pushing a cherry picked commit to an upstream
branch:
mvn -Pcore-modules,-main -T 1C clean install -DskipTests -Dspotbugs.skip=true
Running the check on your machine can be especially helpful when CI is
backed up or when you want to apply many commits.
Thanks,
Michael
On Wed, Sep 7, 2022 at 6:35 AM Yunze Xu <yz...@streamnative.io.invalid> wrote:
>
> Good suggestion. I will update in the PR soon.
>
> Thanks,
> Yunze
>
>
>
>
> > On Sep 6, 2022, at 15:46, Haiting Jiang <ji...@gmail.com> wrote:
> >
> > There are a lot of work before current release process, maybe we should
> > also include these:
> >
> > 1. Start a discussion on the mail list about the release. We can provide a
> > template to include more clear info about opening PRs and PRs to be
> > cherry-picked to the released branch.
> >
> > 2. Handling all the opening PRs and PRs to be cherry-picked.
> >
> > 2.1 Revisit the PR if it should be ported to the released branch. The
> > release label may not be correct.
> >
> > 2.2 Cherry-pick merged PR to the released branch. If there are too many
> > conflicts, we can ask the PR author to open a new PR to the released
> > branch. If the PR can be cherry-picked directly, we should also check the
> > CI status of the branch after we push them directly.
> >
> > 2.3 It would be better if we have a clear time window that we should wait
> > until we postpone the PR to the next release.
>
Re: [DISCUSS] Improvements on the release process
Posted by Yunze Xu <yz...@streamnative.io.INVALID>.
Good suggestion. I will update in the PR soon.
Thanks,
Yunze
> On Sep 6, 2022, at 15:46, Haiting Jiang <ji...@gmail.com> wrote:
>
> There are a lot of work before current release process, maybe we should
> also include these:
>
> 1. Start a discussion on the mail list about the release. We can provide a
> template to include more clear info about opening PRs and PRs to be
> cherry-picked to the released branch.
>
> 2. Handling all the opening PRs and PRs to be cherry-picked.
>
> 2.1 Revisit the PR if it should be ported to the released branch. The
> release label may not be correct.
>
> 2.2 Cherry-pick merged PR to the released branch. If there are too many
> conflicts, we can ask the PR author to open a new PR to the released
> branch. If the PR can be cherry-picked directly, we should also check the
> CI status of the branch after we push them directly.
>
> 2.3 It would be better if we have a clear time window that we should wait
> until we postpone the PR to the next release.
Re: [DISCUSS] Improvements on the release process
Posted by Haiting Jiang <ji...@gmail.com>.
Great work! Yunze.
There are a lot of work before current release process, maybe we should
also include these:
1. Start a discussion on the mail list about the release. We can provide a
template to include more clear info about opening PRs and PRs to be
cherry-picked to the released branch.
2. Handling all the opening PRs and PRs to be cherry-picked.
2.1 Revisit the PR if it should be ported to the released branch. The
release label may not be correct.
2.2 Cherry-pick merged PR to the released branch. If there are too many
conflicts, we can ask the PR author to open a new PR to the released
branch. If the PR can be cherry-picked directly, we should also check the
CI status of the branch after we push them directly.
2.3 It would be better if we have a clear time window that we should wait
until we postpone the PR to the next release.
Thanks,
Haiting
On Tue, Sep 6, 2022 at 2:24 PM Yunze Xu <yz...@streamnative.io.invalid>
wrote:
> Hi Yu,
>
> Thanks for your reminder@
>
> Thanks,
> Yunze
>
>
>
>
> > On Sep 6, 2022, at 11:56, Yu <li...@apache.org> wrote:
> >
> > Hi Yunze,
> >
> > Thanks for updating the workflow!
> >
> > ~~~~~~~~~~
> >
> > Hi all,
> >
> > For the release process, we've updated the doc-related workflow [1] since
> > we changed the doc maintenance strategy [2].
> >
> > TL;DR
> > Breaking change:
> > For release managers: from 2.8.x, you do not need to generate
> > an independent doc set for each release.
> >
> > ~~~~~~~~~~
> >
> > [1] Workflow changes:
> >
> > - For doc contributors:
> >
> https://docs.google.com/document/d/1-1uJyd1k9_h56xiiVRVOnrLcCnTmg9n7SrHhNVNEEi4/edit#bookmark=id.q5m2r5pimdi6
> >
> > - For release managers:
> >
> https://github.com/apache/pulsar/pull/17130/files#diff-f3115b8be648c3dc440594799619e7ce4408a34efab13b9d57a902030b62562c
> >
> > [2] https://github.com/apache/pulsar/issues/16637
> >
> > ~~~~~~~~~~
> >
> > Feel free to comment, thank you!
> >
> > Yu
> >
> > On Tue, Sep 6, 2022 at 10:57 AM Yunze Xu <yz...@streamnative.io.invalid>
> > wrote:
> >
> >> Hi all,
> >>
> >> I'm working on 2.8.4 release recently. When I followed the release
> >> process, I found many steps are outdated so that I turned to the
> >> previous release managers for help frequently. Since the release
> >> process is now in the codebase [1], I opened a PR for some
> >> improvements on it. [2]
> >>
> >> PTAL especially if you have been a release manager before.
> >>
> >> [1] https://lists.apache.org/thread/mv1to079cznkxdldrpoq5518l2ozl5kr
> >> [2] https://github.com/apache/pulsar/pull/17470
> >>
> >> Thanks,
> >> Yunze
> >>
> >>
> >>
> >>
> >>
>
>
Re: [DISCUSS] Improvements on the release process
Posted by Yunze Xu <yz...@streamnative.io.INVALID>.
Hi Yu,
Thanks for your reminder@
Thanks,
Yunze
> On Sep 6, 2022, at 11:56, Yu <li...@apache.org> wrote:
>
> Hi Yunze,
>
> Thanks for updating the workflow!
>
> ~~~~~~~~~~
>
> Hi all,
>
> For the release process, we've updated the doc-related workflow [1] since
> we changed the doc maintenance strategy [2].
>
> TL;DR
> Breaking change:
> For release managers: from 2.8.x, you do not need to generate
> an independent doc set for each release.
>
> ~~~~~~~~~~
>
> [1] Workflow changes:
>
> - For doc contributors:
> https://docs.google.com/document/d/1-1uJyd1k9_h56xiiVRVOnrLcCnTmg9n7SrHhNVNEEi4/edit#bookmark=id.q5m2r5pimdi6
>
> - For release managers:
> https://github.com/apache/pulsar/pull/17130/files#diff-f3115b8be648c3dc440594799619e7ce4408a34efab13b9d57a902030b62562c
>
> [2] https://github.com/apache/pulsar/issues/16637
>
> ~~~~~~~~~~
>
> Feel free to comment, thank you!
>
> Yu
>
> On Tue, Sep 6, 2022 at 10:57 AM Yunze Xu <yz...@streamnative.io.invalid>
> wrote:
>
>> Hi all,
>>
>> I'm working on 2.8.4 release recently. When I followed the release
>> process, I found many steps are outdated so that I turned to the
>> previous release managers for help frequently. Since the release
>> process is now in the codebase [1], I opened a PR for some
>> improvements on it. [2]
>>
>> PTAL especially if you have been a release manager before.
>>
>> [1] https://lists.apache.org/thread/mv1to079cznkxdldrpoq5518l2ozl5kr
>> [2] https://github.com/apache/pulsar/pull/17470
>>
>> Thanks,
>> Yunze
>>
>>
>>
>>
>>
Re: [DISCUSS] Improvements on the release process
Posted by Yu <li...@apache.org>.
Hi Yunze,
Thanks for updating the workflow!
~~~~~~~~~~
Hi all,
For the release process, we've updated the doc-related workflow [1] since
we changed the doc maintenance strategy [2].
TL;DR
Breaking change:
For release managers: from 2.8.x, you do not need to generate
an independent doc set for each release.
~~~~~~~~~~
[1] Workflow changes:
- For doc contributors:
https://docs.google.com/document/d/1-1uJyd1k9_h56xiiVRVOnrLcCnTmg9n7SrHhNVNEEi4/edit#bookmark=id.q5m2r5pimdi6
- For release managers:
https://github.com/apache/pulsar/pull/17130/files#diff-f3115b8be648c3dc440594799619e7ce4408a34efab13b9d57a902030b62562c
[2] https://github.com/apache/pulsar/issues/16637
~~~~~~~~~~
Feel free to comment, thank you!
Yu
On Tue, Sep 6, 2022 at 10:57 AM Yunze Xu <yz...@streamnative.io.invalid>
wrote:
> Hi all,
>
> I'm working on 2.8.4 release recently. When I followed the release
> process, I found many steps are outdated so that I turned to the
> previous release managers for help frequently. Since the release
> process is now in the codebase [1], I opened a PR for some
> improvements on it. [2]
>
> PTAL especially if you have been a release manager before.
>
> [1] https://lists.apache.org/thread/mv1to079cznkxdldrpoq5518l2ozl5kr
> [2] https://github.com/apache/pulsar/pull/17470
>
> Thanks,
> Yunze
>
>
>
>
>