You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2023/01/19 20:04:06 UTC
[GitHub] [ignite-3] denis-chudov opened a new pull request, #1551: IGNITE-18527
denis-chudov opened a new pull request, #1551:
URL: https://github.com/apache/ignite-3/pull/1551
https://issues.apache.org/jira/browse/IGNITE-18527
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] vldpyatkov merged pull request #1551: IGNITE-18527 Inline writeIntents into data storage on primary replica side
Posted by "vldpyatkov (via GitHub)" <gi...@apache.org>.
vldpyatkov merged PR #1551:
URL: https://github.com/apache/ignite-3/pull/1551
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] vldpyatkov commented on a diff in pull request #1551: IGNITE-18527
Posted by "vldpyatkov (via GitHub)" <gi...@apache.org>.
vldpyatkov commented on code in PR #1551:
URL: https://github.com/apache/ignite-3/pull/1551#discussion_r1084200437
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java:
##########
@@ -1388,6 +1418,62 @@ private CompletableFuture<Object> applyCmdWithExceptionHandling(Command cmd) {
});
}
+ /**
+ * Executes an Update command.
+ *
+ * @param cmd Update command.
+ * @return Raft future, see {@link #applyCmdWithExceptionHandling(Command)}.
+ */
+ private CompletableFuture<Object> applyUpdateCommand(UpdateCommand cmd) {
Review Comment:
Honestly, I do not see a sense to divide applyCmdWithExceptionHandling and updateCommand in two difference method, because they always execute both. In your case. I would merge applyUpdateCommand and updateCommand.
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java:
##########
@@ -1388,6 +1418,62 @@ private CompletableFuture<Object> applyCmdWithExceptionHandling(Command cmd) {
});
}
+ /**
+ * Executes an Update command.
+ *
+ * @param cmd Update command.
+ * @return Raft future, see {@link #applyCmdWithExceptionHandling(Command)}.
+ */
+ private CompletableFuture<Object> applyUpdateCommand(UpdateCommand cmd) {
+ return applyUpdatingCommand(cmd.txId(), () -> {
+ storageUpdateHandler.handleUpdate(
+ cmd.txId(),
+ cmd.rowUuid(),
+ cmd.tablePartitionId().asTablePartitionId(),
+ cmd.rowBuffer(),
+ null
+ );
+
+ return applyCmdWithExceptionHandling(cmd);
+ });
+ }
+
+ /**
+ * Executes an UpdateAll command.
+ *
+ * @param cmd UpdateAll command.
+ * @return Raft future, see {@link #applyCmdWithExceptionHandling(Command)}.
+ */
+ private CompletableFuture<Object> applyUpdateAllCommand(UpdateAllCommand cmd) {
Review Comment:
The same as before, I wouldn't divide applyUpdateAllCommand and updateAllCommand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] vldpyatkov commented on a diff in pull request #1551: IGNITE-18527 Inline writeIntents into data storage on primary replica side
Posted by "vldpyatkov (via GitHub)" <gi...@apache.org>.
vldpyatkov commented on code in PR #1551:
URL: https://github.com/apache/ignite-3/pull/1551#discussion_r1085814346
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java:
##########
@@ -2009,4 +2092,16 @@ private CompletableFuture<BinaryRow> toBinaryRow(@Nullable TableRow row) {
private CompletableFuture<BinaryConverter> getConverterFuture(int schemaVersion) {
return schemaFut.thenApply(schemaRegistry -> BinaryConverter.forRow(schemaRegistry.schema(schemaVersion)));
}
+
+ /**
+ * Class that stores list of futures for updates that can block tx cleanup, and locked flag.
Review Comment:
Incorrect flag name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org