You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Till Toenshoff <to...@me.com> on 2018/01/25 21:58:07 UTC
Re: Review Request 64297: Updated modules documentation with some more
details.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64297/
-----------------------------------------------------------
(Updated Jan. 25, 2018, 9:58 p.m.)
Review request for mesos, Armand Grillet, Benjamin Bannier, and Kapil Arya.
Changes
-------
Addressed comments.
Bugs: MESOS-8016
https://issues.apache.org/jira/browse/MESOS-8016
Repository: mesos
Description
-------
Added mention of HTTP authenticatee module. Added mention of
authorizer modules. Added details around hook modules.
Diffs (updated)
-----
docs/hook.md PRE-CREATION
docs/modules.md c5231e242cfe42834beeb98846c9308e0fd8dff3
Diff: https://reviews.apache.org/r/64297/diff/2/
Changes: https://reviews.apache.org/r/64297/diff/1-2/
Testing
-------
Thanks,
Till Toenshoff
Re: Review Request 64297: Updated modules documentation with some more
details.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64297/#review196293
-----------------------------------------------------------
docs/modules.md
Lines 145 (patched)
<https://reviews.apache.org/r/64297/#comment275846>
s/- Used/Used/
I wonder if there is any value in keeping the TestModule around.
- Kapil Arya
On Jan. 25, 2018, 4:58 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64297/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2018, 4:58 p.m.)
>
>
> Review request for mesos, Armand Grillet, Benjamin Bannier, and Kapil Arya.
>
>
> Bugs: MESOS-8016
> https://issues.apache.org/jira/browse/MESOS-8016
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added mention of HTTP authenticatee module. Added mention of
> authorizer modules. Added details around hook modules.
>
>
> Diffs
> -----
>
> docs/hook.md PRE-CREATION
> docs/modules.md c5231e242cfe42834beeb98846c9308e0fd8dff3
>
>
> Diff: https://reviews.apache.org/r/64297/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 64297: Updated modules documentation with some more
details.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64297/#review196296
-----------------------------------------------------------
PASS: Mesos patch 64297 was successfully built and tested.
Reviews applied: `['64297']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64297
- Mesos Reviewbot Windows
On Jan. 25, 2018, 2:16 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64297/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2018, 2:16 p.m.)
>
>
> Review request for mesos, Armand Grillet, Benjamin Bannier, and Kapil Arya.
>
>
> Bugs: MESOS-8016
> https://issues.apache.org/jira/browse/MESOS-8016
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added mention of HTTP authenticatee module. Added mention of
> authorizer modules. Added details around hook modules.
>
>
> Diffs
> -----
>
> docs/modules.md c5231e242cfe42834beeb98846c9308e0fd8dff3
>
>
> Diff: https://reviews.apache.org/r/64297/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 64297: Updated modules documentation with some more
details.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64297/#review196294
-----------------------------------------------------------
Ship it!
Ship It!
- Kapil Arya
On Jan. 25, 2018, 5:16 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64297/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2018, 5:16 p.m.)
>
>
> Review request for mesos, Armand Grillet, Benjamin Bannier, and Kapil Arya.
>
>
> Bugs: MESOS-8016
> https://issues.apache.org/jira/browse/MESOS-8016
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added mention of HTTP authenticatee module. Added mention of
> authorizer modules. Added details around hook modules.
>
>
> Diffs
> -----
>
> docs/modules.md c5231e242cfe42834beeb98846c9308e0fd8dff3
>
>
> Diff: https://reviews.apache.org/r/64297/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 64297: Updated modules documentation with some more
details.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64297/
-----------------------------------------------------------
(Updated Jan. 25, 2018, 10:16 p.m.)
Review request for mesos, Armand Grillet, Benjamin Bannier, and Kapil Arya.
Bugs: MESOS-8016
https://issues.apache.org/jira/browse/MESOS-8016
Repository: mesos
Description
-------
Added mention of HTTP authenticatee module. Added mention of
authorizer modules. Added details around hook modules.
Diffs (updated)
-----
docs/modules.md c5231e242cfe42834beeb98846c9308e0fd8dff3
Diff: https://reviews.apache.org/r/64297/diff/3/
Changes: https://reviews.apache.org/r/64297/diff/2-3/
Testing
-------
Thanks,
Till Toenshoff