[jira] Commented: (HADOOP-2084) [hbase] Add a LocalHBaseCluster

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12537493 ] 

Hadoop QA commented on HADOOP-2084:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12368336/localhbasecluster-v3.patch
against trunk revision r588083.

    @author +1.  The patch does not contain any @author tags.

    javadoc +1.  The javadoc tool did not generate any warning messages.

    javac +1.  The applied patch does not generate any new compiler warnings.

    findbugs +1.  The patch does not introduce any new Findbugs warnings.

    core tests +1.  The patch passed core unit tests.

    contrib tests +1.  The patch passed contrib unit tests.

Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/978/testReport/
Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/978/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/978/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/978/console

This message is automatically generated.

> [hbase] Add a LocalHBaseCluster
> -------------------------------
>
>                 Key: HADOOP-2084
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2084
>             Project: Hadoop
>          Issue Type: New Feature
>          Components: contrib/hbase
>            Reporter: stack
>            Assignee: stack
>            Priority: Minor
>             Fix For: 0.16.0
>
>         Attachments: localhbasecluster-v2.patch, localhbasecluster-v3.patch, localhbasecluster.patch
>
>
> Make a MiniHBaseCluster-like class named LocalHBaseCluster.  Key difference would be purge of MiniDFSCluster and FileSystem references/management and removal of utility that only makes sense in a unit testing context (Perhaps have MHBC inherit from LHBC).  Make a new class rather than move MHBC from src/test to src/java to allow for later having master and regionserver do direct method invocation rather than invocation via RPC.  LHRC would be used when hbase.master is set to the value 'local'.
> LHRC would have a shutdown method to shutdown the cluster.  MHBC brings up the cluster on construction.  Perhaps LHRC should do different and not start the cluster until invocation of startup method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.