You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/07/24 10:36:19 UTC
[GitHub] [maven] slachiewicz opened a new pull request #367: [MNG-6965] Drop Maven 2 support - stop injecting old plexus-utils
slachiewicz opened a new pull request #367:
URL: https://github.com/apache/maven/pull/367
TODO: ITs failed for few test cases: https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven/job/MNG-6965/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] asfgit closed pull request #367: [MNG-6965] Drop Maven 2 support - stop injecting old plexus-utils
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #367:
URL: https://github.com/apache/maven/pull/367
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] pzygielo commented on a change in pull request #367: [MNG-6965] Drop Maven 2 support - stop injecting old plexus-utils
Posted by GitBox <gi...@apache.org>.
pzygielo commented on a change in pull request #367:
URL: https://github.com/apache/maven/pull/367#discussion_r499156521
##########
File path: maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultPluginDependenciesResolver.java
##########
@@ -145,20 +143,19 @@ public DependencyNode resolveCoreExtension( Plugin plugin, DependencyFilter depe
List<RemoteRepository> repositories, RepositorySystemSession session )
throws PluginResolutionException
{
- return resolveInternal( plugin, null /* pluginArtifact */, dependencyFilter, null /* transformer */,
- repositories, session );
+ return resolveInternal( plugin, null /* pluginArtifact */, dependencyFilter, /* transformer */
Review comment:
```suggestion
return resolveInternal( plugin, null /* pluginArtifact */, dependencyFilter,
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org