[jira] [Commented] (THRIFT-2390) no close event when connection lost

["Jake Farrell (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-2390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13938822#comment-13938822 ] 

Jake Farrell commented on THRIFT-2390:
--------------------------------------

looks good to me, [~codesf] thoughts?

> no close event when connection lost
> -----------------------------------
>
>                 Key: THRIFT-2390
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2390
>             Project: Thrift
>          Issue Type: Bug
>          Components: Node.js - Library
>            Reporter: alexey
>
> thrift nodejs lib (master)
> There is no indication that connection lost if reconnect is not setup.
> (There is no "close" event from connection object or RPC error callback)
> File: connection.js:167
> Connection.prototype.connection_gone = function () {
>   var self = this;
>   // If a retry is already in progress, just let that happen
>   if (this.retry_timer || !this.max_attempts) {
> 	 return;
>   }
> Should be changed to 
> Connection.prototype.connection_gone = function () {
>   var self = this;
>   // If a retry is already in progress, just let that happen
>   if (this.retry_timer) {
> 	 return;
>   }
>   if(!this.max_attempts) {
>     self.emit("close");
>     return;
>   }



--
This message was sent by Atlassian JIRA
(v6.2#6252)