You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2025/08/05 20:02:09 UTC
[PR] Run config_docs CI check on PRs to change auto generated docs [datafusion]
alamb opened a new pull request, #17046:
URL: https://github.com/apache/datafusion/pull/17046
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
- Closes #.
## Rationale for this change
We now broke CI twice in the last day with docs changes that did not run the config_docs check.
Here are two PRs that fixed it:
- https://github.com/apache/datafusion/pull/17026
- https://github.com/apache/datafusion/pull/17041
(Thanks to @liamzwbao and @adamreeve for pointing them out)
let's fix the docs check to automatically run on PRs that change the auto generated files
## What changes are included in this PR?
1. Move CI check to a new file
## Are these changes tested?
I am testing them manually
## Are there any user-facing changes?
No, this is a CI process change only
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Run config_docs CI check on PRs to change auto generated docs [datafusion]
Posted by "gopidesupavan (via GitHub)" <gi...@apache.org>.
gopidesupavan commented on code in PR #17046:
URL: https://github.com/apache/datafusion/pull/17046#discussion_r2263797875
##########
.github/workflows/docs_generated.yaml:
##########
@@ -0,0 +1,77 @@
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Generated Docs
+
+concurrency:
+ group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }}
+ cancel-in-progress: true
+
+on:
+ push:
+ paths:
+ - ".github/**"
+ - "datafusion/**"
+ - "dev/update_config_docs.sh"
+ - "dev/update_function_docs.sh"
+ - "docs/source/user-guide/configs.md"
+ - "docs/source/user-guide/sql/aggregate_functions.md"
+ - "docs/source/user-guide/sql/scalar_functions.md"
+ - "docs/source/user-guide/sql/window_functions.md"
+ pull_request:
+ paths:
+ - ".github/**"
+ - "datafusion/**"
+ - "dev/update_config_docs.sh"
+ - "dev/update_function_docs.sh"
+ - "docs/source/user-guide/configs.md"
+ - "docs/source/user-guide/sql/aggregate_functions.md"
+ - "docs/source/user-guide/sql/scalar_functions.md"
+ - "docs/source/user-guide/sql/window_functions.md"
+ # manual trigger
+ # https://docs.github.com/en/actions/managing-workflow-runs/manually-running-a-workflow
+ workflow_dispatch:
+
+jobs:
+ generated-docs-check:
+ name: check configs.md and ***_functions.md is up-to-date
+ runs-on: ubuntu-latest
+ container:
+ image: amd64/rust
+ steps:
+ - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
Review Comment:
@findepi yes agree thought its managed from github tags will not protect us from any attacks if something wrong or anyone manipulates the pinned tag, commit sha is preffered way :) and its recommended way from ASF policy aswell https://infra.apache.org/github-actions-policy.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Run config_docs CI check on PRs to change auto generated docs [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #17046:
URL: https://github.com/apache/datafusion/pull/17046#discussion_r2263770464
##########
.github/workflows/docs_generated.yaml:
##########
@@ -0,0 +1,77 @@
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Generated Docs
+
+concurrency:
+ group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }}
+ cancel-in-progress: true
+
+on:
+ push:
+ paths:
+ - ".github/**"
+ - "datafusion/**"
+ - "dev/update_config_docs.sh"
+ - "dev/update_function_docs.sh"
+ - "docs/source/user-guide/configs.md"
+ - "docs/source/user-guide/sql/aggregate_functions.md"
+ - "docs/source/user-guide/sql/scalar_functions.md"
+ - "docs/source/user-guide/sql/window_functions.md"
+ pull_request:
+ paths:
+ - ".github/**"
+ - "datafusion/**"
+ - "dev/update_config_docs.sh"
+ - "dev/update_function_docs.sh"
+ - "docs/source/user-guide/configs.md"
+ - "docs/source/user-guide/sql/aggregate_functions.md"
+ - "docs/source/user-guide/sql/scalar_functions.md"
+ - "docs/source/user-guide/sql/window_functions.md"
Review Comment:
I think these are the only files that are auto generated (and thus the only .md files that can be affected by the change in the rust code). I was trying to preserve the property that most changes to the docs did not require all the rust tests to be run
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Run config_docs CI check on PRs to change auto generated docs [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #17046:
URL: https://github.com/apache/datafusion/pull/17046#discussion_r2263774931
##########
.github/workflows/docs_generated.yaml:
##########
@@ -0,0 +1,77 @@
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Generated Docs
+
+concurrency:
+ group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }}
+ cancel-in-progress: true
+
+on:
+ push:
+ paths:
+ - ".github/**"
+ - "datafusion/**"
Review Comment:
I am happy to make the jobs not run on forks -- I am not quite sure how to do it though (maybe we can make a follow on PR)
> Also, can we afford running it on main unconditionally, without path filter? This way we won't get blind when ./dev/update_config_docs.sh is changed and updates some new doc location, or depends on some new file (like rust-toolchain.toml)
Yes we could do that and I agree it would be less likely to break
I was trying to be a good corporate and eco-friendly by minimizing the number of extra CI runs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Run config_docs CI check on PRs to change auto generated docs [datafusion]
Posted by "findepi (via GitHub)" <gi...@apache.org>.
findepi commented on code in PR #17046:
URL: https://github.com/apache/datafusion/pull/17046#discussion_r2259750941
##########
.github/workflows/docs_generated.yaml:
##########
@@ -0,0 +1,77 @@
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Generated Docs
+
+concurrency:
+ group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }}
+ cancel-in-progress: true
+
+on:
+ push:
+ paths:
+ - ".github/**"
+ - "datafusion/**"
+ - "dev/update_config_docs.sh"
+ - "dev/update_function_docs.sh"
+ - "docs/source/user-guide/configs.md"
+ - "docs/source/user-guide/sql/aggregate_functions.md"
+ - "docs/source/user-guide/sql/scalar_functions.md"
+ - "docs/source/user-guide/sql/window_functions.md"
+ pull_request:
+ paths:
+ - ".github/**"
+ - "datafusion/**"
+ - "dev/update_config_docs.sh"
+ - "dev/update_function_docs.sh"
+ - "docs/source/user-guide/configs.md"
+ - "docs/source/user-guide/sql/aggregate_functions.md"
+ - "docs/source/user-guide/sql/scalar_functions.md"
+ - "docs/source/user-guide/sql/window_functions.md"
Review Comment:
Easy to miss adding a new document here.
Can we run this workflow on any changes to the user guide?
##########
.github/workflows/docs_generated.yaml:
##########
@@ -0,0 +1,77 @@
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Generated Docs
+
+concurrency:
+ group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }}
+ cancel-in-progress: true
+
+on:
+ push:
+ paths:
+ - ".github/**"
+ - "datafusion/**"
+ - "dev/update_config_docs.sh"
+ - "dev/update_function_docs.sh"
+ - "docs/source/user-guide/configs.md"
+ - "docs/source/user-guide/sql/aggregate_functions.md"
+ - "docs/source/user-guide/sql/scalar_functions.md"
+ - "docs/source/user-guide/sql/window_functions.md"
+ pull_request:
+ paths:
+ - ".github/**"
+ - "datafusion/**"
Review Comment:
Cargo.toml, cargo.lock, rust-toolchain.toml, ?
##########
.github/workflows/docs_generated.yaml:
##########
@@ -0,0 +1,77 @@
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Generated Docs
+
+concurrency:
+ group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }}
+ cancel-in-progress: true
+
+on:
+ push:
+ paths:
+ - ".github/**"
+ - "datafusion/**"
Review Comment:
This will have the downside of running on forks on dev branches as well. Worth limiting to just `main`? (i am aware the dev workflow doesn't limit itself)
Also, can we afford running it on main unconditionally, without path filter? This way we won't get blind when `./dev/update_config_docs.sh` is changed and updates some new doc location, or depends on some new file (like `rust-toolchain.toml`)
##########
.github/workflows/docs_generated.yaml:
##########
@@ -0,0 +1,77 @@
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Generated Docs
+
+concurrency:
+ group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }}
+ cancel-in-progress: true
+
+on:
+ push:
+ paths:
+ - ".github/**"
+ - "datafusion/**"
+ - "dev/update_config_docs.sh"
+ - "dev/update_function_docs.sh"
+ - "docs/source/user-guide/configs.md"
+ - "docs/source/user-guide/sql/aggregate_functions.md"
+ - "docs/source/user-guide/sql/scalar_functions.md"
+ - "docs/source/user-guide/sql/window_functions.md"
+ pull_request:
+ paths:
+ - ".github/**"
+ - "datafusion/**"
+ - "dev/update_config_docs.sh"
+ - "dev/update_function_docs.sh"
+ - "docs/source/user-guide/configs.md"
+ - "docs/source/user-guide/sql/aggregate_functions.md"
+ - "docs/source/user-guide/sql/scalar_functions.md"
+ - "docs/source/user-guide/sql/window_functions.md"
+ # manual trigger
+ # https://docs.github.com/en/actions/managing-workflow-runs/manually-running-a-workflow
+ workflow_dispatch:
+
+jobs:
+ generated-docs-check:
+ name: check configs.md and ***_functions.md is up-to-date
+ runs-on: ubuntu-latest
+ container:
+ image: amd64/rust
+ steps:
+ - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
Review Comment:
I think `actions/checkout` is controlled by GitHub. I believe it's safe to use tag reference on this one and the setup-node as well.
##########
.github/workflows/docs_generated.yaml:
##########
@@ -0,0 +1,77 @@
+
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Run config_docs CI check on PRs to change auto generated docs [datafusion]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #17046: Run config_docs CI check on PRs to change auto generated docs
URL: https://github.com/apache/datafusion/pull/17046
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Run config_docs CI check on PRs to change auto generated docs [datafusion]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17046:
URL: https://github.com/apache/datafusion/pull/17046#issuecomment-3417700217
Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Run config_docs CI check on PRs to change auto generated docs [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #17046:
URL: https://github.com/apache/datafusion/pull/17046#discussion_r2263772727
##########
.github/workflows/docs_generated.yaml:
##########
@@ -0,0 +1,77 @@
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Generated Docs
+
+concurrency:
+ group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }}
+ cancel-in-progress: true
+
+on:
+ push:
+ paths:
+ - ".github/**"
+ - "datafusion/**"
+ - "dev/update_config_docs.sh"
+ - "dev/update_function_docs.sh"
+ - "docs/source/user-guide/configs.md"
+ - "docs/source/user-guide/sql/aggregate_functions.md"
+ - "docs/source/user-guide/sql/scalar_functions.md"
+ - "docs/source/user-guide/sql/window_functions.md"
+ pull_request:
+ paths:
+ - ".github/**"
+ - "datafusion/**"
+ - "dev/update_config_docs.sh"
+ - "dev/update_function_docs.sh"
+ - "docs/source/user-guide/configs.md"
+ - "docs/source/user-guide/sql/aggregate_functions.md"
+ - "docs/source/user-guide/sql/scalar_functions.md"
+ - "docs/source/user-guide/sql/window_functions.md"
+ # manual trigger
+ # https://docs.github.com/en/actions/managing-workflow-runs/manually-running-a-workflow
+ workflow_dispatch:
+
+jobs:
+ generated-docs-check:
+ name: check configs.md and ***_functions.md is up-to-date
+ runs-on: ubuntu-latest
+ container:
+ image: amd64/rust
+ steps:
+ - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
Review Comment:
This is copyied from the existing jobs
They were pinned to shas in this PR by @gopidesupavan i think as an added level of protection
- https://github.com/apache/datafusion/pull/16964
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Run config_docs CI check on PRs to change auto generated docs [datafusion]
Posted by "findepi (via GitHub)" <gi...@apache.org>.
findepi commented on code in PR #17046:
URL: https://github.com/apache/datafusion/pull/17046#discussion_r2263819885
##########
.github/workflows/docs_generated.yaml:
##########
@@ -0,0 +1,77 @@
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Generated Docs
+
+concurrency:
+ group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }}
+ cancel-in-progress: true
+
+on:
+ push:
+ paths:
+ - ".github/**"
+ - "datafusion/**"
+ - "dev/update_config_docs.sh"
+ - "dev/update_function_docs.sh"
+ - "docs/source/user-guide/configs.md"
+ - "docs/source/user-guide/sql/aggregate_functions.md"
+ - "docs/source/user-guide/sql/scalar_functions.md"
+ - "docs/source/user-guide/sql/window_functions.md"
+ pull_request:
+ paths:
+ - ".github/**"
+ - "datafusion/**"
+ - "dev/update_config_docs.sh"
+ - "dev/update_function_docs.sh"
+ - "docs/source/user-guide/configs.md"
+ - "docs/source/user-guide/sql/aggregate_functions.md"
+ - "docs/source/user-guide/sql/scalar_functions.md"
+ - "docs/source/user-guide/sql/window_functions.md"
+ # manual trigger
+ # https://docs.github.com/en/actions/managing-workflow-runs/manually-running-a-workflow
+ workflow_dispatch:
+
+jobs:
+ generated-docs-check:
+ name: check configs.md and ***_functions.md is up-to-date
+ runs-on: ubuntu-latest
+ container:
+ image: amd64/rust
+ steps:
+ - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
Review Comment:
i am well aware of 3rd party github actions being an "awesome" (easy) attack vector when they are not pinned to a sha. However, i think GH recommends this for 3rd party actions, not github-owned actions
from ASF page linked above
> You MAY use all actions internal to the apache/*, github/* and actions/* namespaces without restrictions.
> You MUST pin all external actions to the specific git hash (SHA1) of
I interpret it as saying "actions./*" is "internal" and you don't need to pin to a sha.
While we MAY pin also internal actions, it can be viewed as unnecessary hassle when updating to a newer version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org