You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by neykov <gi...@git.apache.org> on 2017/01/20 17:39:47 UTC
[GitHub] brooklyn-library pull request #88: Add missing @Override annotations and oth...
GitHub user neykov opened a pull request:
https://github.com/apache/brooklyn-library/pull/88
Add missing @Override annotations and other cleanup
Triggered by a refactoring I had to do and missing a bunch of places that needed updating.
* add missing `@Override` annotations
* add missing `@Deprecated` annotations (usually just javadoc `@override` exists)
* remove unused imports
* remove unnecessary casts
Look at each commit individually.
Similar PRs created for the other brooklyn sub-projects.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/neykov/brooklyn-library cleanup
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-library/pull/88.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #88
----
commit 3e0caa7269d64d88a6074b2d5b13955960ca4464
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date: 2017-01-20T10:45:52Z
Add missing @Override annotations
commit 871d23b7f2795305dbb8b38501b9f2cec7759c02
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date: 2017-01-20T14:00:32Z
Add missing @Override annotation to method signatures overriding interface methods
commit 6a8e1721d3927d923ba94638eb17e277c66bc63f
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date: 2017-01-20T14:27:44Z
Remove unused imports
commit adee1b417d45c509d643e22321cd6e25dd839921
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date: 2017-01-20T14:58:18Z
Remove unnecessary casts
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-library issue #88: Add missing @Override annotations and other clea...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the issue:
https://github.com/apache/brooklyn-library/pull/88
Rebased.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-library issue #88: Add missing @Override annotations and other clea...
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-library/pull/88
@neykov could you rebase master once #87 is merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-library issue #88: Add missing @Override annotations and other clea...
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-library/pull/88
Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-library issue #88: Add missing @Override annotations and other clea...
Posted by googlielmo <gi...@git.apache.org>.
Github user googlielmo commented on the issue:
https://github.com/apache/brooklyn-library/pull/88
LGTM once conflict is resolved
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-library issue #88: Add missing @Override annotations and other clea...
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-library/pull/88
Sorry @neykov. Could you rebase once more?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-library issue #88: Add missing @Override annotations and other clea...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the issue:
https://github.com/apache/brooklyn-library/pull/88
Resolved merge conflicts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-library pull request #88: Add missing @Override annotations and oth...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-library/pull/88
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---