You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/09/17 11:20:42 UTC

[GitHub] [accumulo] milleruntime commented on a change in pull request #2274: Make threadpools marked as mutable resizeable

milleruntime commented on a change in pull request #2274:
URL: https://github.com/apache/accumulo/pull/2274#discussion_r710971196



##########
File path: core/src/main/java/org/apache/accumulo/core/util/threads/ThreadPools.java
##########
@@ -58,7 +82,9 @@ public static ExecutorService createExecutorService(AccumuloConfiguration conf,
       case MANAGER_RENAME_THREADS:
         return createFixedThreadPool(conf.getCount(p), "bulk move", false);
       case MANAGER_FATE_THREADPOOL_SIZE:
-        return createFixedThreadPool(conf.getCount(p), "Repo Runner", false);
+        ThreadPoolExecutor pool = createFixedThreadPool(conf.getCount(p), "Repo Runner", false);
+        makeResizeable(pool, conf, p);

Review comment:
       Seems like you could just have one method to create the resizeablePool. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org