You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "drccrd (via GitHub)" <gi...@apache.org> on 2026/06/29 18:17:45 UTC
[PR] [incubator-kie-drools-6781] Resolve kbase-wide globals referenced from another package [incubator-kie-drools]
drccrd opened a new pull request, #6786:
URL: https://github.com/apache/incubator-kie-drools/pull/6786
Fixes: #6781
GlobalDeclarations only collected globals from the current package and from packages imported with a wildcard. A constraint compiled from a different package in the same KieBase therefore could not resolve a global declared elsewhere, unlike the classic compiler where globals are KieBase-wide. Collect globals from every package registry in the KieBase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-drools-6781] Resolve kbase-wide globals referenced from another package [incubator-kie-drools]
Posted by "drccrd (via GitHub)" <gi...@apache.org>.
drccrd commented on code in PR #6786:
URL: https://github.com/apache/incubator-kie-drools/pull/6786#discussion_r3524616975
##########
drools-model/drools-model-codegen/src/main/java/org/drools/model/codegen/execmodel/generator/RuleContext.java:
##########
@@ -316,15 +316,15 @@ public Optional<MethodCallExpr> findBindingExpression( String boundVar ) {
public void addGlobalDeclarations() {
Map<String, java.lang.reflect.Type> globals = getGlobals();
- // also takes globals defined in different packages imported with a wildcard
- packageModel.getImports().stream()
- .filter( imp -> imp.endsWith(".*") )
- .map( imp -> imp.substring(0, imp.length()-2) )
- .map( imp -> typeDeclarationContext.getPackageRegistry(imp) )
+ // Globals are kbase-wide: include globals declared in any package of the kbase, not only
+ // those in the current package or in packages imported with a wildcard. This matches the
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-drools-6781] Resolve kbase-wide globals referenced from another package [incubator-kie-drools]
Posted by "drccrd (via GitHub)" <gi...@apache.org>.
drccrd commented on code in PR #6786:
URL: https://github.com/apache/incubator-kie-drools/pull/6786#discussion_r3524602899
##########
drools-model/drools-model-codegen/src/main/java/org/drools/model/codegen/execmodel/generator/RuleContext.java:
##########
@@ -316,15 +316,15 @@ public Optional<MethodCallExpr> findBindingExpression( String boundVar ) {
public void addGlobalDeclarations() {
Map<String, java.lang.reflect.Type> globals = getGlobals();
- // also takes globals defined in different packages imported with a wildcard
- packageModel.getImports().stream()
- .filter( imp -> imp.endsWith(".*") )
- .map( imp -> imp.substring(0, imp.length()-2) )
- .map( imp -> typeDeclarationContext.getPackageRegistry(imp) )
+ // Globals are kbase-wide: include globals declared in any package of the kbase, not only
+ // those in the current package or in packages imported with a wildcard. This matches the
+ // classic (non-executable-model) behavior where a global is visible from every package, so
+ // a constraint can reference a global declared in another DRL without a wildcard import.
+ typeDeclarationContext.getPackageRegistry().values().stream()
.filter( Objects::nonNull )
- .map( pkgRegistry -> pkgRegistry.getPackage().getGlobals() )
- .forEach( globals::putAll );
-
+ .filter( pkgRegistry -> pkgRegistry.getPackage() != null )
+ .forEach( pkgRegistry -> globals.putAll( pkgRegistry.getPackage().getGlobals() ) );
+
Review Comment:
@tkobayas I added the globals into t a copied variable to prevent mutation - but this to the fact that corss-package globals were no longer accessible - the map mutation was seeding globals across packages. Potentially intnetionally but intransparently.
I added a global seeder in PackageModel. I considered it this was the right choice because it is now alling all globals to all packages - but I couldn't find a better place for it an the nature of globals is that they are available everywhere anyway.
Do you see any problem/improvement?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-drools-6781] Resolve kbase-wide globals referenced from another package [incubator-kie-drools]
Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas commented on code in PR #6786:
URL: https://github.com/apache/incubator-kie-drools/pull/6786#discussion_r3533301363
##########
drools-model/drools-model-codegen/src/main/java/org/drools/model/codegen/execmodel/generator/RuleContext.java:
##########
@@ -316,15 +316,15 @@ public Optional<MethodCallExpr> findBindingExpression( String boundVar ) {
public void addGlobalDeclarations() {
Map<String, java.lang.reflect.Type> globals = getGlobals();
- // also takes globals defined in different packages imported with a wildcard
- packageModel.getImports().stream()
- .filter( imp -> imp.endsWith(".*") )
- .map( imp -> imp.substring(0, imp.length()-2) )
- .map( imp -> typeDeclarationContext.getPackageRegistry(imp) )
+ // Globals are kbase-wide: include globals declared in any package of the kbase, not only
+ // those in the current package or in packages imported with a wildcard. This matches the
+ // classic (non-executable-model) behavior where a global is visible from every package, so
+ // a constraint can reference a global declared in another DRL without a wildcard import.
+ typeDeclarationContext.getPackageRegistry().values().stream()
.filter( Objects::nonNull )
- .map( pkgRegistry -> pkgRegistry.getPackage().getGlobals() )
- .forEach( globals::putAll );
-
+ .filter( pkgRegistry -> pkgRegistry.getPackage() != null )
+ .forEach( pkgRegistry -> globals.putAll( pkgRegistry.getPackage().getGlobals() ) );
+
Review Comment:
Thank you @drccrd . While the global seeder approach works with the test cases, I see that global is conceptually owned by a package (even though viewable kiebase-wide), so for example, removing a package causes a problem. I raised a PR to your branch https://github.com/drccrd/incubator-kie-drools/pull/1 with a different approach (`externalGlobals`). WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-drools-6781] Resolve kbase-wide globals referenced from another package [incubator-kie-drools]
Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas merged PR #6786:
URL: https://github.com/apache/incubator-kie-drools/pull/6786
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-drools-6781] Resolve kbase-wide globals referenced from another package [incubator-kie-drools]
Posted by "drccrd (via GitHub)" <gi...@apache.org>.
drccrd commented on code in PR #6786:
URL: https://github.com/apache/incubator-kie-drools/pull/6786#discussion_r3524617486
##########
drools-model/drools-model-codegen/src/test/java/org/drools/model/codegen/execmodel/DeclaredTypesTest.java:
##########
@@ -599,6 +599,26 @@ public void testExtendPojo(RUN_TYPE runType) throws Exception {
assertThat(ksession.fireAllRules()).isEqualTo(1);
}
+ @ParameterizedTest
+ @MethodSource("parameters")
+ public void testGlobalReferencedInConstraintFromDifferentPackage(RUN_TYPE runType) {
+ // A global declared in one DRL package must be resolvable from a pattern constraint compiled
+ // from a different package in the same KieBase, matching the classic compiler where globals are
+ // KieBase-wide and visible without a wildcard import. Here a BigDecimal global 'threshold' is
+ // declared in com.test.globals and referenced from a Person constraint in com.test.rules.
+ String globalDrl =
+ "package com.test.globals;\n" +
+ "global java.math.BigDecimal threshold;\n";
+ String ruleDrl =
+ "package com.test.rules;\n" +
+ "import " + Person.class.getCanonicalName() + ";\n" +
+ "rule R when\n" +
+ " Person( money.compareTo(threshold) < 0 )\n" +
+ "then end";
+ KieSession ksession = getKieSession(runType, globalDrl, ruleDrl);
+ ksession.fireAllRules();
+ }
Review Comment:
Added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-drools-6781] Resolve kbase-wide globals referenced from another package [incubator-kie-drools]
Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas commented on code in PR #6786:
URL: https://github.com/apache/incubator-kie-drools/pull/6786#discussion_r3496813369
##########
drools-model/drools-model-codegen/src/main/java/org/drools/model/codegen/execmodel/generator/RuleContext.java:
##########
@@ -316,15 +316,15 @@ public Optional<MethodCallExpr> findBindingExpression( String boundVar ) {
public void addGlobalDeclarations() {
Map<String, java.lang.reflect.Type> globals = getGlobals();
- // also takes globals defined in different packages imported with a wildcard
- packageModel.getImports().stream()
- .filter( imp -> imp.endsWith(".*") )
- .map( imp -> imp.substring(0, imp.length()-2) )
- .map( imp -> typeDeclarationContext.getPackageRegistry(imp) )
+ // Globals are kbase-wide: include globals declared in any package of the kbase, not only
+ // those in the current package or in packages imported with a wildcard. This matches the
+ // classic (non-executable-model) behavior where a global is visible from every package, so
+ // a constraint can reference a global declared in another DRL without a wildcard import.
+ typeDeclarationContext.getPackageRegistry().values().stream()
.filter( Objects::nonNull )
- .map( pkgRegistry -> pkgRegistry.getPackage().getGlobals() )
- .forEach( globals::putAll );
-
+ .filter( pkgRegistry -> pkgRegistry.getPackage() != null )
+ .forEach( pkgRegistry -> globals.putAll( pkgRegistry.getPackage().getGlobals() ) );
+
Review Comment:
Plus, the test case would be suitable in `GlobalTest` rather than `DeclaredTypesTest`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-drools-6781] Resolve kbase-wide globals referenced from another package [incubator-kie-drools]
Posted by "drccrd (via GitHub)" <gi...@apache.org>.
drccrd commented on code in PR #6786:
URL: https://github.com/apache/incubator-kie-drools/pull/6786#discussion_r3524602899
##########
drools-model/drools-model-codegen/src/main/java/org/drools/model/codegen/execmodel/generator/RuleContext.java:
##########
@@ -316,15 +316,15 @@ public Optional<MethodCallExpr> findBindingExpression( String boundVar ) {
public void addGlobalDeclarations() {
Map<String, java.lang.reflect.Type> globals = getGlobals();
- // also takes globals defined in different packages imported with a wildcard
- packageModel.getImports().stream()
- .filter( imp -> imp.endsWith(".*") )
- .map( imp -> imp.substring(0, imp.length()-2) )
- .map( imp -> typeDeclarationContext.getPackageRegistry(imp) )
+ // Globals are kbase-wide: include globals declared in any package of the kbase, not only
+ // those in the current package or in packages imported with a wildcard. This matches the
+ // classic (non-executable-model) behavior where a global is visible from every package, so
+ // a constraint can reference a global declared in another DRL without a wildcard import.
+ typeDeclarationContext.getPackageRegistry().values().stream()
.filter( Objects::nonNull )
- .map( pkgRegistry -> pkgRegistry.getPackage().getGlobals() )
- .forEach( globals::putAll );
-
+ .filter( pkgRegistry -> pkgRegistry.getPackage() != null )
+ .forEach( pkgRegistry -> globals.putAll( pkgRegistry.getPackage().getGlobals() ) );
+
Review Comment:
@tkobayas I added the globals into a copied variable to prevent mutation - but this lead to the fact that cross-package globals were no longer accessible - the map mutation was seeding globals across packages. Potentially intentionally but nontransparently.
I added a global seeder in PackageModel. I considered it this was the right choice because it is now adding all globals to all packages - but I couldn't find a better place for it an the nature of globals is that they are available everywhere anyway.
Do you see any problem/improvement?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-drools-6781] Resolve kbase-wide globals referenced from another package [incubator-kie-drools]
Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas commented on code in PR #6786:
URL: https://github.com/apache/incubator-kie-drools/pull/6786#discussion_r3533301363
##########
drools-model/drools-model-codegen/src/main/java/org/drools/model/codegen/execmodel/generator/RuleContext.java:
##########
@@ -316,15 +316,15 @@ public Optional<MethodCallExpr> findBindingExpression( String boundVar ) {
public void addGlobalDeclarations() {
Map<String, java.lang.reflect.Type> globals = getGlobals();
- // also takes globals defined in different packages imported with a wildcard
- packageModel.getImports().stream()
- .filter( imp -> imp.endsWith(".*") )
- .map( imp -> imp.substring(0, imp.length()-2) )
- .map( imp -> typeDeclarationContext.getPackageRegistry(imp) )
+ // Globals are kbase-wide: include globals declared in any package of the kbase, not only
+ // those in the current package or in packages imported with a wildcard. This matches the
+ // classic (non-executable-model) behavior where a global is visible from every package, so
+ // a constraint can reference a global declared in another DRL without a wildcard import.
+ typeDeclarationContext.getPackageRegistry().values().stream()
.filter( Objects::nonNull )
- .map( pkgRegistry -> pkgRegistry.getPackage().getGlobals() )
- .forEach( globals::putAll );
-
+ .filter( pkgRegistry -> pkgRegistry.getPackage() != null )
+ .forEach( pkgRegistry -> globals.putAll( pkgRegistry.getPackage().getGlobals() ) );
+
Review Comment:
Thank you @drccrd . While the global seeder approach works with the test cases, I see that global is conceptually owned by a package, so for example, removing a package causes a problem. I raised a PR to your branch https://github.com/drccrd/incubator-kie-drools/pull/1 with a different approach (`externalGlobals`). WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-drools-6781] Resolve kbase-wide globals referenced from another package [incubator-kie-drools]
Posted by "drccrd (via GitHub)" <gi...@apache.org>.
drccrd commented on code in PR #6786:
URL: https://github.com/apache/incubator-kie-drools/pull/6786#discussion_r3524602899
##########
drools-model/drools-model-codegen/src/main/java/org/drools/model/codegen/execmodel/generator/RuleContext.java:
##########
@@ -316,15 +316,15 @@ public Optional<MethodCallExpr> findBindingExpression( String boundVar ) {
public void addGlobalDeclarations() {
Map<String, java.lang.reflect.Type> globals = getGlobals();
- // also takes globals defined in different packages imported with a wildcard
- packageModel.getImports().stream()
- .filter( imp -> imp.endsWith(".*") )
- .map( imp -> imp.substring(0, imp.length()-2) )
- .map( imp -> typeDeclarationContext.getPackageRegistry(imp) )
+ // Globals are kbase-wide: include globals declared in any package of the kbase, not only
+ // those in the current package or in packages imported with a wildcard. This matches the
+ // classic (non-executable-model) behavior where a global is visible from every package, so
+ // a constraint can reference a global declared in another DRL without a wildcard import.
+ typeDeclarationContext.getPackageRegistry().values().stream()
.filter( Objects::nonNull )
- .map( pkgRegistry -> pkgRegistry.getPackage().getGlobals() )
- .forEach( globals::putAll );
-
+ .filter( pkgRegistry -> pkgRegistry.getPackage() != null )
+ .forEach( pkgRegistry -> globals.putAll( pkgRegistry.getPackage().getGlobals() ) );
+
Review Comment:
@tkobayas I added the globals into t a copied variable to prevent mutation - but this to the fact that cross-package globals were no longer accessible - the map mutation was seeding globals across packages. Potentially intentionally but nontransparently.
I added a global seeder in PackageModel. I considered it this was the right choice because it is now adding all globals to all packages - but I couldn't find a better place for it an the nature of globals is that they are available everywhere anyway.
Do you see any problem/improvement?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-drools-6781] Resolve kbase-wide globals referenced from another package [incubator-kie-drools]
Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas commented on code in PR #6786:
URL: https://github.com/apache/incubator-kie-drools/pull/6786#discussion_r3496775270
##########
drools-model/drools-model-codegen/src/main/java/org/drools/model/codegen/execmodel/generator/RuleContext.java:
##########
@@ -316,15 +316,15 @@ public Optional<MethodCallExpr> findBindingExpression( String boundVar ) {
public void addGlobalDeclarations() {
Map<String, java.lang.reflect.Type> globals = getGlobals();
- // also takes globals defined in different packages imported with a wildcard
- packageModel.getImports().stream()
- .filter( imp -> imp.endsWith(".*") )
- .map( imp -> imp.substring(0, imp.length()-2) )
- .map( imp -> typeDeclarationContext.getPackageRegistry(imp) )
+ // Globals are kbase-wide: include globals declared in any package of the kbase, not only
+ // those in the current package or in packages imported with a wildcard. This matches the
+ // classic (non-executable-model) behavior where a global is visible from every package, so
+ // a constraint can reference a global declared in another DRL without a wildcard import.
+ typeDeclarationContext.getPackageRegistry().values().stream()
.filter( Objects::nonNull )
- .map( pkgRegistry -> pkgRegistry.getPackage().getGlobals() )
- .forEach( globals::putAll );
-
+ .filter( pkgRegistry -> pkgRegistry.getPackage() != null )
+ .forEach( pkgRegistry -> globals.putAll( pkgRegistry.getPackage().getGlobals() ) );
+
Review Comment:
Thank you for this PR, @drccrd
"`addGlobalDeclarations()` mutates the Map returned by `RuleContext.getGlobals()`" is a pre-existing bug. It would be great if you could also address it as Copilot suggested by making `RuleContext.getGlobals()` return a defensive copy built from `typeDeclarationContext.getGlobals()` plus unit-specific entries. This ensures that `RuleContext.getGlobals()` consistently exposes KieBase-wide globals across all its callers, while also avoiding the scanning since `typeDeclarationContext.getGlobals()` already contains the KieBase-wide globals.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-drools-6781] Resolve kbase-wide globals referenced from another package [incubator-kie-drools]
Posted by "drccrd (via GitHub)" <gi...@apache.org>.
drccrd commented on code in PR #6786:
URL: https://github.com/apache/incubator-kie-drools/pull/6786#discussion_r3543909752
##########
drools-model/drools-model-codegen/src/main/java/org/drools/model/codegen/execmodel/generator/RuleContext.java:
##########
@@ -316,15 +316,15 @@ public Optional<MethodCallExpr> findBindingExpression( String boundVar ) {
public void addGlobalDeclarations() {
Map<String, java.lang.reflect.Type> globals = getGlobals();
- // also takes globals defined in different packages imported with a wildcard
- packageModel.getImports().stream()
- .filter( imp -> imp.endsWith(".*") )
- .map( imp -> imp.substring(0, imp.length()-2) )
- .map( imp -> typeDeclarationContext.getPackageRegistry(imp) )
+ // Globals are kbase-wide: include globals declared in any package of the kbase, not only
+ // those in the current package or in packages imported with a wildcard. This matches the
+ // classic (non-executable-model) behavior where a global is visible from every package, so
+ // a constraint can reference a global declared in another DRL without a wildcard import.
+ typeDeclarationContext.getPackageRegistry().values().stream()
.filter( Objects::nonNull )
- .map( pkgRegistry -> pkgRegistry.getPackage().getGlobals() )
- .forEach( globals::putAll );
-
+ .filter( pkgRegistry -> pkgRegistry.getPackage() != null )
+ .forEach( pkgRegistry -> globals.putAll( pkgRegistry.getPackage().getGlobals() ) );
+
Review Comment:
@tkobayas great addition - I had tried to find existing methods for ownership and not point it, but adding the feature is helpful (I have also been considering something similar for functions - we have a number functions across packages that need re-declaration (or else get moved into a static method of a java class) - something like this would partly help in that area too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org