You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Konstantin Shvachko (JIRA)" <ji...@apache.org> on 2011/02/01 00:01:29 UTC
[jira] Commented: (MAPREDUCE-2026) JobTracker.getJobCounters()
should not hold JobTracker lock while calling JobInProgress.getCounters()
[ https://issues.apache.org/jira/browse/MAPREDUCE-2026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12988942#comment-12988942 ]
Konstantin Shvachko commented on MAPREDUCE-2026:
------------------------------------------------
Scot, Joydeep. This seems to be an important fix for 0.22. Do you think it is ready to be committed?
> JobTracker.getJobCounters() should not hold JobTracker lock while calling JobInProgress.getCounters()
> -----------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2026
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2026
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Scott Chen
> Assignee: Joydeep Sen Sarma
> Attachments: 2026.1.patch, MAPREDUCE-2026.txt
>
>
> JobTracker.getJobCounter() will lock JobTracker and call JobInProgress.getCounters().
> JobInProgress.getCounters() can be very expensive because it aggregates all the task counters.
> We found that from the JobTracker jstacks that this method is one of the bottleneck of the JobTracker performance.
> JobInProgress.getCounters() should be able to be called out side the JobTracker lock because it already has JobInProgress lock.
> For example, it is used by jobdetails.jsp without a JobTracker lock.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira