You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cayenne.apache.org by aa...@apache.org on 2015/05/03 13:31:04 UTC

[2/2] cayenne git commit: comments on type correctness

comments on type correctness


Project: http://git-wip-us.apache.org/repos/asf/cayenne/repo
Commit: http://git-wip-us.apache.org/repos/asf/cayenne/commit/99b28283
Tree: http://git-wip-us.apache.org/repos/asf/cayenne/tree/99b28283
Diff: http://git-wip-us.apache.org/repos/asf/cayenne/diff/99b28283

Branch: refs/heads/master
Commit: 99b282838bd2b59b28c1a4ab8403827cbf3512cd
Parents: e784c10
Author: aadamchik <aa...@apache.org>
Authored: Sun May 3 07:30:55 2015 -0400
Committer: aadamchik <aa...@apache.org>
Committed: Sun May 3 07:30:55 2015 -0400

----------------------------------------------------------------------
 .../test/java/org/apache/cayenne/velocity/ResultDirectiveIT.java  | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cayenne/blob/99b28283/cayenne-server/src/test/java/org/apache/cayenne/velocity/ResultDirectiveIT.java
----------------------------------------------------------------------
diff --git a/cayenne-server/src/test/java/org/apache/cayenne/velocity/ResultDirectiveIT.java b/cayenne-server/src/test/java/org/apache/cayenne/velocity/ResultDirectiveIT.java
index 71e94f2..38ac675 100644
--- a/cayenne-server/src/test/java/org/apache/cayenne/velocity/ResultDirectiveIT.java
+++ b/cayenne-server/src/test/java/org/apache/cayenne/velocity/ResultDirectiveIT.java
@@ -49,7 +49,6 @@ public class ResultDirectiveIT extends ServerCase {
 	@Inject
 	private ServerRuntime runtime;
 
-
 	@Inject
 	protected DBHelper dbHelper;
 
@@ -73,6 +72,8 @@ public class ResultDirectiveIT extends ServerCase {
 				+ " FROM ARTIST";
 		Map<String, Object> selectResult = selectForQuery(sql);
 
+		// TODO: is that correct to use Long (coming from DbAttribute) type for
+		// ARTIST_ID instead of Integer (coming from #result(..))?
 		assertEquals(1l, selectResult.get("ARTIST_ID"));
 		assertEquals("ArtistToTestResult", selectResult.get("ARTIST_NAME").toString().trim());
 	}