You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by GitBox <gi...@apache.org> on 2022/06/16 00:43:49 UTC

[GitHub] [cxf] naveensrinivasan opened a new pull request, #956: chore: Set permissions for GitHub actions

naveensrinivasan opened a new pull request, #956:
URL: https://github.com/apache/cxf/pull/956

    Restrict the GitHub token permissions only to the required ones; this way, even if the attackers will succeed in compromising your workflow, they won’t be able to do much.
   
   - Included permissions for the action. https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions
   
   https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#permissions
   
   https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs
   
   [Keeping your GitHub Actions and workflows secure Part 1: Preventing pwn requests](https://securitylab.github.com/research/github-actions-preventing-pwn-requests/)
   
   Signed-off-by: naveen <17...@users.noreply.github.com>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cxf] coheigea merged pull request #956: chore: Set permissions for GitHub actions

Posted by GitBox <gi...@apache.org>.
coheigea merged PR #956:
URL: https://github.com/apache/cxf/pull/956


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cxf] reta commented on a diff in pull request #956: chore: Set permissions for GitHub actions

Posted by GitBox <gi...@apache.org>.
reta commented on code in PR #956:
URL: https://github.com/apache/cxf/pull/956#discussion_r899683453


##########
.github/workflows/codeql-analysis.yml:
##########
@@ -14,8 +14,15 @@ on:
   #schedule:
     #- cron: '0 18 * * 5'
 
+permissions:
+  contents: read
+
 jobs:
   analyze:
+    permissions:
+      actions: read  # for github/codeql-action/init to get workflow details
+      contents: read  # for actions/checkout to fetch code
+      security-events: write  # for github/codeql-action/analyze to upload SARIF results

Review Comment:
   https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/configuring-code-scanning



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cxf] reta commented on pull request #956: chore: Set permissions for GitHub actions

Posted by GitBox <gi...@apache.org>.
reta commented on PR #956:
URL: https://github.com/apache/cxf/pull/956#issuecomment-1158396574

   thank you @naveensrinivasan , LGTM, @coheigea any objections?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org