[GitHub] [spark] viirya commented on a diff in pull request #43134: [SPARK-45346][SQL] Parquet schema inference should respect case sensitive flag when merging schema

["viirya (via GitHub)" <gi...@apache.org>]

viirya commented on code in PR #43134:
URL: https://github.com/apache/spark/pull/43134#discussion_r1337912115


##########
sql/api/src/main/scala/org/apache/spark/sql/types/StructType.scala:
##########
@@ -476,8 +478,8 @@ case class StructType(fields: Array[StructField]) extends DataType with Seq[Stru
    * 4. Otherwise, `this` and `that` are considered as conflicting schemas and an exception would be
    *    thrown.
    */
-  private[sql] def merge(that: StructType): StructType =
-    StructType.merge(this, that).asInstanceOf[StructType]
+  private[sql] def merge(that: StructType, caseSensitive: Boolean = true): StructType =

Review Comment:
   `spark.sql.caseSensitive` is false by default, maybe we should have false as default here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org