You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "JosiahWI (via GitHub)" <gi...@apache.org> on 2024/06/07 11:50:58 UTC
[PR] Observe cache_config_agg_write_backlog [trafficserver]
JosiahWI opened a new pull request, #10991:
URL: https://github.com/apache/trafficserver/pull/10991
The global `cache_config_agg_write_backlog` is defined as `2 * AGG_SIZE`. There was an extra `+ AGG_SIZE` in `add_writer` with no comment; this goes back all the way to the original first GitHub commit. This could be a quick hack someone put in to fix an issue. If we need to avoid changing this, I'd like to add a comment explaining what I learned about it. There is another place in the code where `cache_config_agg_write_backlog` is used, in `Stripe::open_write`, and in that place there is no extra `+ AGG_SIZE`. Maybe the `+ AGG_SIZE` is missing in the other place and should be added, but in that case, I think it would make more sense to just define `cache_config_agg_write_backlog` as `3 * AGG_SIZE`. This is why I think it was intended to be used without the extra `+ AGG_SIZE`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Observe cache_config_agg_write_backlog [trafficserver]
Posted by "masaori335 (via GitHub)" <gi...@apache.org>.
masaori335 commented on PR #10991:
URL: https://github.com/apache/trafficserver/pull/10991#issuecomment-1914009580
FWIW, `cache_config_agg_write_backlog` is configured by `proxy.config.cache.agg_write_backlog` and the default value is `5242880` (=5MB) and the `AGG_SIZE` is 4MB. Thus, `Stripe::open_write` is using 5MB and `Stripe::add_writer` is using 9MB in the current code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Observe cache_config_agg_write_backlog [trafficserver]
Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on PR #10991:
URL: https://github.com/apache/trafficserver/pull/10991#issuecomment-2155011541
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Observe cache_config_agg_write_backlog [trafficserver]
Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on PR #10991:
URL: https://github.com/apache/trafficserver/pull/10991#issuecomment-2154680480
Rebased on master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Clarify cache_config_agg_write_backlog [trafficserver]
Posted by "bryancall (via GitHub)" <gi...@apache.org>.
bryancall commented on code in PR #10991:
URL: https://github.com/apache/trafficserver/pull/10991#discussion_r1631539685
##########
src/iocore/cache/Stripe.cc:
##########
@@ -934,6 +934,15 @@ Stripe::add_writer(CacheVC *vc)
{
ink_assert(vc);
this->_write_buffer.add_bytes_pending_aggregation(vc->agg_len);
+ // [jv] An extra AGG_SIZE is added to the backlog here, but not in
Review Comment:
Please remove your name in the comment. We have that information in the commit history and try not to have peoples names in the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Observe cache_config_agg_write_backlog [trafficserver]
Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on PR #10991:
URL: https://github.com/apache/trafficserver/pull/10991#issuecomment-2154736431
The AuTest proxy_serve_stale_dns_fail failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Observe cache_config_agg_write_backlog [trafficserver]
Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on PR #10991:
URL: https://github.com/apache/trafficserver/pull/10991#issuecomment-2154951295
The AuTest ja3_fingerprint failed. I saved the log and I think I have identified the cause as a race condition in the state machine logging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Observe cache_config_agg_write_backlog [trafficserver]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10991:
URL: https://github.com/apache/trafficserver/pull/10991#issuecomment-2081768024
This pull request has been automatically marked as stale because it has not had recent activity. Marking it stale to flag it for further consideration by the community.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Observe cache_config_agg_write_backlog [trafficserver]
Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on PR #10991:
URL: https://github.com/apache/trafficserver/pull/10991#issuecomment-2154951501
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Observe cache_config_agg_write_backlog [trafficserver]
Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on PR #10991:
URL: https://github.com/apache/trafficserver/pull/10991#issuecomment-2155011312
The AuTest notexistscookie failed.
```
server2/stream.all.txt matches gold/existscookie.gold - Failed
Reason: File differences
Gold File : /home/jenkins/workspace/Github_Builds/autest/src/tests/gold_tests/pluginTest/cookie_remap/gold/existscookie.gold
Data File : /tmp/sandbox/notexistscookie/_output/notexistscookie-server2/stream.all.txt
Traceback (most recent call last):
- Serving GET /cookieexists... Finished
+ File "/home/jenkins/.local/share/virtualenvs/tests-twZplwXB/bin/microserver", line 8, in <module>
+ size 2
+ Dropped 0 sessions for being malformed
sys.exit(main())
^^^^^^
File "/home/jenkins/.local/share/virtualenvs/tests-twZplwXB/lib/python3.12/site-packages/microserver/__main__.py", line 128, in main
server = microserver.MicroServer(args.data_dir, ip=args.ip_address, port=args.port, s_port=args.s_port, delay=args.delay,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/jenkins/.local/share/virtualenvs/tests-twZplwXB/lib/python3.12/site-packages/microserver/microserver.py", line 130, in __init__
self.servers.append(ThreadingServer(
^^^^^^^^^^^^^^^^
File "/home/jenkins/.local/share/virtualenvs/tests-twZplwXB/lib/python3.12/site-packages/microserver/servers.py", line 51, in __init__
HTTPServer.__init__(self, local_addr, handler_class)
File "/usr/lib64/python3.12/socketserver.py", line 458, in __init__
self.server_activate()
File "/usr/lib64/python3.12/socketserver.py", line 476, in server_activate
def server_activate(self):
KeyboardInterrupt
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Observe cache_config_agg_write_backlog [trafficserver]
Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on PR #10991:
URL: https://github.com/apache/trafficserver/pull/10991#issuecomment-2154736617
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Clarify cache_config_agg_write_backlog [trafficserver]
Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI merged PR #10991:
URL: https://github.com/apache/trafficserver/pull/10991
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Observe cache_config_agg_write_backlog [trafficserver]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #10991: Observe cache_config_agg_write_backlog
URL: https://github.com/apache/trafficserver/pull/10991
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Clarify cache_config_agg_write_backlog [trafficserver]
Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on PR #10991:
URL: https://github.com/apache/trafficserver/pull/10991#issuecomment-2155121793
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org