[GitHub] [kyuubi] risyomei commented on pull request #4480: Close the thrift connection of KyuubiServer when backend engine is determined as dead by EngineAliveProbe

["risyomei (via GitHub)" <gi...@apache.org>]

risyomei commented on PR #4480:
URL: https://github.com/apache/kyuubi/pull/4480#issuecomment-1459892916

   > I think the new config makes sense and the flow should be:
   > 
   > 1. the engine alive probe client has broken
   > 2. the engine alive probe thread should close **both engine alive probe client and the real Kyuubi client**
   > 3. mark the `KyuubiSyncThriftClient` is closed
   > 4. then operation will call `KyuubiSyncThriftClient.close` again since we would throw exception when cloing client, so we should check and skip if it is closed to avoid unnecessary exception
   
   @ulysses-you
   
   Thank you for your comment. 
   I understand that your suggestion is to minimize the number of exceptions thrown by closing all clients. 
   I will attempt to implement the logic you mentioned.
   
   Just to clarify, could you please kindly elaborate on what you mean by...
   >  3. mark the `KyuubiSyncThriftClient` is closed
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org