You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2015/10/16 18:43:42 UTC

Review Request 39398: Sync TaskStatus::Reason enumerations in v1 API.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39398/
-----------------------------------------------------------

Review request for mesos, Artem Harutyunyan, Jie Yu, and Joris Van Remoortere.


Repository: mesos


Description
-------

The changes originate from: https://reviews.apache.org/r/38746


Diffs
-----

  include/mesos/v1/mesos.proto 0ac8aa6988908fb8fbf274eddaf82f32d2eeaff4 

Diff: https://reviews.apache.org/r/39398/diff/


Testing
-------

`make check`


Thanks,

Joseph Wu


Re: Review Request 39398: Sync TaskStatus::Reason enumerations in v1 API.

Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39398/#review103029
-----------------------------------------------------------

Ship it!


Ship It!

- Joris Van Remoortere


On Oct. 16, 2015, 4:43 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39398/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2015, 4:43 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The changes originate from: https://reviews.apache.org/r/38746
> 
> 
> Diffs
> -----
> 
>   include/mesos/v1/mesos.proto 0ac8aa6988908fb8fbf274eddaf82f32d2eeaff4 
> 
> Diff: https://reviews.apache.org/r/39398/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Re: Review Request 39398: Sync TaskStatus::Reason enumerations in v1 API.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39398/#review103016
-----------------------------------------------------------

Ship it!


Ship It!

- Guangya Liu


On 十月 16, 2015, 4:43 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39398/
> -----------------------------------------------------------
> 
> (Updated 十月 16, 2015, 4:43 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The changes originate from: https://reviews.apache.org/r/38746
> 
> 
> Diffs
> -----
> 
>   include/mesos/v1/mesos.proto 0ac8aa6988908fb8fbf274eddaf82f32d2eeaff4 
> 
> Diff: https://reviews.apache.org/r/39398/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Re: Review Request 39398: Sync TaskStatus::Reason enumerations in v1 API.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39398/#review102940
-----------------------------------------------------------


Patch looks great!

Reviews applied: [39398]

All tests passed.

- Mesos ReviewBot


On Oct. 16, 2015, 4:43 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39398/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2015, 4:43 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The changes originate from: https://reviews.apache.org/r/38746
> 
> 
> Diffs
> -----
> 
>   include/mesos/v1/mesos.proto 0ac8aa6988908fb8fbf274eddaf82f32d2eeaff4 
> 
> Diff: https://reviews.apache.org/r/39398/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>