You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "crossoverJie (via GitHub)" <gi...@apache.org> on 2023/03/21 06:39:18 UTC

[GitHub] [pulsar] crossoverJie opened a new pull request, #19871: [fix][client] Fix typo in ConsumerStats

crossoverJie opened a new pull request, #19871:
URL: https://github.com/apache/pulsar/pull/19871

   
   ### Motivation
   
   This is a minor typo fix.
   
   
   ### Modifications
   `getTotaBatchReceivedFailed`-> `getTotalBatchReceivedFailed`
   
   ### Does this pull request potentially affect one of the following parts:
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   *If the box was checked, please highlight the changes*
   
   - [ ] Dependencies (add or upgrade a dependency)
   - [x] The public API
   - [ ] The schema
   - [ ] The default values of configurations
   - [ ] The threading model
   - [ ] The binary protocol
   - [ ] The REST endpoints
   - [ ] The admin CLI options
   - [ ] The metrics
   - [ ] Anything that affects deployment
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [x] `doc` <!-- Your PR contains doc changes. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun commented on a diff in pull request #19871: [fix][client] Fix typo in ConsumerStats

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #19871:
URL: https://github.com/apache/pulsar/pull/19871#discussion_r1142947002


##########
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ConsumerStats.java:
##########
@@ -92,7 +92,7 @@ public interface ConsumerStats extends Serializable {
     /**
      * @return Total number of messages batch receive failures
      */
-    long getTotaBatchReceivedFailed();
+    long getTotalBatchReceivedFailed();

Review Comment:
   I'm afraid that this is a breaking change (to public API), so we cannot change it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun commented on a diff in pull request #19871: [fix][client] Fix typo in ConsumerStats

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #19871:
URL: https://github.com/apache/pulsar/pull/19871#discussion_r1142947002


##########
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ConsumerStats.java:
##########
@@ -92,7 +92,7 @@ public interface ConsumerStats extends Serializable {
     /**
      * @return Total number of messages batch receive failures
      */
-    long getTotaBatchReceivedFailed();
+    long getTotalBatchReceivedFailed();

Review Comment:
   I'm afraid that this is a breaking change so we cannot change it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] crossoverJie closed pull request #19871: [fix][client] Fix typo in ConsumerStats

Posted by "crossoverJie (via GitHub)" <gi...@apache.org>.
crossoverJie closed pull request #19871: [fix][client] Fix typo in ConsumerStats
URL: https://github.com/apache/pulsar/pull/19871


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org