You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by paul-rogers <gi...@git.apache.org> on 2017/02/12 23:34:01 UTC
[GitHub] drill pull request #746: Drill 5254: Enhance default reduction factors in op...
GitHub user paul-rogers opened a pull request:
https://github.com/apache/drill/pull/746
Drill 5254: Enhance default reduction factors in optimizer
Provides enhanced default selectivity rules as defined in DRILL-5254. Please see the JIRA entry for the details.
The rules are selectable with a boot-time option and are disabled by default to allow full testing of the rules before they become enabled by default.
Also provides a complete unit test. The test required enhancements to the new test framework; those enhancements are also included.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/paul-rogers/drill DRILL-5254
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/746.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #746
----
commit 62edc37fcb4034fed6f502b34e20923b7b6e5e75
Author: Paul Rogers <pr...@maprtech.com>
Date: 2017-02-12T23:25:02Z
Feature implementation
Provides enhanced default selectivity rules as defined in DRILL-5254.
The rules are selectable with a boot-time option and are disabled by
default to allow full testing of the rules before they become enabled
for all.
commit 66c59a2fc535e668599bb40765074ee7d6000aa9
Author: Paul Rogers <pr...@maprtech.com>
Date: 2017-02-12T23:31:37Z
Unit tests and supporting code
Provides unit tests for the feature.
Required adding a boolean field type to the mock data source.
This test relies on saving query profiles and analyzing them to detect
selectivity. However, the CTTAS feature introduced a check that causes
tests to fail if they save query profiles for analysis. Provides a
workaround in the test framework to delete the locally stored files
before each test that will preserve local state.
Added comments to several test methods.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request #746: DRILL-5254: Enhance default reduction factors in op...
Posted by paul-rogers <gi...@git.apache.org>.
Github user paul-rogers closed the pull request at:
https://github.com/apache/drill/pull/746
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request #746: DRILL-5254: Enhance default reduction factors in op...
Posted by jinfengni <gi...@git.apache.org>.
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/746#discussion_r101128365
--- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
@@ -91,7 +91,22 @@ drill.exec: {
use.ip : false
},
optimizer: {
- implementation: "org.apache.drill.exec.opt.IdentityOptimizer"
+ implementation: "org.apache.drill.exec.opt.IdentityOptimizer",
+ enhanced_defaults: {
--- End diff --
You may pass in a difference instance of DrillDefaultRelMetaDataProvider, based on context.getPlannerSetting().
https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DefaultSqlHandler.java#L382
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request #746: DRILL-5254: Enhance default reduction factors in op...
Posted by paul-rogers <gi...@git.apache.org>.
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/746#discussion_r101121530
--- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
@@ -91,7 +91,22 @@ drill.exec: {
use.ip : false
},
optimizer: {
- implementation: "org.apache.drill.exec.opt.IdentityOptimizer"
+ implementation: "org.apache.drill.exec.opt.IdentityOptimizer",
+ enhanced_defaults: {
--- End diff --
Could not work out, in the limited time available, how to pass a system option (which can change at runtime) into the default rules (which appears to not have visibility to the query context.)
Any suggestions for how to pass along the query context so we can get at the runtime options?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill issue #746: DRILL-5254: Enhance default reduction factors in optimizer
Posted by paul-rogers <gi...@git.apache.org>.
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/746
Community asks this not be in Drill but rather offered to Calcite.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request #746: DRILL-5254: Enhance default reduction factors in op...
Posted by jinfengni <gi...@git.apache.org>.
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/746#discussion_r101117331
--- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
@@ -91,7 +91,22 @@ drill.exec: {
use.ip : false
},
optimizer: {
- implementation: "org.apache.drill.exec.opt.IdentityOptimizer"
+ implementation: "org.apache.drill.exec.opt.IdentityOptimizer",
+ enhanced_defaults: {
--- End diff --
Any particular reason why you make this option as boot-time option, in stead of system option? Majority planner options, if not all, are able to reset either at system or session level. That will give the user option for better control.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---