You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "stevedlawrence (via GitHub)" <gi...@apache.org> on 2023/02/02 20:16:33 UTC
[GitHub] [daffodil] stevedlawrence commented on a diff in pull request #947: Add scalafmt (WIP)
stevedlawrence commented on code in PR #947:
URL: https://github.com/apache/daffodil/pull/947#discussion_r1095035023
##########
daffodil-cli/src/main/scala/org/apache/daffodil/InfosetTypes.scala:
##########
@@ -108,22 +108,22 @@ object InfosetType extends Enumeration {
forPerformance: Boolean): InfosetHandler = {
infosetType match {
- case InfosetType.EXI => EXIInfosetHandler(dataProcessor)
- case InfosetType.EXISA => EXIInfosetHandler(dataProcessor, schemaUri.get)
- case InfosetType.JDOM => JDOMInfosetHandler(dataProcessor)
- case InfosetType.JSON => JsonInfosetHandler(dataProcessor)
- case InfosetType.NULL => NULLInfosetHandler(dataProcessor)
- case InfosetType.SAX => SAXInfosetHandler(dataProcessor, forPerformance)
+ case InfosetType.EXI => EXIInfosetHandler(dataProcessor)
+ case InfosetType.EXISA => EXIInfosetHandler(dataProcessor, schemaUri.get)
+ case InfosetType.JDOM => JDOMInfosetHandler(dataProcessor)
+ case InfosetType.JSON => JsonInfosetHandler(dataProcessor)
+ case InfosetType.NULL => NULLInfosetHandler(dataProcessor)
+ case InfosetType.SAX => SAXInfosetHandler(dataProcessor, forPerformance)
case InfosetType.SCALA_XML => ScalaXMLInfosetHandler(dataProcessor)
- case InfosetType.W3CDOM => W3CDOMInfosetHandler(dataProcessor)
- case InfosetType.XML => XMLTextInfosetHandler(dataProcessor)
+ case InfosetType.W3CDOM => W3CDOMInfosetHandler(dataProcessor)
+ case InfosetType.XML => XMLTextInfosetHandler(dataProcessor)
Review Comment:
Are there an opinions on this kind of alignment? I tend to not like becaause if we add a new longer case we have to reindent the whole thing and it makes the diff harder to see what actually changed.
##########
daffodil-cli/src/main/scala/org/apache/daffodil/InfosetTypes.scala:
##########
@@ -358,7 +356,7 @@ case class JDOMInfosetHandler(dataProcessor: DataProcessor)
}
class JDOMInfosetParseResult(parseResult: ParseResult, output: JDOMInfosetOutputter)
- extends InfosetParseResult(parseResult) {
+ extends InfosetParseResult(parseResult) {
Review Comment:
This is interesting indenting extends 4 spaces instead of 2. Maybe that's a scala standard but I don't think we've been doing that. Not sure what the preference here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org