[GitHub] [spark] yangwwei edited a comment on pull request #35663: [SPARK-37809][K8S] Add yunikorn feature step

[GitBox <gi...@apache.org>]

yangwwei edited a comment on pull request #35663:
URL: https://github.com/apache/spark/pull/35663#issuecomment-1055993657


   For the scheduler name, that's fine. In this PR, the addition is we need to add this:
   
   > addToAnnotations(YuniKornFeatureStep.AppIdAnnotationKey, kubernetesConf.appId)
   
   this is needed in order to let yunikorn know which pods belong to which job. Otherwise, it won't be able to be scheduled. In the next PR for queue-related configs, I will add some other logic to load the queue configs from conf and add that to the pod annotation. 
   
   PS: Updated the description to include some more details why we need this. Hope this makes sense.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org