You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/06/29 15:09:09 UTC
[GitHub] [incubator-eventmesh] ruanwenjun opened a new pull request, #976: [MINOR] Use Apache release rather than Github release in README
ruanwenjun opened a new pull request, #976:
URL: https://github.com/apache/incubator-eventmesh/pull/976
### Motivation
* Using apache release link in doc
### Modifications
*Describe the modifications you've done.*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 commented on a diff in pull request #976: [MINOR] Use Apache release rather than Github release in README
Posted by GitBox <gi...@apache.org>.
xwm1992 commented on code in PR #976:
URL: https://github.com/apache/incubator-eventmesh/pull/976#discussion_r914344526
##########
docs/en/installation/01-runtime.md:
##########
@@ -40,20 +40,21 @@ bash bin/start.sh
Gradle is the build automation tool used by Apache EventMesh (Incubating). Please refer to the [offical guide](https://docs.gradle.org/current/userguide/installation.html) to install the latest release of Gradle.
-Download and extract the source code of the latest release (v1.4.0) from [GitHub releases](https://github.com/apache/incubator-eventmesh/releases).
+Download and extract the source code of the latest release from [EventMesh download](https://eventmesh.apache.org/download).
```console
-wget https://github.com/apache/incubator-eventmesh/archive/refs/tags/v1.4.0.tar.gz
+wget https://dlcdn.apache.org/incubator/eventmesh/1.4.0-incubating/apache-eventmesh-{version}-source.tar.gz
-tar -xvzf v1.4.0.tar.gz
+tar -xvzf apache-eventmesh-{version}-source.tar.gz
Review Comment:
change apache-eventmesh-{version}-source.tar.gz -> apache-eventmesh-{version}-incubating-source.tar.gz
##########
docs/en/installation/01-runtime.md:
##########
@@ -40,20 +40,21 @@ bash bin/start.sh
Gradle is the build automation tool used by Apache EventMesh (Incubating). Please refer to the [offical guide](https://docs.gradle.org/current/userguide/installation.html) to install the latest release of Gradle.
-Download and extract the source code of the latest release (v1.4.0) from [GitHub releases](https://github.com/apache/incubator-eventmesh/releases).
+Download and extract the source code of the latest release from [EventMesh download](https://eventmesh.apache.org/download).
```console
-wget https://github.com/apache/incubator-eventmesh/archive/refs/tags/v1.4.0.tar.gz
+wget https://dlcdn.apache.org/incubator/eventmesh/1.4.0-incubating/apache-eventmesh-{version}-source.tar.gz
Review Comment:
please change this to https://dlcdn.apache.org/incubator/eventmesh/{version}-incubating/apache-eventmesh-{version}-incubating-source.tar.gz
##########
docs/en/installation/01-runtime.md:
##########
@@ -40,20 +40,21 @@ bash bin/start.sh
Gradle is the build automation tool used by Apache EventMesh (Incubating). Please refer to the [offical guide](https://docs.gradle.org/current/userguide/installation.html) to install the latest release of Gradle.
-Download and extract the source code of the latest release (v1.4.0) from [GitHub releases](https://github.com/apache/incubator-eventmesh/releases).
+Download and extract the source code of the latest release from [EventMesh download](https://eventmesh.apache.org/download).
```console
-wget https://github.com/apache/incubator-eventmesh/archive/refs/tags/v1.4.0.tar.gz
+wget https://dlcdn.apache.org/incubator/eventmesh/1.4.0-incubating/apache-eventmesh-{version}-source.tar.gz
-tar -xvzf v1.4.0.tar.gz
+tar -xvzf apache-eventmesh-{version}-source.tar.gz
```
Build the source code with Gradle.
```console
-cd incubator-eventmesh-1.4.0
-gradle clean build
+cd apache-eventmesh-{version}-source
Review Comment:
change apache-eventmesh-{version}-source -> apache-eventmesh-{version}-incubating-source
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 merged pull request #976: [MINOR] Use Apache release rather than Github release in README
Posted by GitBox <gi...@apache.org>.
xwm1992 merged PR #976:
URL: https://github.com/apache/incubator-eventmesh/pull/976
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov[bot] commented on pull request #976: [MINOR] Use Apache release rather than Github release in README
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #976:
URL: https://github.com/apache/incubator-eventmesh/pull/976#issuecomment-1170165598
# [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/976?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#976](https://codecov.io/gh/apache/incubator-eventmesh/pull/976?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6d37e43) into [master](https://codecov.io/gh/apache/incubator-eventmesh/commit/dab10863a82a1828ea2e44b164086a1427abd8a3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dab1086) will **decrease** coverage by `0.09%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #976 +/- ##
===========================================
- Coverage 8.42% 8.33% -0.10%
+ Complexity 534 527 -7
===========================================
Files 362 362
Lines 23228 23228
Branches 2546 2546
===========================================
- Hits 1958 1937 -21
- Misses 21118 21139 +21
Partials 152 152
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/976?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...tandalone/broker/task/HistoryMessageClearTask.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/976/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvYnJva2VyL3Rhc2svSGlzdG9yeU1lc3NhZ2VDbGVhclRhc2suamF2YQ==) | `29.41% <0.00%> (-29.42%)` | :arrow_down: |
| [...mesh/connector/standalone/broker/MessageQueue.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/976/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvYnJva2VyL01lc3NhZ2VRdWV1ZS5qYXZh) | `32.46% <0.00%> (-7.80%)` | :arrow_down: |
| [...ava/org/apache/eventmesh/common/utils/IPUtils.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/976/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi91dGlscy9JUFV0aWxzLmphdmE=) | `33.33% <0.00%> (-6.49%)` | :arrow_down: |
| [...nnector/standalone/broker/model/MessageEntity.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/976/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvYnJva2VyL21vZGVsL01lc3NhZ2VFbnRpdHkuamF2YQ==) | `38.88% <0.00%> (-5.56%)` | :arrow_down: |
| [...sh/client/grpc/consumer/EventMeshGrpcConsumer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/976/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXNkay1qYXZhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY2xpZW50L2dycGMvY29uc3VtZXIvRXZlbnRNZXNoR3JwY0NvbnN1bWVyLmphdmE=) | `75.80% <0.00%> (-1.62%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/976?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/976?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [dab1086...6d37e43](https://codecov.io/gh/apache/incubator-eventmesh/pull/976?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] ruanwenjun commented on a diff in pull request #976: [MINOR] Use Apache release rather than Github release in README
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on code in PR #976:
URL: https://github.com/apache/incubator-eventmesh/pull/976#discussion_r914356719
##########
docs/en/installation/01-runtime.md:
##########
@@ -40,20 +40,21 @@ bash bin/start.sh
Gradle is the build automation tool used by Apache EventMesh (Incubating). Please refer to the [offical guide](https://docs.gradle.org/current/userguide/installation.html) to install the latest release of Gradle.
-Download and extract the source code of the latest release (v1.4.0) from [GitHub releases](https://github.com/apache/incubator-eventmesh/releases).
+Download and extract the source code of the latest release from [EventMesh download](https://eventmesh.apache.org/download).
```console
-wget https://github.com/apache/incubator-eventmesh/archive/refs/tags/v1.4.0.tar.gz
+wget https://dlcdn.apache.org/incubator/eventmesh/1.4.0-incubating/apache-eventmesh-{version}-source.tar.gz
Review Comment:
Thanks for your review, done.
##########
docs/en/installation/01-runtime.md:
##########
@@ -40,20 +40,21 @@ bash bin/start.sh
Gradle is the build automation tool used by Apache EventMesh (Incubating). Please refer to the [offical guide](https://docs.gradle.org/current/userguide/installation.html) to install the latest release of Gradle.
-Download and extract the source code of the latest release (v1.4.0) from [GitHub releases](https://github.com/apache/incubator-eventmesh/releases).
+Download and extract the source code of the latest release from [EventMesh download](https://eventmesh.apache.org/download).
```console
-wget https://github.com/apache/incubator-eventmesh/archive/refs/tags/v1.4.0.tar.gz
+wget https://dlcdn.apache.org/incubator/eventmesh/1.4.0-incubating/apache-eventmesh-{version}-source.tar.gz
-tar -xvzf v1.4.0.tar.gz
+tar -xvzf apache-eventmesh-{version}-source.tar.gz
Review Comment:
Done
##########
docs/en/installation/01-runtime.md:
##########
@@ -40,20 +40,21 @@ bash bin/start.sh
Gradle is the build automation tool used by Apache EventMesh (Incubating). Please refer to the [offical guide](https://docs.gradle.org/current/userguide/installation.html) to install the latest release of Gradle.
-Download and extract the source code of the latest release (v1.4.0) from [GitHub releases](https://github.com/apache/incubator-eventmesh/releases).
+Download and extract the source code of the latest release from [EventMesh download](https://eventmesh.apache.org/download).
```console
-wget https://github.com/apache/incubator-eventmesh/archive/refs/tags/v1.4.0.tar.gz
+wget https://dlcdn.apache.org/incubator/eventmesh/1.4.0-incubating/apache-eventmesh-{version}-source.tar.gz
-tar -xvzf v1.4.0.tar.gz
+tar -xvzf apache-eventmesh-{version}-source.tar.gz
```
Build the source code with Gradle.
```console
-cd incubator-eventmesh-1.4.0
-gradle clean build
+cd apache-eventmesh-{version}-source
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org