You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/07/10 00:19:01 UTC
[GitHub] [incubator-pinot] jihaozh commented on a change in pull request
#4413: [TE] frontend - harleyjj/detection-health - UI for model performance
jihaozh commented on a change in pull request #4413: [TE] frontend - harleyjj/detection-health - UI for model performance
URL: https://github.com/apache/incubator-pinot/pull/4413#discussion_r301842394
##########
File path: thirdeye/thirdeye-frontend/app/pods/components/detection-health/template.hbs
##########
@@ -0,0 +1,84 @@
+<ul class="te-horizontal-cards__single-card">
+ <li class="te-horizontal-cards__card-title">
+ <label for="select-dimension" class="control-label te-label--no-bottom">
+ 30-day status
+ <span>
+ <i class="glyphicon glyphicon-question-sign"></i>
+ {{#tooltip-on-element class="te-tooltip"}}
+ The overall health status of your detection configuration is based on
+ the most recent 30 days.
+ {{/tooltip-on-element}}
+ </span>
+ </label>
+ </li>
+ <li class="te-horizontal-cards__card-number{{overall.label}}">
+ {{overall.status}}
+ </li>
+ <a role="button" tabindex="0" class=".te-button--link">
+ view details
+ {{#bs-popover placement="bottom" title="Detection health"}}
+ <p>Overall health of the metrics that monitor detection performance.</p>
+
+ <div class="te-horizontal-metrics__container">
+ <ul class="te-horizontal-metrics__metric">
+ <li class="te-horizontal-metrics__number">{{executionTime}}</li>
+ <li class="te-horizontal-metrics__title">Execution Time</li>
Review comment:
how about calling it "health report time" or something like that? IMO, calling it execution time might be confused with the "last detection execution time".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org