You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "Jackie-Jiang (via GitHub)" <gi...@apache.org> on 2025/11/14 00:57:19 UTC
[PR] Add error message for leaf stage errors [pinot]
Jackie-Jiang opened a new pull request, #17207:
URL: https://github.com/apache/pinot/pull/17207
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Add error message for leaf stage errors [pinot]
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 merged PR #17207:
URL: https://github.com/apache/pinot/pull/17207
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Add error message for leaf stage errors [pinot]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17207:
URL: https://github.com/apache/pinot/pull/17207#issuecomment-3530455793
### :x: 2 Tests Failed:
| Tests completed | Failed | Passed | Skipped |
|---|---|---|---|
| 5630 | 2 | 5628 | 0 |
<details><summary>View the top 2 failed test(s) by shortest run time</summary>
> <pre><code class="language-python">org.apache.pinot.controller.helix.core.minion.PinotTaskManagerDistributedLockingTest::testConcurrentCreateTaskFromMultipleControllers</code></pre>
> <details><summary>Stack Traces | 9.48s run time</summary>
>
> > <pre><code class="language-python">At least one task generation should have occurred expected [1] but found [2]</code></pre>
>
> </details>
> <pre><code class="language-python">org.apache.pinot.controller.helix.core.minion.PinotTaskManagerDistributedLockingTest::testConcurrentCreateTaskFromMultipleControllers</code></pre>
> <details><summary>Stack Traces | 11.7s run time</summary>
>
> > <pre><code class="language-python">At least one task generation should have occurred expected [1] but found [2]</code></pre>
>
> </details>
</details>
To view more test analytics, go to the [Test Analytics Dashboard](https://app.codecov.io/gh/apache/pinot/tests/Jackie-Jiang%3Aleaf_error_message)
<sub>📋 Got 3 mins? [Take this short survey](https://forms.gle/22i53Qa1CySZjA6c7) to help us improve Test Analytics.</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Add error message for leaf stage errors [pinot]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #17207:
URL: https://github.com/apache/pinot/pull/17207#discussion_r2525388881
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/LeafOperator.java:
##########
@@ -460,6 +461,9 @@ void execute() {
try {
// Drain the latch when receiving exception block and not wait for the other thread to finish
executeOneRequest(request, latch::countDown);
+ } catch (Throwable t) {
+ // TODO: We need to propagate this error back
+ LOGGER.error("Caught exception while executing leaf stage on hybrid table", t);
Review Comment:
The TODO comment indicates incomplete error handling. Currently, exceptions caught here are only logged but not propagated, which could hide failures in hybrid table queries. Consider implementing proper error propagation (e.g., calling `setErrorBlock` similar to line 430-431) or creating a tracking issue to address this.
```suggestion
LOGGER.error("Caught exception while executing leaf stage on hybrid table", t);
setErrorBlock(new ErrorMseBlock(QueryErrorCode.SERVER_ERROR, "Exception in hybrid table leaf stage: " + t.getMessage(), t));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org