You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/10/16 12:17:49 UTC
[GitHub] [flink] yanghua commented on a change in pull request #9906:
[FLINK-14395] Refactor ES 6 connector to split table-specific code into
flink-sql-connector-elasticsearch6
yanghua commented on a change in pull request #9906: [FLINK-14395] Refactor ES 6 connector to split table-specific code into flink-sql-connector-elasticsearch6
URL: https://github.com/apache/flink/pull/9906#discussion_r335438393
##########
File path: flink-connectors/flink-sql-connector-elasticsearch6/src/test/java/org/apache/flink/streaming/sql/connectors/elasticsearch6/Elasticsearch6UpsertTableSinkFactoryTest.java
##########
@@ -65,11 +65,11 @@ public void testBuilder() {
final TestElasticsearch6UpsertTableSink testSink = new TestElasticsearch6UpsertTableSink(
false,
schema,
- Collections.singletonList(new Host(HOSTNAME, PORT, SCHEMA)),
- INDEX,
- DOC_TYPE,
- KEY_DELIMITER,
- KEY_NULL_LITERAL,
+ Collections.singletonList(new Host(ElasticsearchUpsertTableSinkFactoryTestBase.HOSTNAME, ElasticsearchUpsertTableSinkFactoryTestBase.PORT, ElasticsearchUpsertTableSinkFactoryTestBase.SCHEMA)),
Review comment:
You are right. The IDE added the prefix when I moving the class files.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services