You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "echauchot (via GitHub)" <gi...@apache.org> on 2023/06/23 14:35:29 UTC

[GitHub] [flink-connector-cassandra] echauchot opened a new pull request, #19: [FLINK-32353] update archunit violations for prod and test code with flink-1.18 rules

echauchot opened a new pull request, #19:
URL: https://github.com/apache/flink-connector-cassandra/pull/19

   The mini cluster rule has been fixed in flink-1.18 (here https://github.com/apache/flink/pull/22399/) so:
   
   - CassandraConnectorITCase does not use/needs MiniCluster so it is still an "violation" but the rule message has changed.
   - the "violation" for CassandraSourceITCase is now gone as the rule was fixed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-32353] [hotfix] build against last flink 1.16 and 1.17 and enable archunit only on main flink release [flink-connector-cassandra]

Posted by "echauchot (via GitHub)" <gi...@apache.org>.
echauchot commented on PR #19:
URL: https://github.com/apache/flink-connector-cassandra/pull/19#issuecomment-1750384738

   Hi @tzulitai yes I fell back this PR's scope to just upgrading the versions hence the self merge. But, as I just wrote in [this ticket](https://issues.apache.org/jira/browse/FLINK-33104?focusedCommentId=17772516&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17772516), I'll submit a new PR to change the build system and tackle this problem. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-32353] [hotfix] build against last flink 1.16 and 1.17 and enable archunit only on main flink release [flink-connector-cassandra]

Posted by "tzulitai (via GitHub)" <gi...@apache.org>.
tzulitai commented on PR #19:
URL: https://github.com/apache/flink-connector-cassandra/pull/19#issuecomment-1749692586

   Hey @echauchot I'm trying to fix the same thing for the Kafka connector, but I could use your help on understanding the change here.
   
   What exactly is the change that enables archunit only for main Flink releases? I can't seem to link what was changed in this PR that would have that effect.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-connector-cassandra] echauchot merged pull request #19: [FLINK-32353] [hotfix] build against last flink 1.16 and 1.17 and enable archunit only on main flink release

Posted by "echauchot (via GitHub)" <gi...@apache.org>.
echauchot merged PR #19:
URL: https://github.com/apache/flink-connector-cassandra/pull/19


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-connector-cassandra] echauchot commented on pull request #19: [FLINK-32353] update archunit violations for prod and test code with flink-1.18 rules

Posted by "echauchot (via GitHub)" <gi...@apache.org>.
echauchot commented on PR #19:
URL: https://github.com/apache/flink-connector-cassandra/pull/19#issuecomment-1610960336

   > > > Maybe we should add tests against flink master snapshot ? Right now there is only 1.16.x 1.17.x in PRs
   > > 
   > > 
   > > added 1.18-SNAPSHOT tests
   > 
   > Got it, the failure we observe is due to flink 1.16/1.17 updating achunit freeze store with different rules. Then, the [flink-1](https://issues.apache.org/jira/browse/FLINK-1).18 build fails because it has the new rules so the violations are different.
   > 
   > I believe, having the build against flink master in PRs makes sense because it allows to not wait for weekly tests to see regressions. @MartijnVisser how should we setup the build to avoid the behavior described above ?
   
   What about adding Flink version to archunit violations store name ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-connector-cassandra] echauchot commented on pull request #19: [FLINK-32353] [hotfix] build against last flink 1.16 and 1.17 and enable archunit only on main flink release

Posted by "echauchot (via GitHub)" <gi...@apache.org>.
echauchot commented on PR #19:
URL: https://github.com/apache/flink-connector-cassandra/pull/19#issuecomment-1674627393

   It is an hotfix, so, self-merging


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-connector-cassandra] echauchot commented on pull request #19: [FLINK-32353] update archunit violations for prod and test code with flink-1.18 rules

Posted by "echauchot (via GitHub)" <gi...@apache.org>.
echauchot commented on PR #19:
URL: https://github.com/apache/flink-connector-cassandra/pull/19#issuecomment-1609303291

   > > Maybe we should add tests against flink master snapshot ? Right now there is only 1.16.x 1.17.x in PRs
   > 
   > added 1.18-SNAPSHOT tests
   
   Got it, the failure we observe is due to flink 1.16/1.17 updating achunit freeze store with different rules. Then, the flink-1.18 build fails because it has the new rules so the violations are different.
   
   I believe, having the build on master in PRs makes sense because it allows to not wait for weekly tests to see regressions.
   @MartijnVisser how should we setup the build to avoid the behavior described above ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-connector-cassandra] echauchot commented on pull request #19: [FLINK-32353] update archunit violations for prod and test code with flink-1.18 rules

Posted by "echauchot (via GitHub)" <gi...@apache.org>.
echauchot commented on PR #19:
URL: https://github.com/apache/flink-connector-cassandra/pull/19#issuecomment-1604662832

   Maybe we should add tests against flink master snaphot ? Right now there is only 1.16.x 1.17.x


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-connector-cassandra] echauchot commented on pull request #19: [FLINK-32353] update archunit violations for prod and test code with flink-1.18 rules

Posted by "echauchot (via GitHub)" <gi...@apache.org>.
echauchot commented on PR #19:
URL: https://github.com/apache/flink-connector-cassandra/pull/19#issuecomment-1607151734

   > Maybe we should add tests against flink master snapshot ? Right now there is only 1.16.x 1.17.x in PRs
   
   added 1.18-SNAPSHOT tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org