You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by dgshep <gi...@git.apache.org> on 2017/04/27 20:11:26 UTC

[GitHub] spark pull request #17788: [SPARK-20483][MINOR] Add test for case

GitHub user dgshep opened a pull request:

    https://github.com/apache/spark/pull/17788

    [SPARK-20483][MINOR] Add test for case

    ## What changes were proposed in this pull request?
    
    Add test case for scenarios where executor.cores is set as a
    (non)divisor of spark.cores.max
    This tests the change in 
    #17786 
    
    ## How was this patch tested?
    
    Ran the existing test suite with the new tests
    
    @dbtsai 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dgshep/spark add_mesos_test

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/17788.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #17788
    
----
commit 7270fef16b1b47e1084a1fc777e08502ada402e0
Author: Davis Shepherd <ds...@netflix.com>
Date:   2017-04-27T20:06:51Z

    [SPARK-20483][MINOR] Add test for case
    
    Add test case for scenarios where executor.cores is set as a
    (non)divisor of spark.cores.max

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17788: [SPARK-20483][MINOR] Add test for case

Posted by dgshep <gi...@git.apache.org>.
Github user dgshep commented on the issue:

    https://github.com/apache/spark/pull/17788
  
    Jenkins, ok to test.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #17788: [SPARK-20483][MINOR] Test for Mesos Coarse mode m...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/17788


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17788: [SPARK-20483][MINOR] Test for Mesos Coarse mode may star...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17788
  
    Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17788: [SPARK-20483][MINOR] Test for Mesos Coarse mode may star...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/17788
  
    **[Test build #76240 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76240/testReport)** for PR 17788 at commit [`7270fef`](https://github.com/apache/spark/commit/7270fef16b1b47e1084a1fc777e08502ada402e0).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17788: [SPARK-20483][MINOR] Test for Mesos Coarse mode may star...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17788
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76240/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17788: [SPARK-20483][MINOR] Add test for case

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/17788
  
    **[Test build #76240 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76240/testReport)** for PR 17788 at commit [`7270fef`](https://github.com/apache/spark/commit/7270fef16b1b47e1084a1fc777e08502ada402e0).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17788: [SPARK-20483][MINOR] Test for Mesos Coarse mode may star...

Posted by dbtsai <gi...@git.apache.org>.
Github user dbtsai commented on the issue:

    https://github.com/apache/spark/pull/17788
  
    LGTM. Merged into master and branch 2.1. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org