You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "balesh2 (GitHub)" <gi...@apache.org> on 2019/01/10 23:07:29 UTC
[GitHub] [geode-benchmarks] balesh2 opened pull request #38: Update
script for running tests on AWS
Update the script for running tests on AWS to use the default version
number. The gradle parameters for specifying a custom version number
change in different versions. To have one script that works for all
versions, we use the default version number then get that version from
gfsh for use in benchmarks.
Co-Authored-By: jbarrett@pivotal.io
[ Full content available at: https://github.com/apache/geode-benchmarks/pull/38 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-benchmarks] nabarunnag commented on pull request #38:
Update script for running tests on AWS
Posted by "nabarunnag (GitHub)" <gi...@apache.org>.
```
ssh ${SSH_OPTIONS} geode@$FIRST_INSTANCE << EOF
rm -rf geode-benchmarks geode
git clone https://github.com/apache/geode geode
(pushd geode && git checkout ${BRANCH})
(pushd geode && ./gradlew install installDist)
export VERSION="$(geode/geode-assembly/build/install/apache-geode/bin/gfsh version)"
git clone https://github.com/apache/geode-benchmarks --branch ${BENCHMARK_BRANCH} && \
cd geode-benchmarks && \
./gradlew -PgeodeVersion=$VERSION benchmark -Phosts=${HOSTS}"
EOF
```
[ Full content available at: https://github.com/apache/geode-benchmarks/pull/38 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-benchmarks] balesh2 commented on issue #38: Update
script for running tests on AWS
Posted by "balesh2 (GitHub)" <gi...@apache.org>.
Test failure is due to the heap size issue in travis.
[ Full content available at: https://github.com/apache/geode-benchmarks/pull/38 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-benchmarks] pivotal-jbarrett commented on issue #38:
Update script for running tests on AWS
Posted by "pivotal-jbarrett (GitHub)" <gi...@apache.org>.
Yeah it worked on develop, 1.3.0, 1.8.0 and 1.7.0.
[ Full content available at: https://github.com/apache/geode-benchmarks/pull/38 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-benchmarks] nabarunnag commented on issue #38: Update
script for running tests on AWS
Posted by "nabarunnag (GitHub)" <gi...@apache.org>.
Did you check this with develop? for some reason I am unable to get this working with develop
[ Full content available at: https://github.com/apache/geode-benchmarks/pull/38 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-benchmarks] smgoller closed pull request #38: Update
script for running tests on AWS
Posted by "smgoller (GitHub)" <gi...@apache.org>.
[ pull request closed by smgoller ]
[ Full content available at: https://github.com/apache/geode-benchmarks/pull/38 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-benchmarks] nabarunnag commented on issue #38: Update
script for running tests on AWS
Posted by "nabarunnag (GitHub)" <gi...@apache.org>.
But the build is passing. :(
[ Full content available at: https://github.com/apache/geode-benchmarks/pull/38 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-benchmarks] pivotal-jbarrett commented on pull
request #38: Update script for running tests on AWS
Posted by "pivotal-jbarrett (GitHub)" <gi...@apache.org>.
Readability. The version variable would need to escaped so that it is evaluated after the gfsh command executed just prior to the second gradlew.
[ Full content available at: https://github.com/apache/geode-benchmarks/pull/38 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-benchmarks] nabarunnag commented on pull request #38:
Update script for running tests on AWS
Posted by "nabarunnag (GitHub)" <gi...@apache.org>.
I don't if this has any downfalls. @smgoller can you comment ? I remember you changed my EOF way of writing ssh scripts to '\' method.
[ Full content available at: https://github.com/apache/geode-benchmarks/pull/38 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-benchmarks] nabarunnag commented on pull request #38:
Update script for running tests on AWS
Posted by "nabarunnag (GitHub)" <gi...@apache.org>.
Is there a reason why this is done in 3 ssh sessions to one machine rather than one?
[export VERSION="$(./gfsh version)"]
[ Full content available at: https://github.com/apache/geode-benchmarks/pull/38 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-benchmarks] pivotal-jbarrett commented on pull
request #38: Update script for running tests on AWS
Posted by "pivotal-jbarrett (GitHub)" <gi...@apache.org>.
Go for it!
[ Full content available at: https://github.com/apache/geode-benchmarks/pull/38 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-benchmarks] nabarunnag commented on pull request #38:
Update script for running tests on AWS
Posted by "nabarunnag (GitHub)" <gi...@apache.org>.
I don't know if this has any downfalls. @smgoller can you comment ? I remember you changed my EOF way of writing ssh scripts to '\' method.
[ Full content available at: https://github.com/apache/geode-benchmarks/pull/38 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-benchmarks] nabarunnag commented on pull request #38:
Update script for running tests on AWS
Posted by "nabarunnag (GitHub)" <gi...@apache.org>.
```
ssh ${SSH_OPTIONS} geode@$FIRST_INSTANCE << EOF
rm -rf geode-benchmarks geode
git clone https://github.com/apache/geode geode
(pushd geode && git checkout ${BRANCH})
(pushd geode && ./gradlew install installDist)
export VERSION="$(geode/geode-assembly/build/install/apache-geode/bin/gfsh version)"
git clone https://github.com/apache/geode-benchmarks --branch ${BENCHMARK_BRANCH}
cd geode-benchmarks
./gradlew -PgeodeVersion=$VERSION benchmark -Phosts=${HOSTS}
EOF
```
[ Full content available at: https://github.com/apache/geode-benchmarks/pull/38 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org