You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by Ryan Rawson <ry...@gmail.com> on 2010/09/01 00:10:34 UTC
Review Request: HBASE-2941 - multithreaded read for server rpc
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/752/
-----------------------------------------------------------
Review request for hbase.
Summary
-------
HBASE-2941 - multithreaded read for server rpc, port of HADOOP-6713
This addresses bug HBASE-2941.
http://issues.apache.org/jira/browse/HBASE-2941
Diffs
-----
trunk/src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java 991357
Diff: http://review.cloudera.org/r/752/diff
Testing
-------
see jira for performance spreadsheet
Thanks,
Ryan
Re: Review Request: HBASE-2941 - multithreaded read for server rpc
Posted by Ryan Rawson <ry...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/752/
-----------------------------------------------------------
(Updated 2010-09-14 14:19:53.985785)
Review request for hbase.
Changes
-------
use shutdownNow() to interrupt the reader threads so the server will cleanly shut down.
Summary
-------
HBASE-2941 - multithreaded read for server rpc, port of HADOOP-6713
This addresses bug HBASE-2941.
http://issues.apache.org/jira/browse/HBASE-2941
Diffs (updated)
-----
trunk/src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java 997098
Diff: http://review.cloudera.org/r/752/diff
Testing
-------
see jira for performance spreadsheet
Thanks,
Ryan
Re: Review Request: HBASE-2941 - multithreaded read for server rpc
Posted by Ryan Rawson <ry...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/752/#review1068
-----------------------------------------------------------
trunk/src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java
<http://review.cloudera.org/r/752/#comment3393>
the while (Running) condition will catch this and exit once the server wants to shut down.
trunk/src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java
<http://review.cloudera.org/r/752/#comment3394>
yes it should, i have been testing @ 1 and 10 threads, probably 10 makes sense considering how heavily we use hbase rpc.
- Ryan
On 2010-08-31 15:10:34, Ryan Rawson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/752/
> -----------------------------------------------------------
>
> (Updated 2010-08-31 15:10:34)
>
>
> Review request for hbase.
>
>
> Summary
> -------
>
> HBASE-2941 - multithreaded read for server rpc, port of HADOOP-6713
>
>
> This addresses bug HBASE-2941.
> http://issues.apache.org/jira/browse/HBASE-2941
>
>
> Diffs
> -----
>
> trunk/src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java 991357
>
> Diff: http://review.cloudera.org/r/752/diff
>
>
> Testing
> -------
>
> see jira for performance spreadsheet
>
>
> Thanks,
>
> Ryan
>
>
Re: Review Request: HBASE-2941 - multithreaded read for server rpc
Posted by Ted Yu <te...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/752/#review1067
-----------------------------------------------------------
trunk/src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java
<http://review.cloudera.org/r/752/#comment3391>
Should we come out of the while loop ?
trunk/src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java
<http://review.cloudera.org/r/752/#comment3392>
Should the default value be higher ?
- Ted
On 2010-08-31 15:10:34, Ryan Rawson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/752/
> -----------------------------------------------------------
>
> (Updated 2010-08-31 15:10:34)
>
>
> Review request for hbase.
>
>
> Summary
> -------
>
> HBASE-2941 - multithreaded read for server rpc, port of HADOOP-6713
>
>
> This addresses bug HBASE-2941.
> http://issues.apache.org/jira/browse/HBASE-2941
>
>
> Diffs
> -----
>
> trunk/src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java 991357
>
> Diff: http://review.cloudera.org/r/752/diff
>
>
> Testing
> -------
>
> see jira for performance spreadsheet
>
>
> Thanks,
>
> Ryan
>
>