You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "weizhouapache (via GitHub)" <gi...@apache.org> on 2023/03/13 10:13:10 UTC
[GitHub] [cloudstack] weizhouapache opened a new pull request, #7333: KVM: add vm setting for nic multiqueue number and packed virtqueues
weizhouapache opened a new pull request, #7333:
URL: https://github.com/apache/cloudstack/pull/7333
### Description
This PR adds two vm setting for user vms on KVM
- nic multiqueue number
- packed virtqueues enabled . optional are true and false (false by default). It requires qemu>=4.2.0 and libvirt >=6.3.0
Tested ok on ubuntu 22 and rocky 8.4
(See test results in Screenshots part)
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
### Screenshots (if appropriate):
- Deploy a vm
There are two new options in "Advanced mode" part.
- Start the vm. check qemu process on kvm host
it shows
```
-netdev tap,fds=57:59:60:61:62:63,id=hostnet0,vhost=on,vhostfds=64:65:66:67:68:69
-device virtio-net-pci,packed=on,mq=on,vectors=14,netdev=hostnet0,id=net0,mac=02:00:3f:4f:00:0a,bus=pci.0,addr=0x3
```
(vectors = 2 * queue number + 2)
- `virsh dumpxml` shows ` <driver queues='6' packed='on'/>`
- log into the vm, and run some commands
- enable multiqueue inside user vm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7333: KVM: add vm setting for nic multiqueue number and packed virtqueues
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7333:
URL: https://github.com/apache/cloudstack/pull/7333#issuecomment-1532690220
@borisstoyanov a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7333: KVM: add vm setting for nic multiqueue number and packed virtqueues
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7333:
URL: https://github.com/apache/cloudstack/pull/7333#issuecomment-1532761714
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7333: KVM: add vm setting for nic multiqueue number and packed virtqueues
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7333:
URL: https://github.com/apache/cloudstack/pull/7333#issuecomment-1469518755
@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KVM: add vm setting for nic multiqueue number and packed virtqueues [cloudstack]
Posted by "matheusfontes (via GitHub)" <gi...@apache.org>.
matheusfontes commented on PR #7333:
URL: https://github.com/apache/cloudstack/pull/7333#issuecomment-4113742553
This PR mentions support for user VMs on KVM. Is multiqueue also supported for Virtual Routers / Internal LB, or only for user VMs at the moment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7333: KVM: add vm setting for nic multiqueue number and packed virtqueues
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7333:
URL: https://github.com/apache/cloudstack/pull/7333#issuecomment-1465965035
This works on centos7 as well.
but centos7 with tap device does not work. got an exception
```
org.libvirt.LibvirtException: Unable to create tap device tap0200492f0004: Invalid argument
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7333: KVM: add vm setting for nic multiqueue number and packed virtqueues
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7333:
URL: https://github.com/apache/cloudstack/pull/7333#issuecomment-1532763499
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6016
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KVM: add vm setting for nic multiqueue number and packed virtqueues [cloudstack]
Posted by "bernardodemarco (via GitHub)" <gi...@apache.org>.
bernardodemarco commented on PR #7333:
URL: https://github.com/apache/cloudstack/pull/7333#issuecomment-4120305762
Hello, @matheusfontes and @weizhouapache
> Most VM settings are intended to support user VMs only.
> I'm not aware of any recent changes that extend this support to Virtual Routers or Internal LB.
Yes. There was the PR #10736 that renamed the `user_vm_details` table in the `cloud` database to `vm_instance_details`, aiming to better separate responsibilities and enable support for VM details across different VM types, including system VMs. However, support for system VM details has not yet been implemented.
---
> We had to implement this change using the agent.hooks.libvirt_vm_xml_transformer.script hook on KVM hosts to enable multiqueue for Virtual Routers.
@matheusfontes, this is a great workaround. However, it is important to note that it does not work for VPC VRs. During deployment, the Management Server sends a `StartCommand` to the Agent, which deploys the instance and configures only the NIC for the link-local/control network (CIDR `169.254.0.0/16`).
After the VR is successfully deployed, the NICs associated with public and guest networks are configured separately through `PlugNicCommand`. As a result, when the Agent hook is triggered, the VR domain XML contains only a single NIC, making it impossible to configure the remaining interfaces.
---
> can you try with some key/value settings of the SYSTEM template ?
> We tested using key/value settings on the SYSTEM template, but it didn’t have any effect on Virtual Routers during deployment.
Yes. Currently, template settings are not inherited by system VMs.
> While this could be a good alternative if supported, it would still not allow us to adjust the number of queues based on the number of vCPUs.
> This type of configuration would fit better at the System Offering level, where CPU characteristics are already defined.
Yes, while that approach would be valid, maintaining consistency with the existing settings model for user VMs would be a better solution IMHO. This would also allow to adjust the number of queues based on the CPU characteristics of the VMs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7333: KVM: add vm setting for nic multiqueue number and packed virtqueues
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7333:
URL: https://github.com/apache/cloudstack/pull/7333#issuecomment-1506762170
@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #7333: KVM: add vm setting for nic multiqueue number and packed virtqueues
Posted by "borisstoyanov (via GitHub)" <gi...@apache.org>.
borisstoyanov commented on PR #7333:
URL: https://github.com/apache/cloudstack/pull/7333#issuecomment-1532758925
@blueorangutan test keepEnv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KVM: add vm setting for nic multiqueue number and packed virtqueues [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7333:
URL: https://github.com/apache/cloudstack/pull/7333#issuecomment-4114297783
> This PR mentions support for user VMs on KVM. Is multiqueue also supported for Virtual Routers / Internal LB, or only for user VMs at the moment?
Most VM settings are intended to support user VMs only.
I’m not aware of any recent changes that extend this support to Virtual Routers or Internal LB.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #7333: KVM: add vm setting for nic multiqueue number and packed virtqueues
Posted by "borisstoyanov (via GitHub)" <gi...@apache.org>.
borisstoyanov commented on PR #7333:
URL: https://github.com/apache/cloudstack/pull/7333#issuecomment-1532677711
@blueorangutan test keepEnv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7333: KVM: add vm setting for nic multiqueue number and packed virtqueues
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #7333:
URL: https://github.com/apache/cloudstack/pull/7333#issuecomment-1465955358
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=7333)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7333&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7333&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7333&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7333&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7333&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7333&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7333&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7333&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7333&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7333&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7333&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7333&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7333&metric=new_coverage&view=list) [17.3% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7333&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7333&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7333&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7333: KVM: add vm setting for nic multiqueue number and packed virtqueues
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #7333:
URL: https://github.com/apache/cloudstack/pull/7333#issuecomment-1466135827
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=7333)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7333&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7333&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7333&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7333&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7333&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7333&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7333&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7333&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7333&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7333&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7333&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7333&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7333&metric=new_coverage&view=list) [33.7% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7333&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7333&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7333&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7333: KVM: add vm setting for nic multiqueue number and packed virtqueues
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7333:
URL: https://github.com/apache/cloudstack/pull/7333#issuecomment-1506761624
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7333: KVM: add vm setting for nic multiqueue number and packed virtqueues
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7333:
URL: https://github.com/apache/cloudstack/pull/7333#issuecomment-1508372036
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7333: KVM: add vm setting for nic multiqueue number and packed virtqueues
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7333:
URL: https://github.com/apache/cloudstack/pull/7333#issuecomment-1508438264
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5912
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7333: KVM: add vm setting for nic multiqueue number and packed virtqueues
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #7333:
URL: https://github.com/apache/cloudstack/pull/7333#issuecomment-1539811562
Merging based on manual tests by @borisstoyanov, CI tests and reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7333: KVM: add vm setting for nic multiqueue number and packed virtqueues
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7333:
URL: https://github.com/apache/cloudstack/pull/7333#issuecomment-1532678361
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7333: KVM: add vm setting for nic multiqueue number and packed virtqueues
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7333:
URL: https://github.com/apache/cloudstack/pull/7333#issuecomment-1534715394
> LGTM, I've manually tested it and confirmed the failing test was passing in a separate run
>
> ```
> Test force reboot CPVM ... === TestName: test_10_reboot_cpvm_forced | Status : SUCCESS ===
> ```
great, thanks @borisstoyanov for the testing !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7333: KVM: add vm setting for nic multiqueue number and packed virtqueues
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7333:
URL: https://github.com/apache/cloudstack/pull/7333#issuecomment-1533869950
<b>Trillian test result (tid-6499)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45937 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7333-t6499-kvm-centos7.zip
Smoke tests completed. 109 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_10_reboot_cpvm_forced | `Error` | 6.28 | test_ssvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud merged pull request #7333: KVM: add vm setting for nic multiqueue number and packed virtqueues
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud merged PR #7333:
URL: https://github.com/apache/cloudstack/pull/7333
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7333: KVM: add vm setting for nic multiqueue number and packed virtqueues
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #7333:
URL: https://github.com/apache/cloudstack/pull/7333#issuecomment-1537871043
@weizhouapache @borisstoyanov is this ready for merging or there's further testing on-going?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7333: KVM: add vm setting for nic multiqueue number and packed virtqueues
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7333:
URL: https://github.com/apache/cloudstack/pull/7333#issuecomment-1469942158
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #7333: KVM: add vm setting for nic multiqueue number and packed virtqueues
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #7333:
URL: https://github.com/apache/cloudstack/pull/7333#issuecomment-1468543252
## [Codecov](https://codecov.io/gh/apache/cloudstack/pull/7333?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7333](https://codecov.io/gh/apache/cloudstack/pull/7333?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bcdbe30) into [main](https://codecov.io/gh/apache/cloudstack/commit/f64f7b9d12afc4c90142dc0eacbf4b3cfad4063b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f64f7b9) will **increase** coverage by `0.00%`.
> The diff coverage is `30.00%`.
```diff
@@ Coverage Diff @@
## main #7333 +/- ##
=========================================
Coverage 12.68% 12.69%
Complexity 8654 8654
=========================================
Files 2716 2716
Lines 256117 256165 +48
Branches 39928 39944 +16
=========================================
+ Hits 32499 32514 +15
- Misses 219485 219510 +25
- Partials 4133 4141 +8
```
| [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/7333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ervisor/kvm/resource/LibvirtComputingResource.java](https://codecov.io/gh/apache/cloudstack/pull/7333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vcmVzb3VyY2UvTGlidmlydENvbXB1dGluZ1Jlc291cmNlLmphdmE=) | `18.16% <0.00%> (-0.14%)` | :arrow_down: |
| [...resource/wrapper/LibvirtPlugNicCommandWrapper.java](https://codecov.io/gh/apache/cloudstack/pull/7333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vcmVzb3VyY2Uvd3JhcHBlci9MaWJ2aXJ0UGx1Z05pY0NvbW1hbmRXcmFwcGVyLmphdmE=) | `78.04% <0.00%> (-4.01%)` | :arrow_down: |
| [...source/wrapper/LibvirtReplugNicCommandWrapper.java](https://codecov.io/gh/apache/cloudstack/pull/7333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vcmVzb3VyY2Uvd3JhcHBlci9MaWJ2aXJ0UmVwbHVnTmljQ29tbWFuZFdyYXBwZXIuamF2YQ==) | `79.24% <0.00%> (-3.11%)` | :arrow_down: |
| [...ain/java/com/cloud/api/query/QueryManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2FwaS9xdWVyeS9RdWVyeU1hbmFnZXJJbXBsLmphdmE=) | `2.94% <0.00%> (-0.01%)` | :arrow_down: |
| [...ypervisor/kvm/resource/LibvirtDomainXMLParser.java](https://codecov.io/gh/apache/cloudstack/pull/7333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vcmVzb3VyY2UvTGlidmlydERvbWFpblhNTFBhcnNlci5qYXZh) | `50.19% <33.33%> (-0.42%)` | :arrow_down: |
| [...pper/LibvirtPrepareForMigrationCommandWrapper.java](https://codecov.io/gh/apache/cloudstack/pull/7333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vcmVzb3VyY2Uvd3JhcHBlci9MaWJ2aXJ0UHJlcGFyZUZvck1pZ3JhdGlvbkNvbW1hbmRXcmFwcGVyLmphdmE=) | `43.33% <50.00%> (+0.22%)` | :arrow_up: |
| [...om/cloud/hypervisor/kvm/resource/LibvirtVMDef.java](https://codecov.io/gh/apache/cloudstack/pull/7333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vcmVzb3VyY2UvTGlidmlydFZNRGVmLmphdmE=) | `67.35% <85.71%> (+0.21%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KVM: add vm setting for nic multiqueue number and packed virtqueues [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7333:
URL: https://github.com/apache/cloudstack/pull/7333#issuecomment-4117737708
> > We had to implement this change using the agent.hooks.libvirt_vm_xml_transformer.script hook on KVM hosts to enable multiqueue for Virtual Routers.
> > After applying to virtio interfaces, we observed a significant improvement in throughput, confirming that VRs are currently limited by single-queue virtio by default.
> > It may be worth considering extending support for these NIC settings to System VMs (Virtual Routers, Internal LB), since they can become network bottlenecks in high-throughput environments.
> > A possible approach could be to leverage System Offering External Details, where key/value pairs are already supported. For example: • nic.packed.virtqueues.enabled • nic.multiqueue.number
> > This would provide a clean, native and persistent way to tune virtio NIC performance for System VMs, avoiding the need for custom libvirt hooks.
>
> @matheusfontes Thanks for sharing. This is very interesting, and it makes sense to consider extending VM settings support to Virtual Routers.
>
> Regarding the approach, extension-specific details are typically handled through the CloudStack extension framework. We could consider extending support for additional settings in service offering details. At the moment, service offering details are mainly used for constraint service offering such as min/max CPU and memory. This might provide a more flexible and native way to configure such parameters, including NIC-related options,
@matheusfontes
can you try with some key/value settings of the SYSTEM template ?
<img width="2417" height="1265" alt="image" src="https://github.com/user-attachments/assets/a9e890c1-e6c2-49db-9c67-0835ee4d8cd1" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KVM: add vm setting for nic multiqueue number and packed virtqueues [cloudstack]
Posted by "matheusfontes (via GitHub)" <gi...@apache.org>.
matheusfontes commented on PR #7333:
URL: https://github.com/apache/cloudstack/pull/7333#issuecomment-4117506981
We had to implement this change using the agent.hooks.libvirt_vm_xml_transformer.script hook on KVM hosts to enable multiqueue for Virtual Routers.
After applying <driver name='vhost' queues='X'/> to virtio interfaces, we observed a significant improvement in throughput, confirming that VRs are currently limited by single-queue virtio by default.
It may be worth considering extending support for these NIC settings to System VMs (Virtual Routers, Internal LB), since they can become network bottlenecks in high-throughput environments.
A possible approach could be to leverage System Offering External Details, where key/value pairs are already supported. For example:
• nic.packed.virtqueues.enabled
• nic.multiqueue.number
This would provide a clean, native and persistent way to tune virtio NIC performance for System VMs, avoiding the need for custom libvirt hooks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KVM: add vm setting for nic multiqueue number and packed virtqueues [cloudstack]
Posted by "matheusfontes (via GitHub)" <gi...@apache.org>.
matheusfontes commented on PR #7333:
URL: https://github.com/apache/cloudstack/pull/7333#issuecomment-4118634375
We did try using key/value settings on the SYSTEM template, but it didn’t have any effect on Virtual Routers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #7333: KVM: add vm setting for nic multiqueue number and packed virtqueues
Posted by "borisstoyanov (via GitHub)" <gi...@apache.org>.
borisstoyanov commented on PR #7333:
URL: https://github.com/apache/cloudstack/pull/7333#issuecomment-1532688886
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7333: KVM: add vm setting for nic multiqueue number and packed virtqueues
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #7333:
URL: https://github.com/apache/cloudstack/pull/7333#issuecomment-1468572566
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=7333)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7333&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7333&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7333&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7333&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7333&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7333&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7333&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7333&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7333&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7333&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7333&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7333&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7333&metric=new_coverage&view=list) [30.2% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7333&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7333&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7333&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7333: KVM: add vm setting for nic multiqueue number and packed virtqueues
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7333:
URL: https://github.com/apache/cloudstack/pull/7333#issuecomment-1469591010
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5723
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7333: KVM: add vm setting for nic multiqueue number and packed virtqueues
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7333:
URL: https://github.com/apache/cloudstack/pull/7333#issuecomment-1469943130
@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7333: KVM: add vm setting for nic multiqueue number and packed virtqueues
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7333:
URL: https://github.com/apache/cloudstack/pull/7333#issuecomment-1469517636
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7333: KVM: add vm setting for nic multiqueue number and packed virtqueues
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #7333:
URL: https://github.com/apache/cloudstack/pull/7333#issuecomment-1470028948
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=7333)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7333&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7333&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7333&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7333&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7333&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7333&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7333&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7333&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7333&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7333&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7333&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7333&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7333&metric=new_coverage&view=list) [30.2% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7333&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7333&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7333&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7333: KVM: add vm setting for nic multiqueue number and packed virtqueues
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7333:
URL: https://github.com/apache/cloudstack/pull/7333#issuecomment-1470027312
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5724
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7333: KVM: add vm setting for nic multiqueue number and packed virtqueues
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7333:
URL: https://github.com/apache/cloudstack/pull/7333#issuecomment-1508372706
@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KVM: add vm setting for nic multiqueue number and packed virtqueues [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7333:
URL: https://github.com/apache/cloudstack/pull/7333#issuecomment-4117583742
> We had to implement this change using the agent.hooks.libvirt_vm_xml_transformer.script hook on KVM hosts to enable multiqueue for Virtual Routers.
>
> After applying to virtio interfaces, we observed a significant improvement in throughput, confirming that VRs are currently limited by single-queue virtio by default.
>
> It may be worth considering extending support for these NIC settings to System VMs (Virtual Routers, Internal LB), since they can become network bottlenecks in high-throughput environments.
>
> A possible approach could be to leverage System Offering External Details, where key/value pairs are already supported. For example: • nic.packed.virtqueues.enabled • nic.multiqueue.number
>
> This would provide a clean, native and persistent way to tune virtio NIC performance for System VMs, avoiding the need for custom libvirt hooks.
@matheusfontes
Thanks for sharing. This is very interesting, and it makes sense to consider extending VM settings support to Virtual Routers.
Regarding the approach, extension-specific details are typically handled through the CloudStack extension framework.
We could consider extending support for additional settings in service offering details. At the moment, service offering details are mainly used for constraint service offering such as min/max CPU and memory. This might provide a more flexible and native way to configure such parameters, including NIC-related options,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org