You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/12 10:55:56 UTC
[GitHub] [spark] yoda-mon opened a new pull request #34258: [SPARK-36976][R] Add max_by/min_by API to SparkR
yoda-mon opened a new pull request #34258:
URL: https://github.com/apache/spark/pull/34258
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Add max_by/min_by to SparkR
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
for sparkr users' convenience
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
yes, new methods are added
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
unit test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #34258: [SPARK-36976][R] Add max_by/min_by API to SparkR
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #34258:
URL: https://github.com/apache/spark/pull/34258
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34258: [SPARK-36976][R] Add max_by/min_by API to SparkR
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34258:
URL: https://github.com/apache/spark/pull/34258#issuecomment-941901967
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144176/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yoda-mon commented on pull request #34258: [SPARK-36976][R] Add max_by/min_by API to SparkR
Posted by GitBox <gi...@apache.org>.
yoda-mon commented on pull request #34258:
URL: https://github.com/apache/spark/pull/34258#issuecomment-941859953
Example screenshot
<img width="1407" alt="Screen Shot 2021-10-13 at 11 33 52" src="https://user-images.githubusercontent.com/14937752/137057217-464ba580-1fdb-4bf5-a2d5-2a1007fede63.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yoda-mon edited a comment on pull request #34258: [SPARK-36976][R] Add max_by/min_by API to SparkR
Posted by GitBox <gi...@apache.org>.
yoda-mon edited a comment on pull request #34258:
URL: https://github.com/apache/spark/pull/34258#issuecomment-941859953
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34258: [SPARK-36976][R] Add max_by/min_by API to SparkR
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34258:
URL: https://github.com/apache/spark/pull/34258#issuecomment-941901967
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yoda-mon edited a comment on pull request #34258: [SPARK-36976][R] Add max_by/min_by API to SparkR
Posted by GitBox <gi...@apache.org>.
yoda-mon edited a comment on pull request #34258:
URL: https://github.com/apache/spark/pull/34258#issuecomment-941859953
Example screenshot (Edited: after fixing indent)
<img width="1164" alt="Screen Shot 2021-10-13 at 11 38 04" src="https://user-images.githubusercontent.com/14937752/137057568-67e052c9-10d6-4e3e-b8de-ca56dabdb3b9.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34258: [SPARK-36976][R] Add max_by/min_by API to SparkR
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34258:
URL: https://github.com/apache/spark/pull/34258#issuecomment-941033885
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48625/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34258: [SPARK-36976][R] Add max_by/min_by API to SparkR
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34258:
URL: https://github.com/apache/spark/pull/34258#issuecomment-940936145
**[Test build #144148 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144148/testReport)** for PR 34258 at commit [`15cc6ea`](https://github.com/apache/spark/commit/15cc6ea674047411ce5f1ea618a3a4f2c243fdcb).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #34258: [SPARK-36976][R] Add max_by/min_by API to SparkR
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #34258:
URL: https://github.com/apache/spark/pull/34258#discussion_r727609837
##########
File path: R/pkg/R/generics.R
##########
@@ -1190,10 +1190,18 @@ setGeneric("map_values", function(x) { standardGeneric("map_values") })
#' @name NULL
setGeneric("map_zip_with", function(x, y, f) { standardGeneric("map_zip_with") })
+#' @rdname column_aggregate_functions
+#' @name NULL
+setGeneric("max_by", function(x, y) { standardGeneric("max_by") })
+
#' @rdname column_misc_functions
#' @name NULL
setGeneric("md5", function(x) { standardGeneric("md5") })
+#' @rdname column_aggregate_functions¥
Review comment:
Could you remove the trailing yen mark?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34258: [SPARK-36976][R] Add max_by/min_by API to SparkR
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34258:
URL: https://github.com/apache/spark/pull/34258#issuecomment-940908349
**[Test build #144148 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144148/testReport)** for PR 34258 at commit [`15cc6ea`](https://github.com/apache/spark/commit/15cc6ea674047411ce5f1ea618a3a4f2c243fdcb).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #34258: [SPARK-36976][R] Add max_by/min_by API to SparkR
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #34258:
URL: https://github.com/apache/spark/pull/34258
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34258: [SPARK-36976][R] Add max_by/min_by API to SparkR
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34258:
URL: https://github.com/apache/spark/pull/34258#issuecomment-941048812
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48625/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34258: [SPARK-36976][R] Add max_by/min_by API to SparkR
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34258:
URL: https://github.com/apache/spark/pull/34258#issuecomment-941877241
**[Test build #144176 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144176/testReport)** for PR 34258 at commit [`7a02c0c`](https://github.com/apache/spark/commit/7a02c0c1a45c0aa9457144d45310b07f60435efa).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34258: [SPARK-36976][R] Add max_by/min_by API to SparkR
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34258:
URL: https://github.com/apache/spark/pull/34258#issuecomment-941891979
**[Test build #144176 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144176/testReport)** for PR 34258 at commit [`7a02c0c`](https://github.com/apache/spark/commit/7a02c0c1a45c0aa9457144d45310b07f60435efa).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #34258: [SPARK-36976][R] Add max_by/min_by API to SparkR
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #34258:
URL: https://github.com/apache/spark/pull/34258#discussion_r727609655
##########
File path: R/pkg/R/functions.R
##########
@@ -1479,6 +1479,19 @@ setMethod("max",
column(jc)
})
+#' @details
+#' \code{max_by}: Returns the value associated with the maximum value of ord.
+#'
+#' @rdname column_aggregate_functions
+#' @aliases max_by max_by,Column-method
+#' @note max_by since 3.3.0
Review comment:
can we add a short example with donotrun? e.g.) https://github.com/apache/spark/blob/15cc6ea674047411ce5f1ea618a3a4f2c243fdcb/R/pkg/R/functions.R#L194-L201
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #34258: [SPARK-36976][R] Add max_by/min_by API to SparkR
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #34258:
URL: https://github.com/apache/spark/pull/34258#issuecomment-941795252
I think the AppVeyor failure is irrelevant to this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34258: [SPARK-36976][R] Add max_by/min_by API to SparkR
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34258:
URL: https://github.com/apache/spark/pull/34258#issuecomment-941928031
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48654/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34258: [SPARK-36976][R] Add max_by/min_by API to SparkR
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34258:
URL: https://github.com/apache/spark/pull/34258#issuecomment-941877241
**[Test build #144176 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144176/testReport)** for PR 34258 at commit [`7a02c0c`](https://github.com/apache/spark/commit/7a02c0c1a45c0aa9457144d45310b07f60435efa).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34258: [SPARK-36976][R] Add max_by/min_by API to SparkR
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34258:
URL: https://github.com/apache/spark/pull/34258#issuecomment-941962233
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #34258: [SPARK-36976][R] Add max_by/min_by API to SparkR
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #34258:
URL: https://github.com/apache/spark/pull/34258#issuecomment-941795252
I think the AppVeyor failure is irrelevant to this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yoda-mon commented on pull request #34258: [SPARK-36976][R] Add max_by/min_by API to SparkR
Posted by GitBox <gi...@apache.org>.
yoda-mon commented on pull request #34258:
URL: https://github.com/apache/spark/pull/34258#issuecomment-941859953
Example screenshot
<img width="1407" alt="Screen Shot 2021-10-13 at 11 33 52" src="https://user-images.githubusercontent.com/14937752/137057217-464ba580-1fdb-4bf5-a2d5-2a1007fede63.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34258: [SPARK-36976][R] Add max_by/min_by API to SparkR
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34258:
URL: https://github.com/apache/spark/pull/34258#issuecomment-941894399
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48654/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34258: [SPARK-36976][R] Add max_by/min_by API to SparkR
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34258:
URL: https://github.com/apache/spark/pull/34258#issuecomment-941901967
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #34258: [SPARK-36976][R] Add max_by/min_by API to SparkR
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #34258:
URL: https://github.com/apache/spark/pull/34258#discussion_r727609837
##########
File path: R/pkg/R/generics.R
##########
@@ -1190,10 +1190,18 @@ setGeneric("map_values", function(x) { standardGeneric("map_values") })
#' @name NULL
setGeneric("map_zip_with", function(x, y, f) { standardGeneric("map_zip_with") })
+#' @rdname column_aggregate_functions
+#' @name NULL
+setGeneric("max_by", function(x, y) { standardGeneric("max_by") })
+
#' @rdname column_misc_functions
#' @name NULL
setGeneric("md5", function(x) { standardGeneric("md5") })
+#' @rdname column_aggregate_functions¥
Review comment:
Could you remove the trailing yen mark?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34258: [SPARK-36976][R] Add max_by/min_by API to SparkR
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34258:
URL: https://github.com/apache/spark/pull/34258#issuecomment-941795943
Yeah, it's not related.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34258: [SPARK-36976][R] Add max_by/min_by API to SparkR
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34258:
URL: https://github.com/apache/spark/pull/34258#issuecomment-941877241
**[Test build #144176 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144176/testReport)** for PR 34258 at commit [`7a02c0c`](https://github.com/apache/spark/commit/7a02c0c1a45c0aa9457144d45310b07f60435efa).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34258: [SPARK-36976][R] Add max_by/min_by API to SparkR
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34258:
URL: https://github.com/apache/spark/pull/34258#issuecomment-940951702
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144148/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #34258: [SPARK-36976][R] Add max_by/min_by API to SparkR
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #34258:
URL: https://github.com/apache/spark/pull/34258#discussion_r727609655
##########
File path: R/pkg/R/functions.R
##########
@@ -1479,6 +1479,19 @@ setMethod("max",
column(jc)
})
+#' @details
+#' \code{max_by}: Returns the value associated with the maximum value of ord.
+#'
+#' @rdname column_aggregate_functions
+#' @aliases max_by max_by,Column-method
+#' @note max_by since 3.3.0
Review comment:
can we add a short example with donotrun? e.g.) https://github.com/apache/spark/blob/15cc6ea674047411ce5f1ea618a3a4f2c243fdcb/R/pkg/R/functions.R#L194-L201
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34258: [SPARK-36976][R] Add max_by/min_by API to SparkR
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34258:
URL: https://github.com/apache/spark/pull/34258#issuecomment-941795943
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34258: [SPARK-36976][R] Add max_by/min_by API to SparkR
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34258:
URL: https://github.com/apache/spark/pull/34258#issuecomment-940908349
**[Test build #144148 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144148/testReport)** for PR 34258 at commit [`15cc6ea`](https://github.com/apache/spark/commit/15cc6ea674047411ce5f1ea618a3a4f2c243fdcb).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34258: [SPARK-36976][R] Add max_by/min_by API to SparkR
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34258:
URL: https://github.com/apache/spark/pull/34258#issuecomment-941928031
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48654/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34258: [SPARK-36976][R] Add max_by/min_by API to SparkR
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34258:
URL: https://github.com/apache/spark/pull/34258#issuecomment-941048812
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48625/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34258: [SPARK-36976][R] Add max_by/min_by API to SparkR
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34258:
URL: https://github.com/apache/spark/pull/34258#issuecomment-941901967
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144176/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34258: [SPARK-36976][R] Add max_by/min_by API to SparkR
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34258:
URL: https://github.com/apache/spark/pull/34258#issuecomment-941877241
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yoda-mon edited a comment on pull request #34258: [SPARK-36976][R] Add max_by/min_by API to SparkR
Posted by GitBox <gi...@apache.org>.
yoda-mon edited a comment on pull request #34258:
URL: https://github.com/apache/spark/pull/34258#issuecomment-941859953
Example screenshot (Edited: after fixing indent)
<img width="1269" alt="Screen Shot 2021-10-13 at 11 42 33" src="https://user-images.githubusercontent.com/14937752/137057959-af4e008a-9d0f-4050-ac48-af3d39e07a44.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34258: [SPARK-36976][R] Add max_by/min_by API to SparkR
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34258:
URL: https://github.com/apache/spark/pull/34258#issuecomment-940985702
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48625/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34258: [SPARK-36976][R] Add max_by/min_by API to SparkR
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34258:
URL: https://github.com/apache/spark/pull/34258#issuecomment-940951702
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144148/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34258: [SPARK-36976][R] Add max_by/min_by API to SparkR
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34258:
URL: https://github.com/apache/spark/pull/34258#issuecomment-941921093
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48654/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org