You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "ammachado (via GitHub)" <gi...@apache.org> on 2026/05/27 14:24:54 UTC
[PR] CAMEL-22894: Extract jq/jsonpath/xpath/simpleJsonpath Simple functions into QueryLanguageFunctionFactory [camel]
ammachado opened a new pull request, #23566:
URL: https://github.com/apache/camel/pull/23566
# Description
Continues the [CAMEL-22894](https://issues.apache.org/jira/browse/CAMEL-22894) series of `SimpleFunctionExpression` refactoring.
This PR extracts the four embedded-language functions (`jq`, `jsonpath`, `xpath`, `simpleJsonpath`) that previously lived inline in `SimpleFunctionExpression.createSimpleCustomLanguage()` into a new dedicated `QueryLanguageFunctionFactory`. The factory is registered in `SimpleFunctionDispatcher.BUILT_INS` alongside the factories introduced in the prior PRs (#23263, #23382, #23388, #23432, #23445, #23544).
Also fixes a minor dead-code issue noted in the #23544 review: `PropertiesFunctionFactory.createCode()` had a `parts.length > 2` guard that can never be true because the preceding `split(":", 2)` call limits the result to at most 2 elements.
`SimpleFunctionExpression` is now ~664 lines, down from the original 3,713.
_Claude Code on behalf of Adriano Machado_
# Target
- [x] I checked that the commit is targeting the correct branch (Camel 4 uses the `main` branch)
# Tracking
- [x] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
# Apache Camel coding standards and style
- [x] I checked that each commit in the pull request has a meaningful subject line and body.
- [x] I have run `mvn clean install -DskipTests` locally from root folder and I have committed all auto-generated changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-22894: Extract jq/jsonpath/xpath/simpleJsonpath Simple functions into QueryLanguageFunctionFactory [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23566:
URL: https://github.com/apache/camel/pull/23566#issuecomment-4555612460
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
* You can label PRs using `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
:warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-22894: Extract jq/jsonpath/xpath/simpleJsonpath Simple functions into QueryLanguageFunctionFactory [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23566:
URL: https://github.com/apache/camel/pull/23566#issuecomment-4555960887
<!-- ci-tested-modules -->
:test_tube: **CI tested the following changed modules:**
- `core/camel-core-languages`
- `core/camel-core`
> :information_source: Dependent modules were not tested because the total number of affected modules exceeded the threshold (50). Use the `test-dependents` label to force testing all dependents.
:warning: **Some tests are disabled on GitHub Actions** (`@DisabledIfSystemProperty(named = "ci.env.name")`) and require manual verification:
- `core/camel-core`: 2 test(s) disabled on GitHub Actions
<details><summary>Build reactor — dependencies compiled but only changed modules were tested (2 modules)</summary>
- Camel :: Core
- Camel :: Core Languages
</details>
---
:gear: [View full build and test results](https://github.com/apache/camel/actions/runs/26517357848)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-22894: Extract jq/jsonpath/xpath/simpleJsonpath Simple functions into QueryLanguageFunctionFactory [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #23566:
URL: https://github.com/apache/camel/pull/23566
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org