[GitHub] [trafficserver] shinrich opened a new pull request #7580: Refine connection failure logging and messages and eliminate spurious connection errors

[GitBox <gi...@apache.org>]

shinrich opened a new pull request #7580:
URL: https://github.com/apache/trafficserver/pull/7580


   These are changes I made working with @djcarlin to clean up our error messages on connection failures.  These changes are in a build that we are rolling out.  Currently running in a couple pods.
   
   The problem was that messages in errors.log about connection closing were confusing and in some cases missing information. One issue is that the HttpSM had two pieces of information that were tracking the reason for a connection failure (t_state.current.server->connect_result and t_state.cause_of_death_errno), and they weren't always being set consistently. This PR uses an updated version of set_connect_fail() to set them both consistently.
   
   The PR also changes the logic of setting those values.  The original would set EIO if nothing else was set.  The PR sets EIO and clears it on success.  Later calls to set_connect_fail will override the EIO..
   
   The PR also attempts to make the SQUID log codes more detailed in the case of connection failure.
   
   Finally, the PR adjusts the logs to error.log. There was one failure path that was not logging, so I added HttpTransact::error_log_connection_failure. and called that from both locations.  Also added an error.log entry for the DNS failure case.
   
   I see that there are some changes in HttpTunnel and Http2Stream which seem unrelated.  I just wrote quite a lot here, so I'll go ahead and set up the PR and push up another commit to eliminate those changes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] zwoop commented on pull request #7580: Refine connection failure logging and messages and eliminate spurious connection errors

[GitBox <gi...@apache.org>]

zwoop commented on pull request #7580:
URL: https://github.com/apache/trafficserver/pull/7580#issuecomment-817208012


   Cherry-picked to v9.1.x branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] shinrich merged pull request #7580: Refine connection failure logging and messages and eliminate spurious connection errors

[GitBox <gi...@apache.org>]

shinrich merged pull request #7580:
URL: https://github.com/apache/trafficserver/pull/7580


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org