You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@grails.apache.org by "codeconsole (via GitHub)" <gi...@apache.org> on 2026/08/25 19:21:31 UTC
[PR] Reuse the active web request during async dispatch [grails-core]
codeconsole opened a new pull request, #16226:
URL: https://github.com/apache/grails-core/pull/16226
A callback attached while the container is dispatching an async result must not start a second async cycle. Reuse the active AsyncGrailsWebRequest instead, preserving request decoration and leaving completed or inconsistent requests as visible failures.
Always clear the thread-bound GrailsWebRequest when a container has recycled the servlet request, and log the failed attribute cleanup at warning level.
Cover both paths through WebPromises and WebUtils public APIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Reuse the active web request during async dispatch [grails-core]
Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #16226:
URL: https://github.com/apache/grails-core/pull/16226#issuecomment-5417635764
## ✅ All tests passed ✅
🏷️ Commit: e7d24d802e671ee1aa3057e6a6a90bde64a3906e
▶️ Tests: 80379 executed
⚪️ Checks: 92/92 completed
---
_Learn more about TestLens at [testlens.app/docs](https://testlens.app/docs/features/pr-comment/)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Reuse the active web request during async dispatch [grails-core]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty commented on PR #16226:
URL: https://github.com/apache/grails-core/pull/16226#issuecomment-5416586936
@codeconsole since the original PR is what is referenced on the mailing list, I'd rather keep it in case people look for it later. Can we work off the original one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Reuse the active web request during async dispatch [grails-core]
Posted by "codeconsole (via GitHub)" <gi...@apache.org>.
codeconsole closed pull request #16226: Reuse the active web request during async dispatch
URL: https://github.com/apache/grails-core/pull/16226
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Reuse the active web request during async dispatch [grails-core]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #16226:
URL: https://github.com/apache/grails-core/pull/16226#issuecomment-5416997895
## [Codecov](https://app.codecov.io/gh/apache/grails-core/pull/16226?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `82.35294%` with `3 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 54.1525%. Comparing base ([`27b6097`](https://app.codecov.io/gh/apache/grails-core/commit/27b60974896e6716a3ac0fbb05870f75b4f23a59?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e7d24d8`](https://app.codecov.io/gh/apache/grails-core/commit/e7d24d802e671ee1aa3057e6a6a90bde64a3906e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/grails-core/pull/16226?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...s/web/async/AsyncWebRequestPromiseDecorator.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16226?src=pr&el=tree&filepath=grails-async%2Fplugin%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fplugins%2Fweb%2Fasync%2FAsyncWebRequestPromiseDecorator.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWFzeW5jL3BsdWdpbi9zcmMvbWFpbi9ncm9vdnkvb3JnL2dyYWlscy9wbHVnaW5zL3dlYi9hc3luYy9Bc3luY1dlYlJlcXVlc3RQcm9taXNlRGVjb3JhdG9yLmdyb292eQ==) | 81.2500% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16226?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/grails-core/pull/16226?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## 8.0.x #16226 +/- ##
==================================================
+ Coverage 54.1129% 54.1525% +0.0397%
- Complexity 20301 20311 +10
==================================================
Files 2107 2107
Lines 101146 101131 -15
Branches 17922 17920 -2
==================================================
+ Hits 54733 54765 +32
+ Misses 38605 38555 -50
- Partials 7808 7811 +3
```
| [Files with missing lines](https://app.codecov.io/gh/apache/grails-core/pull/16226?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...yncWebRequestPromiseDecoratorLookupStrategy.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16226?src=pr&el=tree&filepath=grails-async%2Fplugin%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fplugins%2Fweb%2Fasync%2FAsyncWebRequestPromiseDecoratorLookupStrategy.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWFzeW5jL3BsdWdpbi9zcmMvbWFpbi9ncm9vdnkvb3JnL2dyYWlscy9wbHVnaW5zL3dlYi9hc3luYy9Bc3luY1dlYlJlcXVlc3RQcm9taXNlRGVjb3JhdG9yTG9va3VwU3RyYXRlZ3kuZ3Jvb3Z5) | `100.0000% <100.0000%> (+25.0000%)` | :arrow_up: |
| [.../src/main/groovy/org/grails/web/util/WebUtils.java](https://app.codecov.io/gh/apache/grails-core/pull/16226?src=pr&el=tree&filepath=grails-web-common%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Futil%2FWebUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXdlYi1jb21tb24vc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL3V0aWwvV2ViVXRpbHMuamF2YQ==) | `33.7423% <ø> (+0.2057%)` | :arrow_up: |
| [...s/web/async/AsyncWebRequestPromiseDecorator.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16226?src=pr&el=tree&filepath=grails-async%2Fplugin%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fplugins%2Fweb%2Fasync%2FAsyncWebRequestPromiseDecorator.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWFzeW5jL3BsdWdpbi9zcmMvbWFpbi9ncm9vdnkvb3JnL2dyYWlscy9wbHVnaW5zL3dlYi9hc3luYy9Bc3luY1dlYlJlcXVlc3RQcm9taXNlRGVjb3JhdG9yLmdyb292eQ==) | `75.6098% <81.2500%> (+55.6098%)` | :arrow_up: |
... and [5 files with indirect coverage changes](https://app.codecov.io/gh/apache/grails-core/pull/16226/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org