You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Fanoid (via GitHub)" <gi...@apache.org> on 2023/02/13 06:19:57 UTC

[GitHub] [flink-ml] Fanoid opened a new pull request, #211: [FLINK-31026] Fix KBinsDiscretizer when the input values of one column are same

Fanoid opened a new pull request, #211:
URL: https://github.com/apache/flink-ml/pull/211

   ## What is the purpose of the change
   
   KBinsDiscretizer produces `{Double.MIN_VALUE, Double.MAX_VALUE}` for columns whose input values are same which is not correct, as it doesn't cover negative values and 0. A more reasonable value should be `{Double.NEGATIVE_INFINITY, Double.POSITIVE_INFINITY}`.
   
   ## Brief change log
   
     - Change bin edges for columns whose input values are same to `{Double.NEGATIVE_INFINITY, Double.POSITIVE_INFINITY}`.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-ml] zhipeng93 commented on pull request #211: [FLINK-31026] Fix KBinsDiscretizer when the input values of one column are same

Posted by "zhipeng93 (via GitHub)" <gi...@apache.org>.
zhipeng93 commented on PR #211:
URL: https://github.com/apache/flink-ml/pull/211#issuecomment-1432951288

   Thanks for the fix. LGTM.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-ml] zhipeng93 merged pull request #211: [FLINK-31026] Fix KBinsDiscretizer when the input values of one column are same

Posted by "zhipeng93 (via GitHub)" <gi...@apache.org>.
zhipeng93 merged PR #211:
URL: https://github.com/apache/flink-ml/pull/211


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-ml] Fanoid commented on pull request #211: [FLINK-31026] Fix KBinsDiscretizer when the input values of one column are same

Posted by "Fanoid (via GitHub)" <gi...@apache.org>.
Fanoid commented on PR #211:
URL: https://github.com/apache/flink-ml/pull/211#issuecomment-1432637635

   Hi, @zhipeng93 could you help review this commit?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org