You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/04/19 17:53:16 UTC
[GitHub] [spark] MaxGekk opened a new pull request #28261:
[SPARK-31489][SQL] Fix pushing down filters with `java.time.LocalDate`
values in ORC
MaxGekk opened a new pull request #28261: [SPARK-31489][SQL] Fix pushing down filters with `java.time.LocalDate` values in ORC
URL: https://github.com/apache/spark/pull/28261
### What changes were proposed in this pull request?
Convert `java.time.LocalDate` to `java.sql.Date` in pushed down filters to ORC datasource when Java 8 time API enabled.
### Why are the changes needed?
The changes fix the exception raised while pushing date filters when `spark.sql.datetime.java8API.enabled` is set to `true`:
```
Wrong value class java.time.LocalDate for DATE.EQUALS leaf
java.lang.IllegalArgumentException: Wrong value class java.time.LocalDate for DATE.EQUALS leaf
at org.apache.hadoop.hive.ql.io.sarg.SearchArgumentImpl$PredicateLeafImpl.checkLiteralType(SearchArgumentImpl.java:192)
at org.apache.hadoop.hive.ql.io.sarg.SearchArgumentImpl$PredicateLeafImpl.<init>(SearchArgumentImpl.java:75)
at org.apache.hadoop.hive.ql.io.sarg.SearchArgumentImpl$BuilderImpl.equals(SearchArgumentImpl.java:352)
at org.apache.spark.sql.execution.datasources.orc.OrcFilters$.buildLeafSearchArgument(OrcFilters.scala:229)
```
### Does this PR introduce any user-facing change?
Yes
### How was this patch tested?
Added tests to `OrcFilterSuite`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28261: [SPARK-31489][SQL] Fix
pushing down filters with `java.time.LocalDate` values in ORC
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28261: [SPARK-31489][SQL] Fix pushing down filters with `java.time.LocalDate` values in ORC
URL: https://github.com/apache/spark/pull/28261#issuecomment-616195644
**[Test build #121482 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121482/testReport)** for PR 28261 at commit [`392c0e6`](https://github.com/apache/spark/commit/392c0e66c53364ccbfaa0e49ebd8051780cd2bd1).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28261: [SPARK-31489][SQL]
Fix pushing down filters with `java.time.LocalDate` values in ORC
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28261: [SPARK-31489][SQL] Fix pushing down filters with `java.time.LocalDate` values in ORC
URL: https://github.com/apache/spark/pull/28261#issuecomment-616195864
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26166/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28261: [SPARK-31489][SQL]
Fix pushing down filters with `java.time.LocalDate` values in ORC
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28261: [SPARK-31489][SQL] Fix pushing down filters with `java.time.LocalDate` values in ORC
URL: https://github.com/apache/spark/pull/28261#issuecomment-616210205
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28261: [SPARK-31489][SQL]
Fix pushing down filters with `java.time.LocalDate` values in ORC
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28261: [SPARK-31489][SQL] Fix pushing down filters with `java.time.LocalDate` values in ORC
URL: https://github.com/apache/spark/pull/28261#issuecomment-616214005
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28261:
[SPARK-31489][SQL] Fix pushing down filters with `java.time.LocalDate`
values in ORC
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28261: [SPARK-31489][SQL] Fix pushing down filters with `java.time.LocalDate` values in ORC
URL: https://github.com/apache/spark/pull/28261#issuecomment-616214010
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26169/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28261:
[SPARK-31489][SQL] Fix pushing down filters with `java.time.LocalDate`
values in ORC
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28261: [SPARK-31489][SQL] Fix pushing down filters with `java.time.LocalDate` values in ORC
URL: https://github.com/apache/spark/pull/28261#issuecomment-616195864
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26166/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28261:
[SPARK-31489][SQL] Fix pushing down filters with `java.time.LocalDate`
values in ORC
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28261: [SPARK-31489][SQL] Fix pushing down filters with `java.time.LocalDate` values in ORC
URL: https://github.com/apache/spark/pull/28261#issuecomment-616210205
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28261: [SPARK-31489][SQL]
Fix pushing down filters with `java.time.LocalDate` values in ORC
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28261: [SPARK-31489][SQL] Fix pushing down filters with `java.time.LocalDate` values in ORC
URL: https://github.com/apache/spark/pull/28261#issuecomment-616195859
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28261:
[SPARK-31489][SQL] Fix pushing down filters with `java.time.LocalDate`
values in ORC
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28261: [SPARK-31489][SQL] Fix pushing down filters with `java.time.LocalDate` values in ORC
URL: https://github.com/apache/spark/pull/28261#issuecomment-616195644
**[Test build #121482 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121482/testReport)** for PR 28261 at commit [`392c0e6`](https://github.com/apache/spark/commit/392c0e66c53364ccbfaa0e49ebd8051780cd2bd1).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28261: [SPARK-31489][SQL]
Fix pushing down filters with `java.time.LocalDate` values in ORC
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28261: [SPARK-31489][SQL] Fix pushing down filters with `java.time.LocalDate` values in ORC
URL: https://github.com/apache/spark/pull/28261#issuecomment-616210208
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121482/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28261:
[SPARK-31489][SQL] Fix pushing down filters with `java.time.LocalDate`
values in ORC
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28261: [SPARK-31489][SQL] Fix pushing down filters with `java.time.LocalDate` values in ORC
URL: https://github.com/apache/spark/pull/28261#issuecomment-616210208
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121482/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28261:
[SPARK-31489][SQL] Fix pushing down filters with `java.time.LocalDate`
values in ORC
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28261: [SPARK-31489][SQL] Fix pushing down filters with `java.time.LocalDate` values in ORC
URL: https://github.com/apache/spark/pull/28261#issuecomment-616214005
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28261: [SPARK-31489][SQL]
Fix pushing down filters with `java.time.LocalDate` values in ORC
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28261: [SPARK-31489][SQL] Fix pushing down filters with `java.time.LocalDate` values in ORC
URL: https://github.com/apache/spark/pull/28261#issuecomment-616214010
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26169/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28261: [SPARK-31489][SQL] Fix
pushing down filters with `java.time.LocalDate` values in ORC
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28261: [SPARK-31489][SQL] Fix pushing down filters with `java.time.LocalDate` values in ORC
URL: https://github.com/apache/spark/pull/28261#issuecomment-616210170
**[Test build #121482 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121482/testReport)** for PR 28261 at commit [`392c0e6`](https://github.com/apache/spark/commit/392c0e66c53364ccbfaa0e49ebd8051780cd2bd1).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28261: [SPARK-31489][SQL] Fix
pushing down filters with `java.time.LocalDate` values in ORC
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28261: [SPARK-31489][SQL] Fix pushing down filters with `java.time.LocalDate` values in ORC
URL: https://github.com/apache/spark/pull/28261#issuecomment-616213854
**[Test build #121485 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121485/testReport)** for PR 28261 at commit [`392c0e6`](https://github.com/apache/spark/commit/392c0e66c53364ccbfaa0e49ebd8051780cd2bd1).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28261:
[SPARK-31489][SQL] Fix pushing down filters with `java.time.LocalDate`
values in ORC
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28261: [SPARK-31489][SQL] Fix pushing down filters with `java.time.LocalDate` values in ORC
URL: https://github.com/apache/spark/pull/28261#issuecomment-616195859
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on issue #28261: [SPARK-31489][SQL] Fix
pushing down filters with `java.time.LocalDate` values in ORC
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on issue #28261: [SPARK-31489][SQL] Fix pushing down filters with `java.time.LocalDate` values in ORC
URL: https://github.com/apache/spark/pull/28261#issuecomment-616213206
jenkins, retest this, please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org