You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/02/24 01:43:46 UTC
[GitHub] [incubator-doris] dataroaring opened a new pull request #8219: fix mempool ut problem introduced by this patch
dataroaring opened a new pull request #8219:
URL: https://github.com/apache/incubator-doris/pull/8219
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
The mempool ut is broken by padding with asan enabled, now the ut works only with asan enabled, I will submit a patch making it work with asan disabled later.
## Checklist(Required)
1. Does it affect the original behavior: (No)
2. Has unit tests been added: (No)
3. Has document been added or modified: (No)
4. Does it need to update dependencies: (No)
5. Are there any changes that cannot be rolled back: (No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #8219: fix mempool ut problem introduced by this patch
Posted by GitBox <gi...@apache.org>.
morningman commented on pull request #8219:
URL: https://github.com/apache/incubator-doris/pull/8219#issuecomment-1050532785
has been fixed in #8216 ,close this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #8219: fix mempool ut problem introduced by this patch
Posted by GitBox <gi...@apache.org>.
morningman commented on pull request #8219:
URL: https://github.com/apache/incubator-doris/pull/8219#issuecomment-1049420438
hi @dataroaring , 2 issues:
1. you need to rebase the trunk to resolve the conflict.
2. I plan to merge your PR to #8216 to fix all UT in on PR, do you agree?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman closed pull request #8219: fix mempool ut problem introduced by this patch
Posted by GitBox <gi...@apache.org>.
morningman closed pull request #8219:
URL: https://github.com/apache/incubator-doris/pull/8219
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org