You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Pengyu Nie (Jira)" <ji...@apache.org> on 2019/11/29 17:14:00 UTC

[jira] [Created] (COLLECTIONS-738) The last assertNull in IterableUtilsTest.find is redundant

Pengyu Nie created COLLECTIONS-738:
--------------------------------------

             Summary: The last assertNull in IterableUtilsTest.find is redundant
                 Key: COLLECTIONS-738
                 URL: https://issues.apache.org/jira/browse/COLLECTIONS-738
             Project: Commons Collections
          Issue Type: Test
          Components: Iterator
            Reporter: Pengyu Nie


The last assertNull in IterableUtilsTest.find (line 277, as shown
 below), is redundant and confusing; it will not be invoked because
 IterableUtils.find(*, null) should not return any value but just throw
 NullPointerException. I will make a PR to clarify this.
{code:java}
try {
    assertNull(IterableUtils.find(iterableA, null));
    fail("expecting NullPointerException");
} catch (final NullPointerException npe) {
    // expected
}
{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)