You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/06 17:16:25 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #2471: Minor: Use ExprVisitor to find columns referenced by expr
alamb opened a new pull request, #2471:
URL: https://github.com/apache/arrow-datafusion/pull/2471
# Which issue does this PR close?
re https://github.com/apache/arrow-datafusion/pull/2464
# Rationale for this change
I noticed some code that duplicates Expr tree walking, and rewrote it to use ExprVisitor
# What changes are included in this PR?
Rewrite `find_columns_referenced_by_expr` from https://github.com/apache/arrow-datafusion/pull/2464
# Are there any user-facing changes?
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #2471: Minor: Use ExprVisitor to find columns referenced by expr
Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #2471:
URL: https://github.com/apache/arrow-datafusion/pull/2471#discussion_r867025445
##########
datafusion/expr/src/expr.rs:
##########
@@ -251,77 +251,6 @@ pub enum Expr {
QualifiedWildcard { qualifier: String },
}
-/// Recursively find all columns referenced by an expression
-pub fn find_columns_referenced_by_expr(e: &Expr) -> Vec<Column> {
Review Comment:
it is less code, but it also avoids potential issues in missing a sub expr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #2471: Minor: Use ExprVisitor to find columns referenced by expr
Posted by GitBox <gi...@apache.org>.
alamb merged PR #2471:
URL: https://github.com/apache/arrow-datafusion/pull/2471
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org