(datafusion-python) branch main updated: fix: remove todo from indexed field key (#1667)

[ti...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

timsaucer pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/datafusion-python.git


The following commit(s) were added to refs/heads/main by this push:
     new 41eadc40 fix: remove todo from indexed field key (#1667)
41eadc40 is described below

commit 41eadc401c5182887da7bf3c201d03eafd8b0b57
Author: BharatDeva <bh...@gmail.com>
AuthorDate: Mon Sep 14 12:35:35 2026 -0500

    fix: remove todo from indexed field key (#1667)
    
    Co-authored-by: BharatDeva <27...@users.noreply.github.com>
---
 crates/core/src/expr/indexed_field.rs | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/crates/core/src/expr/indexed_field.rs b/crates/core/src/expr/indexed_field.rs
index 98a90d8d..c980b0f9 100644
--- a/crates/core/src/expr/indexed_field.rs
+++ b/crates/core/src/expr/indexed_field.rs
@@ -21,6 +21,7 @@ use datafusion::logical_expr::expr::{GetFieldAccess, GetIndexedField};
 use pyo3::prelude::*;
 
 use super::literal::PyLiteral;
+use crate::errors::py_unsupported_variant_err;
 use crate::expr::PyExpr;
 
 #[pyclass(
@@ -68,7 +69,9 @@ impl PyGetIndexedField {
     fn key(&self) -> PyResult<PyLiteral> {
         match &self.indexed_field.field {
             GetFieldAccess::NamedStructField { name, .. } => Ok(name.clone().into()),
-            _ => todo!(),
+            GetFieldAccess::ListIndex { .. } | GetFieldAccess::ListRange { .. } => Err(
+                py_unsupported_variant_err("GetIndexedField.key is only supported for struct fields"),
+            ),
         }
     }
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org
For additional commands, e-mail: commits-help@datafusion.apache.org