You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/06/29 04:03:19 UTC
[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #7101: Add `PinotHelixResourceManager` to `TableConfigTuner.init()` method.
Jackie-Jiang commented on a change in pull request #7101:
URL: https://github.com/apache/incubator-pinot/pull/7101#discussion_r660263784
##########
File path: pinot-controller/src/main/java/org/apache/pinot/controller/tuner/TableConfigTuner.java
##########
@@ -27,11 +29,18 @@
* Interface for Table Config Tuner.
*/
public interface TableConfigTuner {
+ /**
+ *
+ */
/**
* Used to initialize underlying implementation with Schema
* and custom properties (eg: metrics end point)
+ *
+ * @param pinotHelixResourceManager Pinot Helix Resource Manager to access Helix resources
+ * @param tunerConfig Tuner configurations
+ * @param schema Table schema
*/
- void init(TunerConfig props, Schema schema);
+ void init(@Nullable PinotHelixResourceManager pinotHelixResourceManager, TunerConfig tunerConfig, Schema schema);
Review comment:
Is the resource manager nullable? If it’s nullable just for the tests, we should rather mock it
##########
File path: pinot-controller/src/main/java/org/apache/pinot/controller/tuner/TableConfigTuner.java
##########
@@ -27,11 +29,18 @@
* Interface for Table Config Tuner.
*/
public interface TableConfigTuner {
+ /**
+ *
+ */
/**
* Used to initialize underlying implementation with Schema
* and custom properties (eg: metrics end point)
+ *
+ * @param pinotHelixResourceManager Pinot Helix Resource Manager to access Helix resources
+ * @param tunerConfig Tuner configurations
+ * @param schema Table schema
*/
- void init(TunerConfig props, Schema schema);
+ void init(@Nullable PinotHelixResourceManager pinotHelixResourceManager, TunerConfig tunerConfig, Schema schema);
Review comment:
With resource manager passed in, not sure if we still need the schema
##########
File path: pinot-controller/src/main/java/org/apache/pinot/controller/tuner/TableConfigTuner.java
##########
@@ -27,11 +29,18 @@
* Interface for Table Config Tuner.
*/
public interface TableConfigTuner {
+ /**
Review comment:
Revert
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org