You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Joe Smith <ya...@gmail.com> on 2014/02/21 01:05:40 UTC
Review Request 18334: Move and unit test Maintenance module and commands
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18334/
-----------------------------------------------------------
Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Brian Wickman.
Bugs: AURORA-223
https://issues.apache.org/jira/browse/AURORA-223
Repository: aurora
Description
-------
As always, feel free to tear it apart.
I plan to add tests for the other commands as well, but wanted to get this out sooner than later to ensure others agreed with my approach.
Diffs
-----
src/main/python/apache/aurora/admin/BUILD 480dad69d8122168a6b7222ef9df0eb689fae386
src/main/python/apache/aurora/admin/mesos_maintenance.py d8ffdec062db07ce82556fb38ff4a5eea7921953
src/main/python/apache/aurora/client/base.py c5c969f9641c8e0e1604648b1f9ed542ab59b7d0
src/main/python/apache/aurora/client/bin/BUILD dbabfd0e56288d04c399e20976ea6e0287112d91
src/main/python/apache/aurora/client/commands/BUILD 14bbdd4d0cb0e8e5102e75baef4e8b34d98967c0
src/main/python/apache/aurora/client/commands/admin.py 45686aec8d69f0dfa1d649a92a19ca87bd315823
src/main/python/apache/aurora/client/commands/maintenance.py PRE-CREATION
src/test/python/apache/aurora/admin/BUILD 258b1eb58a4eec1650bfd317823f76a30889f912
src/test/python/apache/aurora/admin/test_mesos_maintenance.py 000fbe5a873669bf55a9110f1aa6f1d7c8350ef8
src/test/python/apache/aurora/client/commands/BUILD 02c27aa513d60ef901f446c56cbfc0d891445e30
src/test/python/apache/aurora/client/commands/test_maintenance.py PRE-CREATION
Diff: https://reviews.apache.org/r/18334/diff/
Testing
-------
./pants ./src/test/python/apache/aurora:all
particularly:
src.test.python.apache.aurora.client.commands.maintenance ..... SUCCESS
Thanks,
Joe Smith
Re: Review Request 18334: Move and unit test Maintenance module and commands
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18334/#review35152
-----------------------------------------------------------
Ship it!
Ship It!
- Mark Chu-Carroll
On Feb. 20, 2014, 7:05 p.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18334/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2014, 7:05 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Brian Wickman.
>
>
> Bugs: AURORA-223
> https://issues.apache.org/jira/browse/AURORA-223
>
>
> Repository: aurora
>
>
> Description
> -------
>
> As always, feel free to tear it apart.
>
> I plan to add tests for the other commands as well, but wanted to get this out sooner than later to ensure others agreed with my approach.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/BUILD 480dad69d8122168a6b7222ef9df0eb689fae386
> src/main/python/apache/aurora/admin/mesos_maintenance.py d8ffdec062db07ce82556fb38ff4a5eea7921953
> src/main/python/apache/aurora/client/base.py c5c969f9641c8e0e1604648b1f9ed542ab59b7d0
> src/main/python/apache/aurora/client/bin/BUILD dbabfd0e56288d04c399e20976ea6e0287112d91
> src/main/python/apache/aurora/client/commands/BUILD 14bbdd4d0cb0e8e5102e75baef4e8b34d98967c0
> src/main/python/apache/aurora/client/commands/admin.py 45686aec8d69f0dfa1d649a92a19ca87bd315823
> src/main/python/apache/aurora/client/commands/maintenance.py PRE-CREATION
> src/test/python/apache/aurora/admin/BUILD 258b1eb58a4eec1650bfd317823f76a30889f912
> src/test/python/apache/aurora/admin/test_mesos_maintenance.py 000fbe5a873669bf55a9110f1aa6f1d7c8350ef8
> src/test/python/apache/aurora/client/commands/BUILD 02c27aa513d60ef901f446c56cbfc0d891445e30
> src/test/python/apache/aurora/client/commands/test_maintenance.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18334/diff/
>
>
> Testing
> -------
>
> ./pants ./src/test/python/apache/aurora:all
>
> particularly:
>
> src.test.python.apache.aurora.client.commands.maintenance ..... SUCCESS
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 18334: Move and unit test Maintenance module and commands
Posted by Joe Smith <ya...@gmail.com>.
> On Feb. 21, 2014, 9:43 a.m., Brian Wickman wrote:
> > src/main/python/apache/aurora/client/base.py, lines 43-44
> > <https://reviews.apache.org/r/18334/diff/1/?file=499595#file499595line43>
> >
> > ?
fixed, thx.
> On Feb. 21, 2014, 9:43 a.m., Brian Wickman wrote:
> > src/main/python/apache/aurora/client/commands/maintenance.py, lines 24-25
> > <https://reviews.apache.org/r/18334/diff/1/?file=499599#file499599line24>
> >
> > nope
wow.
> On Feb. 21, 2014, 9:43 a.m., Brian Wickman wrote:
> > src/test/python/apache/aurora/client/commands/test_maintenance.py, lines 23-28
> > <https://reviews.apache.org/r/18334/diff/1/?file=499603#file499603line23>
> >
> > indent 4 and have trailing comma on the last import (in case we add imports and want to re-sort.)
done, thanks!
> On Feb. 21, 2014, 9:43 a.m., Brian Wickman wrote:
> > src/test/python/apache/aurora/client/commands/test_maintenance.py, line 41
> > <https://reviews.apache.org/r/18334/diff/1/?file=499603#file499603line41>
> >
> > be consistent with ' and ". we usually use '
done
> On Feb. 21, 2014, 9:43 a.m., Brian Wickman wrote:
> > src/test/python/apache/aurora/client/commands/test_maintenance.py, line 47
> > <https://reviews.apache.org/r/18334/diff/1/?file=499603#file499603line47>
> >
> > no ws after [ and before ]
gotcha.
> On Feb. 21, 2014, 9:43 a.m., Brian Wickman wrote:
> > src/test/python/apache/aurora/client/commands/test_maintenance.py, line 49
> > <https://reviews.apache.org/r/18334/diff/1/?file=499603#file499603line49>
> >
> > kill nl
done.
- Joe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18334/#review35160
-----------------------------------------------------------
On Feb. 20, 2014, 4:05 p.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18334/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2014, 4:05 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Brian Wickman.
>
>
> Bugs: AURORA-223
> https://issues.apache.org/jira/browse/AURORA-223
>
>
> Repository: aurora
>
>
> Description
> -------
>
> As always, feel free to tear it apart.
>
> I plan to add tests for the other commands as well, but wanted to get this out sooner than later to ensure others agreed with my approach.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/BUILD 480dad69d8122168a6b7222ef9df0eb689fae386
> src/main/python/apache/aurora/admin/mesos_maintenance.py d8ffdec062db07ce82556fb38ff4a5eea7921953
> src/main/python/apache/aurora/client/base.py c5c969f9641c8e0e1604648b1f9ed542ab59b7d0
> src/main/python/apache/aurora/client/bin/BUILD dbabfd0e56288d04c399e20976ea6e0287112d91
> src/main/python/apache/aurora/client/commands/BUILD 14bbdd4d0cb0e8e5102e75baef4e8b34d98967c0
> src/main/python/apache/aurora/client/commands/admin.py 45686aec8d69f0dfa1d649a92a19ca87bd315823
> src/main/python/apache/aurora/client/commands/maintenance.py PRE-CREATION
> src/test/python/apache/aurora/admin/BUILD 258b1eb58a4eec1650bfd317823f76a30889f912
> src/test/python/apache/aurora/admin/test_mesos_maintenance.py 000fbe5a873669bf55a9110f1aa6f1d7c8350ef8
> src/test/python/apache/aurora/client/commands/BUILD 02c27aa513d60ef901f446c56cbfc0d891445e30
> src/test/python/apache/aurora/client/commands/test_maintenance.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18334/diff/
>
>
> Testing
> -------
>
> ./pants ./src/test/python/apache/aurora:all
>
> particularly:
>
> src.test.python.apache.aurora.client.commands.maintenance ..... SUCCESS
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 18334: Move and unit test Maintenance module and commands
Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18334/#review35160
-----------------------------------------------------------
code lgtm, just a few cleanups.
src/main/python/apache/aurora/client/base.py
<https://reviews.apache.org/r/18334/#comment65568>
?
src/main/python/apache/aurora/client/commands/maintenance.py
<https://reviews.apache.org/r/18334/#comment65570>
nope
src/test/python/apache/aurora/client/commands/test_maintenance.py
<https://reviews.apache.org/r/18334/#comment65575>
indent 4 and have trailing comma on the last import (in case we add imports and want to re-sort.)
src/test/python/apache/aurora/client/commands/test_maintenance.py
<https://reviews.apache.org/r/18334/#comment65574>
be consistent with ' and ". we usually use '
src/test/python/apache/aurora/client/commands/test_maintenance.py
<https://reviews.apache.org/r/18334/#comment65576>
no ws after [ and before ]
src/test/python/apache/aurora/client/commands/test_maintenance.py
<https://reviews.apache.org/r/18334/#comment65577>
kill nl
- Brian Wickman
On Feb. 21, 2014, 12:05 a.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18334/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2014, 12:05 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Brian Wickman.
>
>
> Bugs: AURORA-223
> https://issues.apache.org/jira/browse/AURORA-223
>
>
> Repository: aurora
>
>
> Description
> -------
>
> As always, feel free to tear it apart.
>
> I plan to add tests for the other commands as well, but wanted to get this out sooner than later to ensure others agreed with my approach.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/BUILD 480dad69d8122168a6b7222ef9df0eb689fae386
> src/main/python/apache/aurora/admin/mesos_maintenance.py d8ffdec062db07ce82556fb38ff4a5eea7921953
> src/main/python/apache/aurora/client/base.py c5c969f9641c8e0e1604648b1f9ed542ab59b7d0
> src/main/python/apache/aurora/client/bin/BUILD dbabfd0e56288d04c399e20976ea6e0287112d91
> src/main/python/apache/aurora/client/commands/BUILD 14bbdd4d0cb0e8e5102e75baef4e8b34d98967c0
> src/main/python/apache/aurora/client/commands/admin.py 45686aec8d69f0dfa1d649a92a19ca87bd315823
> src/main/python/apache/aurora/client/commands/maintenance.py PRE-CREATION
> src/test/python/apache/aurora/admin/BUILD 258b1eb58a4eec1650bfd317823f76a30889f912
> src/test/python/apache/aurora/admin/test_mesos_maintenance.py 000fbe5a873669bf55a9110f1aa6f1d7c8350ef8
> src/test/python/apache/aurora/client/commands/BUILD 02c27aa513d60ef901f446c56cbfc0d891445e30
> src/test/python/apache/aurora/client/commands/test_maintenance.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18334/diff/
>
>
> Testing
> -------
>
> ./pants ./src/test/python/apache/aurora:all
>
> particularly:
>
> src.test.python.apache.aurora.client.commands.maintenance ..... SUCCESS
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 18334: Move and unit test Maintenance module and commands
Posted by Joe Smith <ya...@gmail.com>.
> On Feb. 24, 2014, 9:35 a.m., Brian Wickman wrote:
> > src/main/python/apache/aurora/client/base.py, lines 43-44
> > <https://reviews.apache.org/r/18334/diff/1/?file=499595#file499595line43>
> >
> > still here?
Hm.... this is pretty awkward, I'm ~95% sure I don't have those lines in my repo.
- Joe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18334/#review35301
-----------------------------------------------------------
On Feb. 24, 2014, 10:19 a.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18334/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2014, 10:19 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Brian Wickman.
>
>
> Bugs: AURORA-223
> https://issues.apache.org/jira/browse/AURORA-223
>
>
> Repository: aurora
>
>
> Description
> -------
>
> As always, feel free to tear it apart.
>
> I plan to add tests for the other commands as well, but wanted to get this out sooner than later to ensure others agreed with my approach.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/BUILD 480dad69d8122168a6b7222ef9df0eb689fae386
> src/main/python/apache/aurora/admin/mesos_maintenance.py d8ffdec062db07ce82556fb38ff4a5eea7921953
> src/main/python/apache/aurora/client/bin/BUILD dbabfd0e56288d04c399e20976ea6e0287112d91
> src/main/python/apache/aurora/client/commands/BUILD 14bbdd4d0cb0e8e5102e75baef4e8b34d98967c0
> src/main/python/apache/aurora/client/commands/admin.py 989c5b625b48fe67ef1297ceda8d7e35cb8ead7e
> src/main/python/apache/aurora/client/commands/maintenance.py PRE-CREATION
> src/test/python/apache/aurora/admin/BUILD 258b1eb58a4eec1650bfd317823f76a30889f912
> src/test/python/apache/aurora/admin/test_mesos_maintenance.py 000fbe5a873669bf55a9110f1aa6f1d7c8350ef8
> src/test/python/apache/aurora/client/commands/BUILD 6d448d7320a78bf140873b743805846c179281a7
> src/test/python/apache/aurora/client/commands/test_maintenance.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18334/diff/
>
>
> Testing
> -------
>
> ./pants ./src/test/python/apache/aurora:all
>
> particularly:
>
> src.test.python.apache.aurora.client.commands.maintenance ..... SUCCESS
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 18334: Move and unit test Maintenance module and commands
Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18334/#review35301
-----------------------------------------------------------
src/main/python/apache/aurora/client/base.py
<https://reviews.apache.org/r/18334/#comment65765>
still here?
- Brian Wickman
On Feb. 24, 2014, 7:13 a.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18334/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2014, 7:13 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Brian Wickman.
>
>
> Bugs: AURORA-223
> https://issues.apache.org/jira/browse/AURORA-223
>
>
> Repository: aurora
>
>
> Description
> -------
>
> As always, feel free to tear it apart.
>
> I plan to add tests for the other commands as well, but wanted to get this out sooner than later to ensure others agreed with my approach.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/BUILD 480dad69d8122168a6b7222ef9df0eb689fae386
> src/main/python/apache/aurora/admin/mesos_maintenance.py d8ffdec062db07ce82556fb38ff4a5eea7921953
> src/main/python/apache/aurora/client/bin/BUILD dbabfd0e56288d04c399e20976ea6e0287112d91
> src/main/python/apache/aurora/client/commands/BUILD 14bbdd4d0cb0e8e5102e75baef4e8b34d98967c0
> src/main/python/apache/aurora/client/commands/admin.py 989c5b625b48fe67ef1297ceda8d7e35cb8ead7e
> src/main/python/apache/aurora/client/commands/maintenance.py PRE-CREATION
> src/test/python/apache/aurora/admin/BUILD 258b1eb58a4eec1650bfd317823f76a30889f912
> src/test/python/apache/aurora/admin/test_mesos_maintenance.py 000fbe5a873669bf55a9110f1aa6f1d7c8350ef8
> src/test/python/apache/aurora/client/commands/BUILD 6d448d7320a78bf140873b743805846c179281a7
> src/test/python/apache/aurora/client/commands/test_maintenance.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18334/diff/
>
>
> Testing
> -------
>
> ./pants ./src/test/python/apache/aurora:all
>
> particularly:
>
> src.test.python.apache.aurora.client.commands.maintenance ..... SUCCESS
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 18334: Move and unit test Maintenance module and commands
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18334/#review36270
-----------------------------------------------------------
Ship it!
src/main/python/apache/aurora/client/commands/maintenance.py
<https://reviews.apache.org/r/18334/#comment67227>
Please, move FILENAME and HOSTS options into base.py closer to its parser for everyone to benefit.
- Maxim Khutornenko
On March 4, 2014, 2:50 a.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18334/
> -----------------------------------------------------------
>
> (Updated March 4, 2014, 2:50 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, Maxim Khutornenko, and Brian Wickman.
>
>
> Bugs: AURORA-223
> https://issues.apache.org/jira/browse/AURORA-223
>
>
> Repository: aurora
>
>
> Description
> -------
>
> As always, feel free to tear it apart.
>
> I plan to add tests for the other commands as well, but wanted to get this out sooner than later to ensure others agreed with my approach.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/BUILD 480dad69d8122168a6b7222ef9df0eb689fae386
> src/main/python/apache/aurora/admin/mesos_maintenance.py d8ffdec062db07ce82556fb38ff4a5eea7921953
> src/main/python/apache/aurora/client/base.py c5c969f9641c8e0e1604648b1f9ed542ab59b7d0
> src/main/python/apache/aurora/client/bin/BUILD dbabfd0e56288d04c399e20976ea6e0287112d91
> src/main/python/apache/aurora/client/commands/BUILD 14bbdd4d0cb0e8e5102e75baef4e8b34d98967c0
> src/main/python/apache/aurora/client/commands/admin.py 40588e23f5082604af9f474e9cf6ab84663b8d67
> src/main/python/apache/aurora/client/commands/maintenance.py PRE-CREATION
> src/test/python/apache/aurora/admin/BUILD 258b1eb58a4eec1650bfd317823f76a30889f912
> src/test/python/apache/aurora/admin/test_mesos_maintenance.py 000fbe5a873669bf55a9110f1aa6f1d7c8350ef8
> src/test/python/apache/aurora/client/commands/BUILD 6d448d7320a78bf140873b743805846c179281a7
> src/test/python/apache/aurora/client/commands/test_maintenance.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18334/diff/
>
>
> Testing
> -------
>
> ./pants ./src/test/python/apache/aurora:all
>
> particularly:
>
> src.test.python.apache.aurora.client.commands.maintenance ..... SUCCESS
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 18334: Move and unit test Maintenance module and commands
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18334/#review36593
-----------------------------------------------------------
Ship it!
Ship It!
- Maxim Khutornenko
On March 8, 2014, 1:20 a.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18334/
> -----------------------------------------------------------
>
> (Updated March 8, 2014, 1:20 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, Maxim Khutornenko, and Brian Wickman.
>
>
> Bugs: AURORA-223
> https://issues.apache.org/jira/browse/AURORA-223
>
>
> Repository: aurora
>
>
> Description
> -------
>
> As always, feel free to tear it apart.
>
> I plan to add tests for the other commands as well, but wanted to get this out sooner than later to ensure others agreed with my approach.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/BUILD 480dad69d8122168a6b7222ef9df0eb689fae386
> src/main/python/apache/aurora/admin/mesos_maintenance.py d8ffdec062db07ce82556fb38ff4a5eea7921953
> src/main/python/apache/aurora/client/base.py c5c969f9641c8e0e1604648b1f9ed542ab59b7d0
> src/main/python/apache/aurora/client/bin/BUILD dbabfd0e56288d04c399e20976ea6e0287112d91
> src/main/python/apache/aurora/client/commands/BUILD 14bbdd4d0cb0e8e5102e75baef4e8b34d98967c0
> src/main/python/apache/aurora/client/commands/admin.py d6f571bec5325f7ab538a7dd9389d9f98d01134a
> src/main/python/apache/aurora/client/commands/maintenance.py PRE-CREATION
> src/test/python/apache/aurora/admin/BUILD 258b1eb58a4eec1650bfd317823f76a30889f912
> src/test/python/apache/aurora/admin/test_mesos_maintenance.py 000fbe5a873669bf55a9110f1aa6f1d7c8350ef8
> src/test/python/apache/aurora/client/commands/BUILD 6d448d7320a78bf140873b743805846c179281a7
> src/test/python/apache/aurora/client/commands/test_maintenance.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18334/diff/
>
>
> Testing
> -------
>
> ./pants ./src/test/python/apache/aurora:all
>
> particularly:
>
> src.test.python.apache.aurora.client.commands.maintenance ..... SUCCESS
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 18334: Move and unit test Maintenance module and commands
Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18334/
-----------------------------------------------------------
(Updated March 7, 2014, 5:20 p.m.)
Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, Maxim Khutornenko, and Brian Wickman.
Changes
-------
Maxim- if you can give one last review then ship this, that'd be rad.
Bugs: AURORA-223
https://issues.apache.org/jira/browse/AURORA-223
Repository: aurora
Description
-------
As always, feel free to tear it apart.
I plan to add tests for the other commands as well, but wanted to get this out sooner than later to ensure others agreed with my approach.
Diffs (updated)
-----
src/main/python/apache/aurora/admin/BUILD 480dad69d8122168a6b7222ef9df0eb689fae386
src/main/python/apache/aurora/admin/mesos_maintenance.py d8ffdec062db07ce82556fb38ff4a5eea7921953
src/main/python/apache/aurora/client/base.py c5c969f9641c8e0e1604648b1f9ed542ab59b7d0
src/main/python/apache/aurora/client/bin/BUILD dbabfd0e56288d04c399e20976ea6e0287112d91
src/main/python/apache/aurora/client/commands/BUILD 14bbdd4d0cb0e8e5102e75baef4e8b34d98967c0
src/main/python/apache/aurora/client/commands/admin.py d6f571bec5325f7ab538a7dd9389d9f98d01134a
src/main/python/apache/aurora/client/commands/maintenance.py PRE-CREATION
src/test/python/apache/aurora/admin/BUILD 258b1eb58a4eec1650bfd317823f76a30889f912
src/test/python/apache/aurora/admin/test_mesos_maintenance.py 000fbe5a873669bf55a9110f1aa6f1d7c8350ef8
src/test/python/apache/aurora/client/commands/BUILD 6d448d7320a78bf140873b743805846c179281a7
src/test/python/apache/aurora/client/commands/test_maintenance.py PRE-CREATION
Diff: https://reviews.apache.org/r/18334/diff/
Testing
-------
./pants ./src/test/python/apache/aurora:all
particularly:
src.test.python.apache.aurora.client.commands.maintenance ..... SUCCESS
Thanks,
Joe Smith
Re: Review Request 18334: Move and unit test Maintenance module and commands
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18334/#review36556
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Sweeney
On March 7, 2014, 10:37 a.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18334/
> -----------------------------------------------------------
>
> (Updated March 7, 2014, 10:37 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, Maxim Khutornenko, and Brian Wickman.
>
>
> Bugs: AURORA-223
> https://issues.apache.org/jira/browse/AURORA-223
>
>
> Repository: aurora
>
>
> Description
> -------
>
> As always, feel free to tear it apart.
>
> I plan to add tests for the other commands as well, but wanted to get this out sooner than later to ensure others agreed with my approach.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/BUILD 480dad69d8122168a6b7222ef9df0eb689fae386
> src/main/python/apache/aurora/admin/mesos_maintenance.py d8ffdec062db07ce82556fb38ff4a5eea7921953
> src/main/python/apache/aurora/client/base.py c5c969f9641c8e0e1604648b1f9ed542ab59b7d0
> src/main/python/apache/aurora/client/bin/BUILD dbabfd0e56288d04c399e20976ea6e0287112d91
> src/main/python/apache/aurora/client/commands/BUILD 14bbdd4d0cb0e8e5102e75baef4e8b34d98967c0
> src/main/python/apache/aurora/client/commands/admin.py 40588e23f5082604af9f474e9cf6ab84663b8d67
> src/main/python/apache/aurora/client/commands/maintenance.py PRE-CREATION
> src/test/python/apache/aurora/admin/BUILD 258b1eb58a4eec1650bfd317823f76a30889f912
> src/test/python/apache/aurora/admin/test_mesos_maintenance.py 000fbe5a873669bf55a9110f1aa6f1d7c8350ef8
> src/test/python/apache/aurora/client/commands/BUILD 6d448d7320a78bf140873b743805846c179281a7
> src/test/python/apache/aurora/client/commands/test_maintenance.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18334/diff/
>
>
> Testing
> -------
>
> ./pants ./src/test/python/apache/aurora:all
>
> particularly:
>
> src.test.python.apache.aurora.client.commands.maintenance ..... SUCCESS
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 18334: Move and unit test Maintenance module and commands
Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18334/
-----------------------------------------------------------
(Updated March 7, 2014, 10:37 a.m.)
Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, Maxim Khutornenko, and Brian Wickman.
Changes
-------
Addressed Maxim's suggestion, and added a mock_sleep assertion + TODO for possible refactoring via Kevin's suggestion
Bugs: AURORA-223
https://issues.apache.org/jira/browse/AURORA-223
Repository: aurora
Description
-------
As always, feel free to tear it apart.
I plan to add tests for the other commands as well, but wanted to get this out sooner than later to ensure others agreed with my approach.
Diffs (updated)
-----
src/main/python/apache/aurora/admin/BUILD 480dad69d8122168a6b7222ef9df0eb689fae386
src/main/python/apache/aurora/admin/mesos_maintenance.py d8ffdec062db07ce82556fb38ff4a5eea7921953
src/main/python/apache/aurora/client/base.py c5c969f9641c8e0e1604648b1f9ed542ab59b7d0
src/main/python/apache/aurora/client/bin/BUILD dbabfd0e56288d04c399e20976ea6e0287112d91
src/main/python/apache/aurora/client/commands/BUILD 14bbdd4d0cb0e8e5102e75baef4e8b34d98967c0
src/main/python/apache/aurora/client/commands/admin.py 40588e23f5082604af9f474e9cf6ab84663b8d67
src/main/python/apache/aurora/client/commands/maintenance.py PRE-CREATION
src/test/python/apache/aurora/admin/BUILD 258b1eb58a4eec1650bfd317823f76a30889f912
src/test/python/apache/aurora/admin/test_mesos_maintenance.py 000fbe5a873669bf55a9110f1aa6f1d7c8350ef8
src/test/python/apache/aurora/client/commands/BUILD 6d448d7320a78bf140873b743805846c179281a7
src/test/python/apache/aurora/client/commands/test_maintenance.py PRE-CREATION
Diff: https://reviews.apache.org/r/18334/diff/
Testing
-------
./pants ./src/test/python/apache/aurora:all
particularly:
src.test.python.apache.aurora.client.commands.maintenance ..... SUCCESS
Thanks,
Joe Smith
Re: Review Request 18334: Move and unit test Maintenance module and commands
Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18334/
-----------------------------------------------------------
(Updated March 3, 2014, 6:50 p.m.)
Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, Maxim Khutornenko, and Brian Wickman.
Changes
-------
Updated, and also adding maxim as we've been dabbling in aurora_admin together (and I'm moving parse_hosts to base)
Bugs: AURORA-223
https://issues.apache.org/jira/browse/AURORA-223
Repository: aurora
Description
-------
As always, feel free to tear it apart.
I plan to add tests for the other commands as well, but wanted to get this out sooner than later to ensure others agreed with my approach.
Diffs (updated)
-----
src/main/python/apache/aurora/admin/BUILD 480dad69d8122168a6b7222ef9df0eb689fae386
src/main/python/apache/aurora/admin/mesos_maintenance.py d8ffdec062db07ce82556fb38ff4a5eea7921953
src/main/python/apache/aurora/client/base.py c5c969f9641c8e0e1604648b1f9ed542ab59b7d0
src/main/python/apache/aurora/client/bin/BUILD dbabfd0e56288d04c399e20976ea6e0287112d91
src/main/python/apache/aurora/client/commands/BUILD 14bbdd4d0cb0e8e5102e75baef4e8b34d98967c0
src/main/python/apache/aurora/client/commands/admin.py 40588e23f5082604af9f474e9cf6ab84663b8d67
src/main/python/apache/aurora/client/commands/maintenance.py PRE-CREATION
src/test/python/apache/aurora/admin/BUILD 258b1eb58a4eec1650bfd317823f76a30889f912
src/test/python/apache/aurora/admin/test_mesos_maintenance.py 000fbe5a873669bf55a9110f1aa6f1d7c8350ef8
src/test/python/apache/aurora/client/commands/BUILD 6d448d7320a78bf140873b743805846c179281a7
src/test/python/apache/aurora/client/commands/test_maintenance.py PRE-CREATION
Diff: https://reviews.apache.org/r/18334/diff/
Testing
-------
./pants ./src/test/python/apache/aurora:all
particularly:
src.test.python.apache.aurora.client.commands.maintenance ..... SUCCESS
Thanks,
Joe Smith
Re: Review Request 18334: Move and unit test Maintenance module and commands
Posted by Kevin Sweeney <ke...@apache.org>.
> On Feb. 24, 2014, 6:36 p.m., Kevin Sweeney wrote:
> > src/test/python/apache/aurora/client/commands/test_maintenance.py, line 136
> > <https://reviews.apache.org/r/18334/diff/3/?file=502376#file502376line136>
> >
> > Not sure how I feel about this style of mock - I'd prefer the class under test to explicitly call out "I'm using system time" to avoid missed mock coverage causing the test suite to slow down.
>
> Joe Smith wrote:
> hm.. any chance you have suggestions on how to pass this through? I'd prefer not to add it to the command line itself, I think
The clock=time pattern is more explicit to me since it's called out in production code. In the test you can pass clock=mock_time.
- Kevin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18334/#review35362
-----------------------------------------------------------
On March 3, 2014, 6:50 p.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18334/
> -----------------------------------------------------------
>
> (Updated March 3, 2014, 6:50 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, Maxim Khutornenko, and Brian Wickman.
>
>
> Bugs: AURORA-223
> https://issues.apache.org/jira/browse/AURORA-223
>
>
> Repository: aurora
>
>
> Description
> -------
>
> As always, feel free to tear it apart.
>
> I plan to add tests for the other commands as well, but wanted to get this out sooner than later to ensure others agreed with my approach.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/BUILD 480dad69d8122168a6b7222ef9df0eb689fae386
> src/main/python/apache/aurora/admin/mesos_maintenance.py d8ffdec062db07ce82556fb38ff4a5eea7921953
> src/main/python/apache/aurora/client/base.py c5c969f9641c8e0e1604648b1f9ed542ab59b7d0
> src/main/python/apache/aurora/client/bin/BUILD dbabfd0e56288d04c399e20976ea6e0287112d91
> src/main/python/apache/aurora/client/commands/BUILD 14bbdd4d0cb0e8e5102e75baef4e8b34d98967c0
> src/main/python/apache/aurora/client/commands/admin.py 40588e23f5082604af9f474e9cf6ab84663b8d67
> src/main/python/apache/aurora/client/commands/maintenance.py PRE-CREATION
> src/test/python/apache/aurora/admin/BUILD 258b1eb58a4eec1650bfd317823f76a30889f912
> src/test/python/apache/aurora/admin/test_mesos_maintenance.py 000fbe5a873669bf55a9110f1aa6f1d7c8350ef8
> src/test/python/apache/aurora/client/commands/BUILD 6d448d7320a78bf140873b743805846c179281a7
> src/test/python/apache/aurora/client/commands/test_maintenance.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18334/diff/
>
>
> Testing
> -------
>
> ./pants ./src/test/python/apache/aurora:all
>
> particularly:
>
> src.test.python.apache.aurora.client.commands.maintenance ..... SUCCESS
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 18334: Move and unit test Maintenance module and commands
Posted by Joe Smith <ya...@gmail.com>.
> On Feb. 24, 2014, 6:36 p.m., Kevin Sweeney wrote:
> > src/test/python/apache/aurora/client/commands/test_maintenance.py, line 136
> > <https://reviews.apache.org/r/18334/diff/3/?file=502376#file502376line136>
> >
> > Not sure how I feel about this style of mock - I'd prefer the class under test to explicitly call out "I'm using system time" to avoid missed mock coverage causing the test suite to slow down.
>
> Joe Smith wrote:
> hm.. any chance you have suggestions on how to pass this through? I'd prefer not to add it to the command line itself, I think
>
> Kevin Sweeney wrote:
> The clock=time pattern is more explicit to me since it's called out in production code. In the test you can pass clock=mock_time.
ah, perhaps this is an interesting code smell then, as this is actually testing the command-line itself, which calls the library method (that has the clock=time parameter). I'm not sure how to go from this test (which is passing in app options) to the mock clock (maybe adding in a mock_clock=True option..?)
- Joe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18334/#review35362
-----------------------------------------------------------
On March 3, 2014, 6:50 p.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18334/
> -----------------------------------------------------------
>
> (Updated March 3, 2014, 6:50 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, Maxim Khutornenko, and Brian Wickman.
>
>
> Bugs: AURORA-223
> https://issues.apache.org/jira/browse/AURORA-223
>
>
> Repository: aurora
>
>
> Description
> -------
>
> As always, feel free to tear it apart.
>
> I plan to add tests for the other commands as well, but wanted to get this out sooner than later to ensure others agreed with my approach.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/BUILD 480dad69d8122168a6b7222ef9df0eb689fae386
> src/main/python/apache/aurora/admin/mesos_maintenance.py d8ffdec062db07ce82556fb38ff4a5eea7921953
> src/main/python/apache/aurora/client/base.py c5c969f9641c8e0e1604648b1f9ed542ab59b7d0
> src/main/python/apache/aurora/client/bin/BUILD dbabfd0e56288d04c399e20976ea6e0287112d91
> src/main/python/apache/aurora/client/commands/BUILD 14bbdd4d0cb0e8e5102e75baef4e8b34d98967c0
> src/main/python/apache/aurora/client/commands/admin.py 40588e23f5082604af9f474e9cf6ab84663b8d67
> src/main/python/apache/aurora/client/commands/maintenance.py PRE-CREATION
> src/test/python/apache/aurora/admin/BUILD 258b1eb58a4eec1650bfd317823f76a30889f912
> src/test/python/apache/aurora/admin/test_mesos_maintenance.py 000fbe5a873669bf55a9110f1aa6f1d7c8350ef8
> src/test/python/apache/aurora/client/commands/BUILD 6d448d7320a78bf140873b743805846c179281a7
> src/test/python/apache/aurora/client/commands/test_maintenance.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18334/diff/
>
>
> Testing
> -------
>
> ./pants ./src/test/python/apache/aurora:all
>
> particularly:
>
> src.test.python.apache.aurora.client.commands.maintenance ..... SUCCESS
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 18334: Move and unit test Maintenance module and commands
Posted by Joe Smith <ya...@gmail.com>.
> On Feb. 24, 2014, 6:36 p.m., Kevin Sweeney wrote:
> > src/main/python/apache/aurora/admin/mesos_maintenance.py, line 73
> > <https://reviews.apache.org/r/18334/diff/3/?file=502368#file502368line73>
> >
> > Inclined to revert this - better to explicitly call out a dependency on system time IMO.
done
> On Feb. 24, 2014, 6:36 p.m., Kevin Sweeney wrote:
> > src/main/python/apache/aurora/client/commands/maintenance.py, lines 53-56
> > <https://reviews.apache.org/r/18334/diff/3/?file=502372#file502372line53>
> >
> > DRY - these options are used multiple times. Consider factoring them as constants.
fixed
> On Feb. 24, 2014, 6:36 p.m., Kevin Sweeney wrote:
> > src/test/python/apache/aurora/client/commands/test_maintenance.py, line 43
> > <https://reviews.apache.org/r/18334/diff/3/?file=502376#file502376line43>
> >
> > make_mock_options would be more descriptive. also docstring is not informative, consider dropping it.
fixed
> On Feb. 24, 2014, 6:36 p.m., Kevin Sweeney wrote:
> > src/test/python/apache/aurora/client/commands/test_maintenance.py, line 88
> > <https://reviews.apache.org/r/18334/diff/3/?file=502376#file502376line88>
> >
> > parens aren't necessary
fixed
> On Feb. 24, 2014, 6:36 p.m., Kevin Sweeney wrote:
> > src/test/python/apache/aurora/client/commands/test_maintenance.py, line 103
> > <https://reviews.apache.org/r/18334/diff/3/?file=502376#file502376line103>
> >
> > parens not necessary
fixed
> On Feb. 24, 2014, 6:36 p.m., Kevin Sweeney wrote:
> > src/test/python/apache/aurora/client/commands/test_maintenance.py, line 129
> > <https://reviews.apache.org/r/18334/diff/3/?file=502376#file502376line129>
> >
> > no parens needed.
fixed
> On Feb. 24, 2014, 6:36 p.m., Kevin Sweeney wrote:
> > src/test/python/apache/aurora/client/commands/test_maintenance.py, line 136
> > <https://reviews.apache.org/r/18334/diff/3/?file=502376#file502376line136>
> >
> > Not sure how I feel about this style of mock - I'd prefer the class under test to explicitly call out "I'm using system time" to avoid missed mock coverage causing the test suite to slow down.
hm.. any chance you have suggestions on how to pass this through? I'd prefer not to add it to the command line itself, I think
- Joe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18334/#review35362
-----------------------------------------------------------
On Feb. 24, 2014, 10:19 a.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18334/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2014, 10:19 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Brian Wickman.
>
>
> Bugs: AURORA-223
> https://issues.apache.org/jira/browse/AURORA-223
>
>
> Repository: aurora
>
>
> Description
> -------
>
> As always, feel free to tear it apart.
>
> I plan to add tests for the other commands as well, but wanted to get this out sooner than later to ensure others agreed with my approach.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/BUILD 480dad69d8122168a6b7222ef9df0eb689fae386
> src/main/python/apache/aurora/admin/mesos_maintenance.py d8ffdec062db07ce82556fb38ff4a5eea7921953
> src/main/python/apache/aurora/client/bin/BUILD dbabfd0e56288d04c399e20976ea6e0287112d91
> src/main/python/apache/aurora/client/commands/BUILD 14bbdd4d0cb0e8e5102e75baef4e8b34d98967c0
> src/main/python/apache/aurora/client/commands/admin.py 989c5b625b48fe67ef1297ceda8d7e35cb8ead7e
> src/main/python/apache/aurora/client/commands/maintenance.py PRE-CREATION
> src/test/python/apache/aurora/admin/BUILD 258b1eb58a4eec1650bfd317823f76a30889f912
> src/test/python/apache/aurora/admin/test_mesos_maintenance.py 000fbe5a873669bf55a9110f1aa6f1d7c8350ef8
> src/test/python/apache/aurora/client/commands/BUILD 6d448d7320a78bf140873b743805846c179281a7
> src/test/python/apache/aurora/client/commands/test_maintenance.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18334/diff/
>
>
> Testing
> -------
>
> ./pants ./src/test/python/apache/aurora:all
>
> particularly:
>
> src.test.python.apache.aurora.client.commands.maintenance ..... SUCCESS
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 18334: Move and unit test Maintenance module and commands
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18334/#review35362
-----------------------------------------------------------
src/main/python/apache/aurora/admin/mesos_maintenance.py
<https://reviews.apache.org/r/18334/#comment65844>
Inclined to revert this - better to explicitly call out a dependency on system time IMO.
src/main/python/apache/aurora/client/commands/maintenance.py
<https://reviews.apache.org/r/18334/#comment65839>
DRY - these options are used multiple times. Consider factoring them as constants.
src/test/python/apache/aurora/client/commands/test_maintenance.py
<https://reviews.apache.org/r/18334/#comment65838>
make_mock_options would be more descriptive. also docstring is not informative, consider dropping it.
src/test/python/apache/aurora/client/commands/test_maintenance.py
<https://reviews.apache.org/r/18334/#comment65836>
parens aren't necessary
src/test/python/apache/aurora/client/commands/test_maintenance.py
<https://reviews.apache.org/r/18334/#comment65835>
parens not necessary
src/test/python/apache/aurora/client/commands/test_maintenance.py
<https://reviews.apache.org/r/18334/#comment65837>
no parens needed.
src/test/python/apache/aurora/client/commands/test_maintenance.py
<https://reviews.apache.org/r/18334/#comment65843>
Not sure how I feel about this style of mock - I'd prefer the class under test to explicitly call out "I'm using system time" to avoid missed mock coverage causing the test suite to slow down.
- Kevin Sweeney
On Feb. 24, 2014, 10:19 a.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18334/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2014, 10:19 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Brian Wickman.
>
>
> Bugs: AURORA-223
> https://issues.apache.org/jira/browse/AURORA-223
>
>
> Repository: aurora
>
>
> Description
> -------
>
> As always, feel free to tear it apart.
>
> I plan to add tests for the other commands as well, but wanted to get this out sooner than later to ensure others agreed with my approach.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/BUILD 480dad69d8122168a6b7222ef9df0eb689fae386
> src/main/python/apache/aurora/admin/mesos_maintenance.py d8ffdec062db07ce82556fb38ff4a5eea7921953
> src/main/python/apache/aurora/client/bin/BUILD dbabfd0e56288d04c399e20976ea6e0287112d91
> src/main/python/apache/aurora/client/commands/BUILD 14bbdd4d0cb0e8e5102e75baef4e8b34d98967c0
> src/main/python/apache/aurora/client/commands/admin.py 989c5b625b48fe67ef1297ceda8d7e35cb8ead7e
> src/main/python/apache/aurora/client/commands/maintenance.py PRE-CREATION
> src/test/python/apache/aurora/admin/BUILD 258b1eb58a4eec1650bfd317823f76a30889f912
> src/test/python/apache/aurora/admin/test_mesos_maintenance.py 000fbe5a873669bf55a9110f1aa6f1d7c8350ef8
> src/test/python/apache/aurora/client/commands/BUILD 6d448d7320a78bf140873b743805846c179281a7
> src/test/python/apache/aurora/client/commands/test_maintenance.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18334/diff/
>
>
> Testing
> -------
>
> ./pants ./src/test/python/apache/aurora:all
>
> particularly:
>
> src.test.python.apache.aurora.client.commands.maintenance ..... SUCCESS
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 18334: Move and unit test Maintenance module and commands
Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18334/#review35326
-----------------------------------------------------------
Ship it!
bizarre. i think this is an issue with reviewboard being on the fritz.
- Brian Wickman
On Feb. 24, 2014, 6:19 p.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18334/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2014, 6:19 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Brian Wickman.
>
>
> Bugs: AURORA-223
> https://issues.apache.org/jira/browse/AURORA-223
>
>
> Repository: aurora
>
>
> Description
> -------
>
> As always, feel free to tear it apart.
>
> I plan to add tests for the other commands as well, but wanted to get this out sooner than later to ensure others agreed with my approach.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/BUILD 480dad69d8122168a6b7222ef9df0eb689fae386
> src/main/python/apache/aurora/admin/mesos_maintenance.py d8ffdec062db07ce82556fb38ff4a5eea7921953
> src/main/python/apache/aurora/client/bin/BUILD dbabfd0e56288d04c399e20976ea6e0287112d91
> src/main/python/apache/aurora/client/commands/BUILD 14bbdd4d0cb0e8e5102e75baef4e8b34d98967c0
> src/main/python/apache/aurora/client/commands/admin.py 989c5b625b48fe67ef1297ceda8d7e35cb8ead7e
> src/main/python/apache/aurora/client/commands/maintenance.py PRE-CREATION
> src/test/python/apache/aurora/admin/BUILD 258b1eb58a4eec1650bfd317823f76a30889f912
> src/test/python/apache/aurora/admin/test_mesos_maintenance.py 000fbe5a873669bf55a9110f1aa6f1d7c8350ef8
> src/test/python/apache/aurora/client/commands/BUILD 6d448d7320a78bf140873b743805846c179281a7
> src/test/python/apache/aurora/client/commands/test_maintenance.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18334/diff/
>
>
> Testing
> -------
>
> ./pants ./src/test/python/apache/aurora:all
>
> particularly:
>
> src.test.python.apache.aurora.client.commands.maintenance ..... SUCCESS
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 18334: Move and unit test Maintenance module and commands
Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18334/
-----------------------------------------------------------
(Updated Feb. 24, 2014, 10:19 a.m.)
Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Brian Wickman.
Bugs: AURORA-223
https://issues.apache.org/jira/browse/AURORA-223
Repository: aurora
Description
-------
As always, feel free to tear it apart.
I plan to add tests for the other commands as well, but wanted to get this out sooner than later to ensure others agreed with my approach.
Diffs (updated)
-----
src/main/python/apache/aurora/admin/BUILD 480dad69d8122168a6b7222ef9df0eb689fae386
src/main/python/apache/aurora/admin/mesos_maintenance.py d8ffdec062db07ce82556fb38ff4a5eea7921953
src/main/python/apache/aurora/client/bin/BUILD dbabfd0e56288d04c399e20976ea6e0287112d91
src/main/python/apache/aurora/client/commands/BUILD 14bbdd4d0cb0e8e5102e75baef4e8b34d98967c0
src/main/python/apache/aurora/client/commands/admin.py 989c5b625b48fe67ef1297ceda8d7e35cb8ead7e
src/main/python/apache/aurora/client/commands/maintenance.py PRE-CREATION
src/test/python/apache/aurora/admin/BUILD 258b1eb58a4eec1650bfd317823f76a30889f912
src/test/python/apache/aurora/admin/test_mesos_maintenance.py 000fbe5a873669bf55a9110f1aa6f1d7c8350ef8
src/test/python/apache/aurora/client/commands/BUILD 6d448d7320a78bf140873b743805846c179281a7
src/test/python/apache/aurora/client/commands/test_maintenance.py PRE-CREATION
Diff: https://reviews.apache.org/r/18334/diff/
Testing
-------
./pants ./src/test/python/apache/aurora:all
particularly:
src.test.python.apache.aurora.client.commands.maintenance ..... SUCCESS
Thanks,
Joe Smith
Re: Review Request 18334: Move and unit test Maintenance module and commands
Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18334/
-----------------------------------------------------------
(Updated Feb. 23, 2014, 11:13 p.m.)
Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Brian Wickman.
Changes
-------
checkstyle and ./pants ./src/test/python/apache/aurora:all
Bugs: AURORA-223
https://issues.apache.org/jira/browse/AURORA-223
Repository: aurora
Description
-------
As always, feel free to tear it apart.
I plan to add tests for the other commands as well, but wanted to get this out sooner than later to ensure others agreed with my approach.
Diffs (updated)
-----
src/main/python/apache/aurora/admin/BUILD 480dad69d8122168a6b7222ef9df0eb689fae386
src/main/python/apache/aurora/admin/mesos_maintenance.py d8ffdec062db07ce82556fb38ff4a5eea7921953
src/main/python/apache/aurora/client/bin/BUILD dbabfd0e56288d04c399e20976ea6e0287112d91
src/main/python/apache/aurora/client/commands/BUILD 14bbdd4d0cb0e8e5102e75baef4e8b34d98967c0
src/main/python/apache/aurora/client/commands/admin.py 989c5b625b48fe67ef1297ceda8d7e35cb8ead7e
src/main/python/apache/aurora/client/commands/maintenance.py PRE-CREATION
src/test/python/apache/aurora/admin/BUILD 258b1eb58a4eec1650bfd317823f76a30889f912
src/test/python/apache/aurora/admin/test_mesos_maintenance.py 000fbe5a873669bf55a9110f1aa6f1d7c8350ef8
src/test/python/apache/aurora/client/commands/BUILD 6d448d7320a78bf140873b743805846c179281a7
src/test/python/apache/aurora/client/commands/test_maintenance.py PRE-CREATION
Diff: https://reviews.apache.org/r/18334/diff/
Testing
-------
./pants ./src/test/python/apache/aurora:all
particularly:
src.test.python.apache.aurora.client.commands.maintenance ..... SUCCESS
Thanks,
Joe Smith