You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/02/10 16:39:27 UTC

[GitHub] [geode] sabbey37 commented on a change in pull request #6019: GEODE-8933: update INFO to return maxmemory field

sabbey37 commented on a change in pull request #6019:
URL: https://github.com/apache/geode/pull/6019#discussion_r573881758



##########
File path: geode-redis/src/main/java/org/apache/geode/redis/internal/executor/server/InfoExecutor.java
##########
@@ -28,6 +28,8 @@
 
 public class InfoExecutor extends AbstractExecutor {
 
+  private static final Long ONE_MEGABYTE = 1024 * 1024 * 1024L;

Review comment:
       I think 1 MB is `1024L x 1024L`, or 1048576 bytes... not sure if I'm missing something here (assuming the intention is to convert MB to bytes)?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org