You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pivot.apache.org by sm...@apache.org on 2009/09/01 11:47:57 UTC

svn commit: r809941 - in /incubator/pivot/trunk/tools/src/org/apache/pivot/tools/net: HTTPClient.java Request.java Response.java

Author: smartini
Date: Tue Sep  1 09:47:57 2009
New Revision: 809941

URL: http://svn.apache.org/viewvc?rev=809941&view=rev
Log:
add some missing override, in some cases on methods of inner classes (not shown in eclipse warnings)

Modified:
    incubator/pivot/trunk/tools/src/org/apache/pivot/tools/net/HTTPClient.java
    incubator/pivot/trunk/tools/src/org/apache/pivot/tools/net/Request.java
    incubator/pivot/trunk/tools/src/org/apache/pivot/tools/net/Response.java

Modified: incubator/pivot/trunk/tools/src/org/apache/pivot/tools/net/HTTPClient.java
URL: http://svn.apache.org/viewvc/incubator/pivot/trunk/tools/src/org/apache/pivot/tools/net/HTTPClient.java?rev=809941&r1=809940&r2=809941&view=diff
==============================================================================
--- incubator/pivot/trunk/tools/src/org/apache/pivot/tools/net/HTTPClient.java (original)
+++ incubator/pivot/trunk/tools/src/org/apache/pivot/tools/net/HTTPClient.java Tue Sep  1 09:47:57 2009
@@ -90,6 +90,7 @@
      * Considers all SSL hostnames as valid (performs no actual verification).
      */
     private static class LenientHostnameVerifier implements HostnameVerifier {
+        @Override
         public boolean verify(String hostname, SSLSession session) {
             return true;
         }
@@ -155,12 +156,15 @@
 
     // Application methods
 
+    @Override
     public void startup(Display display, Map<String, String> properties) throws Exception {
         Action.getNamedActions().put("setAuthenticationAction", new Action() {
+            @Override
             public String getDescription() {
                 return "Specifies authentication credentials";
             }
 
+            @Override
             public void perform() {
                 final WTKXSerializer sheetSerializer = new WTKXSerializer();
                 final Sheet sheet;
@@ -173,6 +177,7 @@
 
                 Button okButton = (Button)sheetSerializer.get("okButton");
                 okButton.getButtonPressListeners().add(new ButtonPressListener() {
+                    @Override
                     public void buttonPressed(Button button) {
                         sheet.close(true);
                     }
@@ -180,6 +185,7 @@
 
                 Button cancelButton = (Button)sheetSerializer.get("cancelButton");
                 cancelButton.getButtonPressListeners().add(new ButtonPressListener() {
+                    @Override
                     public void buttonPressed(Button button) {
                         sheet.close(false);
                     }
@@ -193,6 +199,7 @@
                 }
 
                 sheet.getWindowStateListeners().add(new WindowStateListener.Adapter() {
+                    @Override
                     public void windowClosed(Window window, Display display) {
 
                     }
@@ -222,10 +229,12 @@
         });
 
         Action.getNamedActions().put("toggleHostnameVerificationAction", new Action() {
+            @Override
             public String getDescription() {
                 return "Toggles lenient hostname verification";
             }
 
+            @Override
             public void perform() {
                 lenientHostnameVerification = !lenientHostnameVerification;
             }
@@ -235,10 +244,12 @@
             private String keystorePath = null;
             private String keystorePassword = null;
 
+            @Override
             public String getDescription() {
                 return "Sets a trusted keystore";
             }
 
+            @Override
             public void perform() {
                 final WTKXSerializer sheetSerializer = new WTKXSerializer();
                 final Sheet sheet;
@@ -251,6 +262,7 @@
 
                 Button okButton = (Button)sheetSerializer.get("okButton");
                 okButton.getButtonPressListeners().add(new ButtonPressListener() {
+                    @Override
                     public void buttonPressed(Button button) {
                         sheet.close(true);
                     }
@@ -258,6 +270,7 @@
 
                 Button cancelButton = (Button)sheetSerializer.get("cancelButton");
                 cancelButton.getButtonPressListeners().add(new ButtonPressListener() {
+                    @Override
                     public void buttonPressed(Button button) {
                         sheet.close(false);
                     }
@@ -274,6 +287,7 @@
                 }
 
                 sheet.getSheetStateListeners().add(new SheetStateListener() {
+                    @Override
                     public Vote previewSheetClose(Sheet sheet, boolean result) {
                         Vote vote = Vote.APPROVE;
 
@@ -296,6 +310,7 @@
                         return vote;
                     }
 
+                    @Override
                     public void sheetCloseVetoed(Sheet sheet, Vote reaso) {
                         // No-op
                     }
@@ -320,6 +335,7 @@
 
         TableView tableView = (TableView)serializer.get("log.tableView");
         tableView.getComponentMouseButtonListeners().add(new ComponentMouseButtonListener.Adapter() {
+            @Override
             public boolean mouseClick(Component component, Mouse.Button button, int x, int y, int count) {
                 boolean consumed = false;
 
@@ -346,11 +362,13 @@
 
         PushButton submitButton = (PushButton)serializer.get("request.submit");
         submitButton.getButtonPressListeners().add(new ButtonPressListener() {
+            @Override
             public void buttonPressed(final Button button) {
                 button.setEnabled(false);
 
                 Request httpRequest = getRequest();
                 httpRequest.execute(new TaskAdapter<Response>(new TaskListener<Response>() {
+                    @Override
                     public void taskExecuted(Task<Response> task) {
                         button.setEnabled(true);
                         Response httpResponse = task.getResult();
@@ -361,6 +379,7 @@
                         tableData.add(transaction);
                     }
 
+                    @Override
                     public void executeFailed(Task<Response> task) {
                         button.setEnabled(true);
                         task.getFault().printStackTrace();
@@ -370,6 +389,7 @@
         });
     }
 
+    @Override
     public boolean shutdown(boolean optional) throws Exception {
         if (window != null) {
             window.close();
@@ -378,10 +398,12 @@
         return false;
     }
 
+    @Override
     public void suspend() throws Exception {
         // No-op
     }
 
+    @Override
     public void resume() throws Exception {
         // No-op
     }

Modified: incubator/pivot/trunk/tools/src/org/apache/pivot/tools/net/Request.java
URL: http://svn.apache.org/viewvc/incubator/pivot/trunk/tools/src/org/apache/pivot/tools/net/Request.java?rev=809941&r1=809940&r2=809941&view=diff
==============================================================================
--- incubator/pivot/trunk/tools/src/org/apache/pivot/tools/net/Request.java (original)
+++ incubator/pivot/trunk/tools/src/org/apache/pivot/tools/net/Request.java Tue Sep  1 09:47:57 2009
@@ -60,26 +60,32 @@
      */
     public final class RequestHeadersDictionary
         implements Dictionary<String, String>, Iterable<String> {
+        @Override
         public String get(String key) {
             return requestHeaders.get(key);
         }
 
+        @Override
         public String put(String key, String value) {
             return requestHeaders.put(key, value);
         }
 
+        @Override
         public String remove(String key) {
             return requestHeaders.remove(key);
         }
 
+        @Override
         public boolean containsKey(String key) {
             return requestHeaders.containsKey(key);
         }
 
+        @Override
         public boolean isEmpty() {
             return requestHeaders.isEmpty();
         }
 
+        @Override
         public Iterator<String> iterator() {
             return requestHeaders.iterator();
         }
@@ -100,24 +106,28 @@
             super.remove(listener);
         }
 
+        @Override
         public synchronized void connected(Request httpRequest) {
             for (RequestListener listener : this) {
                 listener.connected(httpRequest);
             }
         }
 
+        @Override
         public synchronized void requestSent(Request httpRequest) {
             for (RequestListener listener : this) {
                 listener.requestSent(httpRequest);
             }
         }
 
+        @Override
         public synchronized void responseReceived(Request httpRequest) {
             for (RequestListener listener : this) {
                 listener.responseReceived(httpRequest);
             }
         }
 
+        @Override
         public synchronized void failed(Request httpRequest) {
             for (RequestListener listener : this) {
                 listener.failed(httpRequest);

Modified: incubator/pivot/trunk/tools/src/org/apache/pivot/tools/net/Response.java
URL: http://svn.apache.org/viewvc/incubator/pivot/trunk/tools/src/org/apache/pivot/tools/net/Response.java?rev=809941&r1=809940&r2=809941&view=diff
==============================================================================
--- incubator/pivot/trunk/tools/src/org/apache/pivot/tools/net/Response.java (original)
+++ incubator/pivot/trunk/tools/src/org/apache/pivot/tools/net/Response.java Tue Sep  1 09:47:57 2009
@@ -32,36 +32,45 @@
      */
     public final class ResponseHeadersDictionary
         implements Dictionary<String, String>, Iterable<String> {
+        @Override
         public String get(String key) {
             return (responseHeaders == null ? null : responseHeaders.get(key));
         }
 
+        @Override
         public String put(String key, String value) {
             throw new UnsupportedOperationException();
         }
 
+        @Override
         public String remove(String key) {
             throw new UnsupportedOperationException();
         }
 
+        @Override
         public boolean containsKey(String key) {
             return (responseHeaders == null ? false : responseHeaders.containsKey(key));
         }
 
+        @Override
         public boolean isEmpty() {
             return (responseHeaders == null ? true : responseHeaders.isEmpty());
         }
 
+        @Override
         public Iterator<String> iterator() {
             return (responseHeaders != null ? responseHeaders.iterator() : new Iterator<String>() {
+                @Override
                 public boolean hasNext() {
                     return false;
                 }
 
+                @Override
                 public String next() {
                     throw new NoSuchElementException();
                 }
 
+                @Override
                 public void remove() {
                     throw new NoSuchElementException();
                 }