You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Ilya Pronin <ip...@twopensource.com> on 2018/07/24 00:43:15 UTC
Review Request 68029: Updated XFS disk isolator docs.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68029/
-----------------------------------------------------------
Review request for mesos and James Peach.
Bugs: MESOS-9007
https://issues.apache.org/jira/browse/MESOS-9007
Repository: mesos
Description
-------
Added project IDs reclaiming mechanism description.
Diffs
-----
docs/isolators/disk-xfs.md 96bb39ec51bfdc4b297099baf1a4cef3efe2c92f
Diff: https://reviews.apache.org/r/68029/diff/1/
Testing
-------
N/A.
Thanks,
Ilya Pronin
Re: Review Request 68029: Updated XFS disk isolator docs.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68029/#review206370
-----------------------------------------------------------
PASS: Mesos patch 68029 was successfully built and tested.
Reviews applied: `['67914', '68029']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1970/mesos-review-68029
- Mesos Reviewbot Windows
On July 24, 2018, 12:45 a.m., Ilya Pronin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68029/
> -----------------------------------------------------------
>
> (Updated July 24, 2018, 12:45 a.m.)
>
>
> Review request for mesos and James Peach.
>
>
> Bugs: MESOS-9007
> https://issues.apache.org/jira/browse/MESOS-9007
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added project IDs reclaiming mechanism description.
>
>
> Diffs
> -----
>
> docs/isolators/disk-xfs.md 96bb39ec51bfdc4b297099baf1a4cef3efe2c92f
>
>
> Diff: https://reviews.apache.org/r/68029/diff/2/
>
>
> Testing
> -------
>
> N/A.
>
>
> Thanks,
>
> Ilya Pronin
>
>
Re: Review Request 68029: Updated XFS disk isolator docs.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68029/#review206405
-----------------------------------------------------------
Ship it!
Ship It!
- James Peach
On July 24, 2018, 5:36 p.m., Ilya Pronin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68029/
> -----------------------------------------------------------
>
> (Updated July 24, 2018, 5:36 p.m.)
>
>
> Review request for mesos and James Peach.
>
>
> Bugs: MESOS-9007
> https://issues.apache.org/jira/browse/MESOS-9007
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added project IDs reclaiming mechanism description.
>
>
> Diffs
> -----
>
> docs/isolators/disk-xfs.md 96bb39ec51bfdc4b297099baf1a4cef3efe2c92f
> docs/monitoring.md 2f06e9b7b05d9cd3f447cbd3eab43bc493e25cd1
>
>
> Diff: https://reviews.apache.org/r/68029/diff/3/
>
>
> Testing
> -------
>
> N/A.
>
>
> Thanks,
>
> Ilya Pronin
>
>
Re: Review Request 68029: Updated XFS disk isolator docs.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68029/#review206420
-----------------------------------------------------------
PASS: Mesos patch 68029 was successfully built and tested.
Reviews applied: `['67914', '68029']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1976/mesos-review-68029
- Mesos Reviewbot Windows
On July 24, 2018, 5:36 p.m., Ilya Pronin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68029/
> -----------------------------------------------------------
>
> (Updated July 24, 2018, 5:36 p.m.)
>
>
> Review request for mesos and James Peach.
>
>
> Bugs: MESOS-9007
> https://issues.apache.org/jira/browse/MESOS-9007
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added project IDs reclaiming mechanism description.
>
>
> Diffs
> -----
>
> docs/isolators/disk-xfs.md 96bb39ec51bfdc4b297099baf1a4cef3efe2c92f
> docs/monitoring.md 2f06e9b7b05d9cd3f447cbd3eab43bc493e25cd1
>
>
> Diff: https://reviews.apache.org/r/68029/diff/3/
>
>
> Testing
> -------
>
> N/A.
>
>
> Thanks,
>
> Ilya Pronin
>
>
Re: Review Request 68029: Updated XFS disk isolator docs.
Posted by Ilya Pronin <ip...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68029/
-----------------------------------------------------------
(Updated July 24, 2018, 10:36 a.m.)
Review request for mesos and James Peach.
Changes
-------
Addressed review comments.
Bugs: MESOS-9007
https://issues.apache.org/jira/browse/MESOS-9007
Repository: mesos
Description
-------
Added project IDs reclaiming mechanism description.
Diffs (updated)
-----
docs/isolators/disk-xfs.md 96bb39ec51bfdc4b297099baf1a4cef3efe2c92f
docs/monitoring.md 2f06e9b7b05d9cd3f447cbd3eab43bc493e25cd1
Diff: https://reviews.apache.org/r/68029/diff/3/
Changes: https://reviews.apache.org/r/68029/diff/2-3/
Testing
-------
N/A.
Thanks,
Ilya Pronin
Re: Review Request 68029: Updated XFS disk isolator docs.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68029/#review206387
-----------------------------------------------------------
Patch looks great!
Reviews applied: [67915, 67914, 68029]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On July 24, 2018, 12:45 a.m., Ilya Pronin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68029/
> -----------------------------------------------------------
>
> (Updated July 24, 2018, 12:45 a.m.)
>
>
> Review request for mesos and James Peach.
>
>
> Bugs: MESOS-9007
> https://issues.apache.org/jira/browse/MESOS-9007
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added project IDs reclaiming mechanism description.
>
>
> Diffs
> -----
>
> docs/isolators/disk-xfs.md 96bb39ec51bfdc4b297099baf1a4cef3efe2c92f
>
>
> Diff: https://reviews.apache.org/r/68029/diff/2/
>
>
> Testing
> -------
>
> N/A.
>
>
> Thanks,
>
> Ilya Pronin
>
>
Re: Review Request 68029: Updated XFS disk isolator docs.
Posted by Ilya Pronin <ip...@twopensource.com>.
> On July 24, 2018, 10:11 a.m., James Peach wrote:
> > docs/isolators/disk-xfs.md
> > Lines 46 (patched)
> > <https://reviews.apache.org/r/68029/diff/2/?file=2063343#file2063343line46>
> >
> > Make this a link:
> >
> > ```
> > [`--disk_watch_interval`](configuration/agent.md#disk_watch_interval)
> > ```
Done.
> On July 24, 2018, 10:11 a.m., James Peach wrote:
> > docs/isolators/disk-xfs.md
> > Lines 50 (patched)
> > <https://reviews.apache.org/r/68029/diff/2/?file=2063343#file2063343line50>
> >
> > Can you document these in docs/monitoring.md as well?
Done.
- Ilya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68029/#review206396
-----------------------------------------------------------
On July 24, 2018, 10:36 a.m., Ilya Pronin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68029/
> -----------------------------------------------------------
>
> (Updated July 24, 2018, 10:36 a.m.)
>
>
> Review request for mesos and James Peach.
>
>
> Bugs: MESOS-9007
> https://issues.apache.org/jira/browse/MESOS-9007
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added project IDs reclaiming mechanism description.
>
>
> Diffs
> -----
>
> docs/isolators/disk-xfs.md 96bb39ec51bfdc4b297099baf1a4cef3efe2c92f
> docs/monitoring.md 2f06e9b7b05d9cd3f447cbd3eab43bc493e25cd1
>
>
> Diff: https://reviews.apache.org/r/68029/diff/3/
>
>
> Testing
> -------
>
> N/A.
>
>
> Thanks,
>
> Ilya Pronin
>
>
Re: Review Request 68029: Updated XFS disk isolator docs.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68029/#review206396
-----------------------------------------------------------
docs/isolators/disk-xfs.md
Lines 46 (patched)
<https://reviews.apache.org/r/68029/#comment289333>
Make this a link:
```
[`--disk_watch_interval`](configuration/agent.md#disk_watch_interval)
```
docs/isolators/disk-xfs.md
Lines 50 (patched)
<https://reviews.apache.org/r/68029/#comment289334>
Can you document these in docs/monitoring.md as well?
- James Peach
On July 24, 2018, 12:45 a.m., Ilya Pronin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68029/
> -----------------------------------------------------------
>
> (Updated July 24, 2018, 12:45 a.m.)
>
>
> Review request for mesos and James Peach.
>
>
> Bugs: MESOS-9007
> https://issues.apache.org/jira/browse/MESOS-9007
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added project IDs reclaiming mechanism description.
>
>
> Diffs
> -----
>
> docs/isolators/disk-xfs.md 96bb39ec51bfdc4b297099baf1a4cef3efe2c92f
>
>
> Diff: https://reviews.apache.org/r/68029/diff/2/
>
>
> Testing
> -------
>
> N/A.
>
>
> Thanks,
>
> Ilya Pronin
>
>
Re: Review Request 68029: Updated XFS disk isolator docs.
Posted by Ilya Pronin <ip...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68029/
-----------------------------------------------------------
(Updated July 23, 2018, 5:45 p.m.)
Review request for mesos and James Peach.
Changes
-------
Fixed grammar.
Bugs: MESOS-9007
https://issues.apache.org/jira/browse/MESOS-9007
Repository: mesos
Description
-------
Added project IDs reclaiming mechanism description.
Diffs (updated)
-----
docs/isolators/disk-xfs.md 96bb39ec51bfdc4b297099baf1a4cef3efe2c92f
Diff: https://reviews.apache.org/r/68029/diff/2/
Changes: https://reviews.apache.org/r/68029/diff/1-2/
Testing
-------
N/A.
Thanks,
Ilya Pronin