[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #594: HDDS-2995. Add integration test for Recon's Passive SCM state.

[GitBox <gi...@apache.org>]

adoroszlai commented on a change in pull request #594: HDDS-2995. Add integration test for Recon's Passive SCM state.
URL: https://github.com/apache/hadoop-ozone/pull/594#discussion_r385590041
 
 

 ##########
 File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/MiniOzoneClusterImpl.java
 ##########
 @@ -293,14 +296,9 @@ public void restartOzoneManager() throws IOException {
 
   @Override
   public void restartReconServer() {
-    try {
-      reconServer.stop();
-      reconServer.join();
-      reconServer = new ReconServer();
-      reconServer.execute(new String[]{});
-    } catch (Exception e) {
-      LOG.info("Exception while restarting Recon", e);
-    }
+    stopRecon(reconServer);
+    reconServer = new ReconServer();
+    reconServer.execute(new String[]{});
 
 Review comment:
   Can call `startRecon()` instead to avoid duplicate code?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org