You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "kacpermuda (via GitHub)" <gi...@apache.org> on 2026/09/16 14:38:18 UTC
[PR] Fix GCS operators emitting invalid OpenLineage events with no dataset name [airflow]
kacpermuda opened a new pull request, #73246:
URL: https://github.com/apache/airflow/pull/73246
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull request.
Write a good git commit message following this guide: https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the documentation.
For user-facing UI changes, please attach before/after screenshots (or a short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
`GCSDeleteObjectsOperator` and `LocalFilesystemToGCSOperator` build one OpenLineage `Dataset` per object/file without checking for falsy values. When `objects`/`src` resolves at runtime to a list containing `None` or `""` (e.g. via XCom), or `bucket_name`/`bucket` resolves to a falsy value, the emitted event has a `Dataset` with no `name`, which violates the OpenLineage spec and gets rejected by consumers, silently dropping lineage for the whole task.
This fixes both operators to skip falsy object/file names and to return an empty `OperatorLineage` when the bucket is falsy, instead of emitting a malformed event.
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR, please
change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
-->
- [X] Yes — Claude Code (Sonnet 5)
Generated-by: Claude Code (Sonnet 5) following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
---
* Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix GCS operators emitting invalid OpenLineage events with no dataset name [airflow]
Posted by "kacpermuda (via GitHub)" <gi...@apache.org>.
kacpermuda commented on code in PR #73246:
URL: https://github.com/apache/airflow/pull/73246#discussion_r4027791453
##########
providers/google/src/airflow/providers/google/cloud/transfers/local_to_gcs.py:
##########
@@ -165,6 +168,8 @@ def get_openlineage_facets_on_start(self):
dest_object = self.dst if os.path.basename(self.dst) else extract_ds_name_from_gcs_path(self.dst)
Review Comment:
Added the self.dst check above as well, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix GCS operators emitting invalid OpenLineage events with no dataset name [airflow]
Posted by "mobuchowski (via GitHub)" <gi...@apache.org>.
mobuchowski merged PR #73246:
URL: https://github.com/apache/airflow/pull/73246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix GCS operators emitting invalid OpenLineage events with no dataset name [airflow]
Posted by "SameerMesiah97 (via GitHub)" <gi...@apache.org>.
SameerMesiah97 commented on code in PR #73246:
URL: https://github.com/apache/airflow/pull/73246#discussion_r4027521586
##########
providers/google/src/airflow/providers/google/cloud/transfers/local_to_gcs.py:
##########
@@ -165,6 +168,8 @@ def get_openlineage_facets_on_start(self):
dest_object = self.dst if os.path.basename(self.dst) else extract_ds_name_from_gcs_path(self.dst)
Review Comment:
Should the destination object also be checked before constructing the output dataset? If the templated `dst` resolves to `None` or an empty string, it looks like this could still emit a dataset with no name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org